Commit 1515646
Add revision_number to DeclinedTargetVersionUpgrade (#762)
<!-- Describe what has changed in this PR -->
- Added `revision_number` to `DeclinedTargetVersionUpgrade`, which
already took in a deployment version.
- Recap about what `DeclinedTargetVersionUpgrade` does: the main
intention of this field was to "remember" which target version we have
rejected when a pinned workflow declines to AU when CAN'ing. However,
you could have matching partitions send you back stale target deployment
versions, and we don't want to "bounce back" and CAN our pinned
workflows when they see such a stale version. For that very purpose, we
resort to now store the revision number here.
<!-- Tell your future self why have you made these changes -->
- I explained it above
<!-- Are there any breaking changes on binary or code level? -->
- None, changes are additive.
- Also, no changes required from the SDK perspective
<!-- If this breaks the Server, please provide the Server PR to merge
right after this PR was merged. -->
temporalio/temporal#9895
Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>1 parent 64552cf commit 1515646
3 files changed
Lines changed: 17 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
12875 | 12875 | | |
12876 | 12876 | | |
12877 | 12877 | | |
| 12878 | + | |
| 12879 | + | |
| 12880 | + | |
| 12881 | + | |
| 12882 | + | |
12878 | 12883 | | |
12879 | 12884 | | |
12880 | 12885 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
9757 | 9757 | | |
9758 | 9758 | | |
9759 | 9759 | | |
| 9760 | + | |
| 9761 | + | |
| 9762 | + | |
| 9763 | + | |
| 9764 | + | |
| 9765 | + | |
| 9766 | + | |
9760 | 9767 | | |
9761 | 9768 | | |
9762 | 9769 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
210 | 210 | | |
211 | 211 | | |
212 | 212 | | |
| 213 | + | |
| 214 | + | |
| 215 | + | |
| 216 | + | |
| 217 | + | |
213 | 218 | | |
214 | 219 | | |
215 | 220 | | |
| |||
0 commit comments