Skip to content

Commit 2ebd0b3

Browse files
committed
make nil version == unversioned in DeploymentVersionTransition
1 parent 6b5ddbe commit 2ebd0b3

File tree

3 files changed

+10
-13
lines changed

3 files changed

+10
-13
lines changed

openapi/openapiv2.json

+2-4
Original file line numberDiff line numberDiff line change
@@ -9818,10 +9818,8 @@
98189818
"description": "Deprecated. Use `target`."
98199819
},
98209820
"deploymentVersion": {
9821-
"$ref": "#/definitions/v1WorkerDeploymentVersion"
9822-
},
9823-
"unversioned": {
9824-
"type": "boolean"
9821+
"$ref": "#/definitions/v1WorkerDeploymentVersion",
9822+
"description": "The target Version of the transition.\nIf nil, a so-far-versioned workflow is transitioning to unversioned workers."
98259823
}
98269824
},
98279825
"description": "Holds information about ongoing transition of a workflow execution from one worker\ndeployment version to another.\nExperimental. Might change in the future."

openapi/openapiv3.yaml

+5-3
Original file line numberDiff line numberDiff line change
@@ -7152,9 +7152,11 @@ components:
71527152
type: string
71537153
description: Deprecated. Use `target`.
71547154
deploymentVersion:
7155-
$ref: '#/components/schemas/WorkerDeploymentVersion'
7156-
unversioned:
7157-
type: boolean
7155+
allOf:
7156+
- $ref: '#/components/schemas/WorkerDeploymentVersion'
7157+
description: |-
7158+
The target Version of the transition.
7159+
If nil, a so-far-versioned workflow is transitioning to unversioned workers.
71587160
description: |-
71597161
Holds information about ongoing transition of a workflow execution from one worker
71607162
deployment version to another.

temporal/api/workflow/v1/message.proto

+3-6
Original file line numberDiff line numberDiff line change
@@ -244,12 +244,9 @@ message DeploymentVersionTransition {
244244
// Deprecated. Use `target`.
245245
string version = 1 [deprecated = true];
246246

247-
// Required. The target Version of the transition. If `unversioned`, a
248-
// so-far-versioned workflow is transitioning to unversioned workers.
249-
oneof target {
250-
temporal.api.deployment.v1.WorkerDeploymentVersion deployment_version = 2;
251-
bool unversioned = 3;
252-
}
247+
// The target Version of the transition.
248+
// If nil, a so-far-versioned workflow is transitioning to unversioned workers.
249+
temporal.api.deployment.v1.WorkerDeploymentVersion deployment_version = 2;
253250

254251
// Later: safe transition info
255252
}

0 commit comments

Comments
 (0)