work on comments- extract status to enum

Author: ychebotarev

openapi/openapiv2.json

@@ -15305,7 +15305,7 @@
           "type": "string"
         },
         "status": {
-          "type": "string",
+          "$ref": "#/definitions/v1WorkerStatus",
           "description": "Worker status. Possible values - \"running\", \"shutting_down\", \"shutdown\"."
         },
         "uptime": {
@@ -15419,6 +15419,16 @@
         }
       }
     },
+    "v1WorkerStatus": {
+      "type": "string",
+      "enum": [
+        "WORKER_STATUS_UNSPECIFIED",
+        "WORKER_STATUS_STATUS_RUNNING",
+        "WORKER_STATUS_SHUTTING_DOWN",
+        "WORKER_STATUS_SHUTDOWN"
+      ],
+      "default": "WORKER_STATUS_UNSPECIFIED"
+    },
     "v1WorkerVersionCapabilities": {
       "type": "object",
       "properties": {

openapi/openapiv3.yaml

@@ -12671,8 +12671,14 @@ components:
         sdkVersion:
           type: string
         status:
+          enum:
+            - WORKER_STATUS_UNSPECIFIED
+            - WORKER_STATUS_STATUS_RUNNING
+            - WORKER_STATUS_SHUTTING_DOWN
+            - WORKER_STATUS_SHUTDOWN
           type: string
           description: Worker status. Possible values - "running", "shutting_down", "shutdown".
+          format: enum
         uptime:
           pattern: ^-?(?:0|[1-9][0-9]{0,11})(?:\.[0-9]{1,9})?s$
           type: string

temporal/api/enums/v1/common.proto

@@ -96,4 +96,13 @@ enum ApplicationErrorCategory {
     APPLICATION_ERROR_CATEGORY_UNSPECIFIED = 0;
     // Expected application error with little/no severity.
     APPLICATION_ERROR_CATEGORY_BENIGN = 1;
-}
+}
+
+// (-- api-linter: core::0216::synonyms=disabled
+//     aip.dev/not-precedent: It seems we have both state and status, and status is a better fit for workers. --)
+enum WorkerStatus {
+    WORKER_STATUS_UNSPECIFIED = 0;
+    WORKER_STATUS_STATUS_RUNNING = 1;
+    WORKER_STATUS_SHUTTING_DOWN = 2;
+    WORKER_STATUS_SHUTDOWN = 3;
+}

temporal/api/worker/v1/message.proto

@@ -13,6 +13,7 @@ option csharp_namespace = "Temporalio.Api.Worker.V1";
 import "google/protobuf/duration.proto";
 import "google/protobuf/timestamp.proto";
 import "temporal/api/deployment/v1/message.proto";
+import "temporal/api/enums/v1/common.proto";
 
 message WorkerPollerInfo {
 
@@ -73,7 +74,7 @@ message WorkerInfo {
   string sdk_version = 6;
 
   // Worker status. Possible values - "running", "shutting_down", "shutdown".
-  string status = 7;
+  temporal.api.enums.v1.WorkerStatus status = 7;
 
   // Uptime of the worker, since it started.
   // This is the time since the worker started, not the time since the last heartbeat.