Commit 592d53b
committed
Fix first_execution_run_id comments on Cancel and Terminate RPCs
The comments on RequestCancelWorkflowExecution and
TerminateWorkflowExecution claimed that first_execution_run_id
validates against either the most recent or specified (by run id)
execution. In reality, the server unconditionally ignores the run id
when first_execution_run_id is set, always resolving to the most
recent execution for the workflow id.
The UpdateWorkflowExecution comment is left unchanged because its
server implementation does respect the run id when set.1 parent 6895f0b commit 592d53b
1 file changed
Lines changed: 8 additions & 6 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
737 | 737 | | |
738 | 738 | | |
739 | 739 | | |
740 | | - | |
741 | | - | |
742 | | - | |
| 740 | + | |
| 741 | + | |
| 742 | + | |
| 743 | + | |
743 | 744 | | |
744 | 745 | | |
745 | 746 | | |
| |||
887 | 888 | | |
888 | 889 | | |
889 | 890 | | |
890 | | - | |
891 | | - | |
892 | | - | |
| 891 | + | |
| 892 | + | |
| 893 | + | |
| 894 | + | |
893 | 895 | | |
894 | 896 | | |
895 | 897 | | |
| |||
0 commit comments