Skip to content

Commit 8c1f458

Browse files
committed
comments refined
1 parent 332d275 commit 8c1f458

4 files changed

Lines changed: 18 additions & 16 deletions

File tree

openapi/openapiv2.json

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -17964,7 +17964,7 @@
1796417964
},
1796517965
"timeSkippingConfig": {
1796617966
"$ref": "#/definitions/v1TimeSkippingConfig",
17967-
"description": "The propagated time-skipping config for the child workflow."
17967+
"description": "The propagated time-skipping configuration for the child workflow."
1796817968
}
1796917969
}
1797017970
},
@@ -18368,7 +18368,7 @@
1836818368
"description": "If this execution was started by a previous execution that had already skipped some time,\nit inherits the accumulated skipped duration from that execution through this field.\nThis field is set internally by the server and cannot be configured by the user."
1836918369
}
1837018370
},
18371-
"description": "Configuration for time skipping during a workflow execution.\nWhen enabled, virtual time advances automatically whenever there is no in-flight work.\nIn-flight work includes activities, child workflows, Nexus operations, signal/cancel external workflow operations,\nand possibly other features added in the future.\nUser timers are not classified as in-flight work and will be skipped over.\nWhen time advances, it skips to the earlier of the next user timer or the configured bound, if either exists.\n\nPropagation behavior of time skipping:\nThe enabled flag, bound fields, and accumulated skipped duration are propagated to related executions as follows:\n(1) Child workflows and continue-as-new: both the configuration and accumulated skipped duration are inherited\n from the current execution. The configured bound is shared across both the inherited skipped duration\n and any additional duration skipped by the new run.\n(2) Retry and cron: both the configuration and accumulated skipped duration are inherited as recorded in the\n StartWorkflowExecutionEvent of the current workflow and the accummulated skipped duration \n of the current run won't be passed.\n(3) Reset: the new run retains the time-skipping configuration of the current execution. Because reset replays\n all events up to the reset point and re-applies any UpdateWorkflowExecutionOptions changes made after that\n point, the resulting run ends up with the same final time-skipping configuration as the previous run."
18371+
"description": "Configuration for time skipping during a workflow execution.\nWhen enabled, virtual time advances automatically whenever there is no in-flight work.\nIn-flight work includes activities, child workflows, Nexus operations, signal/cancel external workflow operations,\nand possibly other features added in the future.\nUser timers are not classified as in-flight work and will be skipped over.\nWhen time advances, it skips to the earlier of the next user timer or the configured bound, if either exists.\n\nPropagation behavior of time skipping:\nThe enabled flag, bound fields, and accumulated skipped duration are propagated to related executions as follows:\n(1) Child workflows and continue-as-new: both the configuration and the accumulated skipped duration are\n inherited from the current execution. The configured bound is shared between the inherited skipped\n duration and any additional duration skipped by the new run.\n(2) Retry and cron: the configuration and accumulated skipped duration are inherited as recorded when the\n current workflow started; the accumulated skipped duration of the current run is not propagated.\n(3) Reset: the new run retains the time-skipping configuration of the current execution. Because reset replays\n all events up to the reset point and re-applies any UpdateWorkflowExecutionOptions changes made after that\n point, the resulting run ends up with the same final time-skipping configuration as the previous run."
1837218372
},
1837318373
"v1TimeoutFailureInfo": {
1837418374
"type": "object",
@@ -19652,7 +19652,7 @@
1965219652
},
1965319653
"timeSkippingConfig": {
1965419654
"$ref": "#/definitions/v1TimeSkippingConfig",
19655-
"description": "Time-skipping configuration for this workflow execution.\nIf not set, the time-skipping conf will not get updated upon request, \ni.e. the existing time-skipping conf will be preserved."
19655+
"description": "Time-skipping configuration for this workflow execution.\nIf not set, the time-skipping configuration is not updated by this request;\nthe existing configuration is preserved."
1965619656
}
1965719657
}
1965819658
},

openapi/openapiv3.yaml

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -15556,7 +15556,7 @@ components:
1555615556
timeSkippingConfig:
1555715557
allOf:
1555815558
- $ref: '#/components/schemas/TimeSkippingConfig'
15559-
description: The propagated time-skipping config for the child workflow.
15559+
description: The propagated time-skipping configuration for the child workflow.
1556015560
StartNexusOperationExecutionRequest:
1556115561
type: object
1556215562
properties:
@@ -16261,7 +16261,7 @@ components:
1626116261
If this execution was started by a previous execution that had already skipped some time,
1626216262
it inherits the accumulated skipped duration from that execution through this field.
1626316263
This field is set internally by the server and cannot be configured by the user.
16264-
description: "Configuration for time skipping during a workflow execution.\n When enabled, virtual time advances automatically whenever there is no in-flight work.\n In-flight work includes activities, child workflows, Nexus operations, signal/cancel external workflow operations,\n and possibly other features added in the future.\n User timers are not classified as in-flight work and will be skipped over.\n When time advances, it skips to the earlier of the next user timer or the configured bound, if either exists.\n \n Propagation behavior of time skipping:\n The enabled flag, bound fields, and accumulated skipped duration are propagated to related executions as follows:\n (1) Child workflows and continue-as-new: both the configuration and accumulated skipped duration are inherited\n from the current execution. The configured bound is shared across both the inherited skipped duration\n and any additional duration skipped by the new run.\n (2) Retry and cron: both the configuration and accumulated skipped duration are inherited as recorded in the\n StartWorkflowExecutionEvent of the current workflow and the accummulated skipped duration \n of the current run won't be passed.\n (3) Reset: the new run retains the time-skipping configuration of the current execution. Because reset replays\n all events up to the reset point and re-applies any UpdateWorkflowExecutionOptions changes made after that\n point, the resulting run ends up with the same final time-skipping configuration as the previous run."
16264+
description: "Configuration for time skipping during a workflow execution.\n When enabled, virtual time advances automatically whenever there is no in-flight work.\n In-flight work includes activities, child workflows, Nexus operations, signal/cancel external workflow operations,\n and possibly other features added in the future.\n User timers are not classified as in-flight work and will be skipped over.\n When time advances, it skips to the earlier of the next user timer or the configured bound, if either exists.\n \n Propagation behavior of time skipping:\n The enabled flag, bound fields, and accumulated skipped duration are propagated to related executions as follows:\n (1) Child workflows and continue-as-new: both the configuration and the accumulated skipped duration are\n inherited from the current execution. The configured bound is shared between the inherited skipped\n duration and any additional duration skipped by the new run.\n (2) Retry and cron: the configuration and accumulated skipped duration are inherited as recorded when the\n current workflow started; the accumulated skipped duration of the current run is not propagated.\n (3) Reset: the new run retains the time-skipping configuration of the current execution. Because reset replays\n all events up to the reset point and re-applies any UpdateWorkflowExecutionOptions changes made after that\n point, the resulting run ends up with the same final time-skipping configuration as the previous run."
1626516265
TimeoutFailureInfo:
1626616266
type: object
1626716267
properties:
@@ -18211,7 +18211,10 @@ components:
1821118211
timeSkippingConfig:
1821218212
allOf:
1821318213
- $ref: '#/components/schemas/TimeSkippingConfig'
18214-
description: "Time-skipping configuration for this workflow execution.\n If not set, the time-skipping conf will not get updated upon request, \n i.e. the existing time-skipping conf will be preserved."
18214+
description: |-
18215+
Time-skipping configuration for this workflow execution.
18216+
If not set, the time-skipping configuration is not updated by this request;
18217+
the existing configuration is preserved.
1821518218
WorkflowExecutionOptionsUpdatedEventAttributes:
1821618219
type: object
1821718220
properties:

temporal/api/history/v1/message.proto

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -771,7 +771,7 @@ message StartChildWorkflowExecutionInitiatedEventAttributes {
771771
// Priority metadata
772772
temporal.api.common.v1.Priority priority = 20;
773773

774-
// The propagated time-skipping config for the child workflow.
774+
// The propagated time-skipping configuration for the child workflow.
775775
temporal.api.workflow.v1.TimeSkippingConfig time_skipping_config = 21;
776776
}
777777

temporal/api/workflow/v1/message.proto

Lines changed: 8 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -580,8 +580,8 @@ message WorkflowExecutionOptions {
580580
temporal.api.common.v1.Priority priority = 2;
581581

582582
// Time-skipping configuration for this workflow execution.
583-
// If not set, the time-skipping conf will not get updated upon request,
584-
// i.e. the existing time-skipping conf will be preserved.
583+
// If not set, the time-skipping configuration is not updated by this request;
584+
// the existing configuration is preserved.
585585
TimeSkippingConfig time_skipping_config = 3;
586586
}
587587

@@ -594,12 +594,11 @@ message WorkflowExecutionOptions {
594594
//
595595
// Propagation behavior of time skipping:
596596
// The enabled flag, bound fields, and accumulated skipped duration are propagated to related executions as follows:
597-
// (1) Child workflows and continue-as-new: both the configuration and accumulated skipped duration are inherited
598-
// from the current execution. The configured bound is shared across both the inherited skipped duration
599-
// and any additional duration skipped by the new run.
600-
// (2) Retry and cron: both the configuration and accumulated skipped duration are inherited as recorded in the
601-
// StartWorkflowExecutionEvent of the current workflow and the accummulated skipped duration
602-
// of the current run won't be passed.
597+
// (1) Child workflows and continue-as-new: both the configuration and the accumulated skipped duration are
598+
// inherited from the current execution. The configured bound is shared between the inherited skipped
599+
// duration and any additional duration skipped by the new run.
600+
// (2) Retry and cron: the configuration and accumulated skipped duration are inherited as recorded when the
601+
// current workflow started; the accumulated skipped duration of the current run is not propagated.
603602
// (3) Reset: the new run retains the time-skipping configuration of the current execution. Because reset replays
604603
// all events up to the reset point and re-applies any UpdateWorkflowExecutionOptions changes made after that
605604
// point, the resulting run ends up with the same final time-skipping configuration as the previous run.
@@ -613,7 +612,7 @@ message TimeSkippingConfig {
613612
// Optional bound that limits the gap between the virtual time of this execution and wall-clock time.
614613
// Once the bound is reached, time skipping is automatically disabled,
615614
// but can be re-enabled by setting `enabled` to true via UpdateWorkflowExecutionOptions.
616-
// This bound cannot be set to a value smaller than the current skipped duration of the current execution.
615+
// This bound cannot be set to a value smaller than the execution's currently skipped duration.
617616
//
618617
// This is useful in testing scenarios where a workflow is expected to receive
619618
// signals, updates, or other external events while timers are in progress.

0 commit comments

Comments
 (0)