Skip to content

Commit a732611

Browse files
committed
Evolve documentation of update polling parameters
1 parent 8ad3751 commit a732611

File tree

2 files changed

+9
-17
lines changed

2 files changed

+9
-17
lines changed

temporal/api/update/v1/message.proto

+2-5
Original file line numberDiff line numberDiff line change
@@ -35,12 +35,9 @@ import "temporal/api/common/v1/message.proto";
3535
import "temporal/api/enums/v1/update.proto";
3636
import "temporal/api/failure/v1/message.proto";
3737

38-
// Specifies to the gRPC server how long the client wants the an update-related
39-
// RPC call to wait before returning control to the caller.
38+
// How long the client wants an update-related RPC call to wait before returning control to the caller.
4039
message WaitPolicy {
41-
42-
// Indicates the update lifecycle stage that the gRPC call should wait for
43-
// before returning.
40+
// The update stage that this request should attempt to wait for.
4441
temporal.api.enums.v1.UpdateWorkflowExecutionLifecycleStage lifecycle_stage = 1;
4542
}
4643

temporal/api/workflowservice/v1/request_response.proto

+7-12
Original file line numberDiff line numberDiff line change
@@ -1389,8 +1389,7 @@ message UpdateWorkflowExecutionRequest {
13891389
// part of the same execution chain as this id.
13901390
string first_execution_run_id = 3;
13911391

1392-
// Describes when this request should return - basically whether the
1393-
// update is synchronous, asynchronous, or somewhere in between.
1392+
// How long to wait before returning control to the caller.
13941393
temporal.api.update.v1.WaitPolicy wait_policy = 4;
13951394

13961395
// The request information that will be delivered all the way down to the
@@ -1409,14 +1408,12 @@ message UpdateWorkflowExecutionResponse {
14091408

14101409
// The most advanced lifecycle stage that the Update is known to have
14111410
// reached, where lifecycle stages are ordered
1412-
// UPDATE_WORKFLOW_EXECUTION_LIFECYCLE_STAGE_UNSPECIFIED <
14131411
// UPDATE_WORKFLOW_EXECUTION_LIFECYCLE_STAGE_ADMITTED <
14141412
// UPDATE_WORKFLOW_EXECUTION_LIFECYCLE_STAGE_ACCEPTED <
14151413
// UPDATE_WORKFLOW_EXECUTION_LIFECYCLE_STAGE_COMPLETED.
1416-
// UNSPECIFIED will be returned if and only if the server's maximum wait
1417-
// time was reached before the Update reached the stage specified in the
1418-
// request WaitPolicy, and before the context deadline expired; clients may
1419-
// may then retry the call as needed.
1414+
// If the server's maximum wait time was reached before the stage requested by the client, then
1415+
// the returned stage may be less than the requested stage. Clients may then retry the call as
1416+
// needed.
14201417
temporal.api.enums.v1.UpdateWorkflowExecutionLifecycleStage stage = 3;
14211418
}
14221419

@@ -1535,14 +1532,12 @@ message PollWorkflowExecutionUpdateResponse {
15351532
temporal.api.update.v1.Outcome outcome = 1;
15361533
// The most advanced lifecycle stage that the Update is known to have
15371534
// reached, where lifecycle stages are ordered
1538-
// UPDATE_WORKFLOW_EXECUTION_LIFECYCLE_STAGE_UNSPECIFIED <
15391535
// UPDATE_WORKFLOW_EXECUTION_LIFECYCLE_STAGE_ADMITTED <
15401536
// UPDATE_WORKFLOW_EXECUTION_LIFECYCLE_STAGE_ACCEPTED <
15411537
// UPDATE_WORKFLOW_EXECUTION_LIFECYCLE_STAGE_COMPLETED.
1542-
// UNSPECIFIED will be returned if and only if the server's maximum wait
1543-
// time was reached before the Update reached the stage specified in the
1544-
// request WaitPolicy, and before the context deadline expired; clients may
1545-
// may then retry the call as needed.
1538+
// If the server's maximum wait time was reached before the stage requested by the client, then
1539+
// the returned stage may be less than the requested stage. Clients may then retry the call as
1540+
// needed.
15461541
temporal.api.enums.v1.UpdateWorkflowExecutionLifecycleStage stage = 2;
15471542
// Sufficient information to address this update.
15481543
temporal.api.update.v1.UpdateRef update_ref = 3;

0 commit comments

Comments
 (0)