Skip to content

Commit aef6069

Browse files
committed
VersionLocalState in sync with VersionSummary + Activation/Deactivation timestamps (#585)
_**READ BEFORE MERGING:** All PRs require approval by both Server AND SDK teams before merging! This is why the number of required approvals is "2" and not "1"--two reviewers from the same team is NOT sufficient. If your PR is not approved by someone in BOTH teams, it may be summarily reverted._ <!-- Describe what has changed in this PR --> **What changed?** - Added two new timestamps to signify when a version first/last receives traffic in the `WorkerDeploymentVersionInfo` and `WorkerDeploymentInfo`. Added missing fields from VersionLocalState that were not present in VersionSummary. <!-- Tell your future self why have you made these changes --> **Why?** - Adding the two new timestamps shall allow operators to have more visibility into when a version gets activated/deactivated. - The reason fields from `VersionLocalState` were added to the `VersionSummary` is because the UI, right now, is querying a bunch of different places to get information about a specific version. This might be annoying and the aim of this PR is to make VersionSummary the source of truth for information related to a specific version. A nice cherry on top is that this shall also reduce the number of API calls to get information about a version. <!-- Are there any breaking changes on binary or code level? --> **Breaking changes** - None <!-- If this breaks the Server, please provide the Server PR to merge right after this PR was merged. --> **Server PR** - temporalio/temporal#7736)
1 parent cde9f12 commit aef6069

4 files changed

Lines changed: 139 additions & 42 deletions

File tree

deployment/v1/message.pb.go

Lines changed: 136 additions & 39 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

temporalproto/openapi/openapiv2.go

Lines changed: 1 addition & 1 deletion
Large diffs are not rendered by default.

temporalproto/openapi/openapiv3.go

Lines changed: 1 addition & 1 deletion
Large diffs are not rendered by default.

0 commit comments

Comments
 (0)