Skip to content

Commit bae790a

Browse files
authored
Warn PR authors about the merge policy (#500)
**What changed?** Add a warning to the GitHub PR template reminding everyone that both Server AND SDK teams must sign off on a PR before it's merged. **Why?** 'Cause people have merged things a couple times now without SDK review. **Breaking changes** None
1 parent 3f42081 commit bae790a

File tree

1 file changed

+2
-0
lines changed

1 file changed

+2
-0
lines changed

Diff for: .github/PULL_REQUEST_TEMPLATE.md

+2
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,5 @@
1+
_**READ BEFORE MERGING:** All PRs require approval by both Server AND SDK teams before merging! This is why the number of required approvals is "2" and not "1"--two reviewers from the same team is NOT sufficient. If your PR is not approved by someone in BOTH teams, it may be summarily reverted._
2+
13
<!-- Describe what has changed in this PR -->
24
**What changed?**
35

0 commit comments

Comments
 (0)