Skip to content

Commit bcf6ece

Browse files
committed
rm the flexibility of disable propagation for simplicity
1 parent 7855fca commit bcf6ece

4 files changed

Lines changed: 14 additions & 35 deletions

File tree

openapi/openapiv2.json

Lines changed: 4 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -16754,7 +16754,7 @@
1675416754
},
1675516755
"timeSkippingConfig": {
1675616756
"$ref": "#/definitions/v1TimeSkippingConfig",
16757-
"description": "Initial time-skipping configuration for the child workflow execution.\nThis field cannot be set explicitly; it is propagated from the parent workflow."
16757+
"description": "The propagated time-skipping config for the child workflow."
1675816758
}
1675916759
}
1676016760
},
@@ -17129,9 +17129,9 @@
1712917129
"type": "boolean",
1713017130
"description": "Enables or disables time skipping for this workflow execution."
1713117131
},
17132-
"disableChildWorkflowPropagation": {
17133-
"type": "boolean",
17134-
"description": "By default, the time skipping configuration (enabled and bound) is propagated to child workflows,\nusing the same values as the parent workflow.\nIf set, child workflows will be started with time skipping disabled.\nRegardless of this field, the start time of the child workflow uses the parent's virtual time."
17132+
"propagatedSkippedDuration": {
17133+
"type": "string",
17134+
"description": "If this execution was started by a previous execution that already skipped some time,\nit inherits the virtual time through the propagated skipped duration."
1713517135
},
1713617136
"maxSkippedDuration": {
1713717137
"type": "string",
@@ -17145,10 +17145,6 @@
1714517145
"type": "string",
1714617146
"format": "date-time",
1714717147
"description": "Absolute virtual timestamp at which time skipping is disabled.\nTime skipping will not advance beyond this point."
17148-
},
17149-
"propagatedSkippedDuration": {
17150-
"type": "string",
17151-
"description": "If this execution was started by a previous execution that already skipped some time,\nit inherits the virtual time through the propagated skipped duration."
1715217148
}
1715317149
},
1715417150
"description": "Configuration for time skipping during a workflow execution.\nWhen enabled, virtual time advances automatically whenever there is no in-flight work.\nIn-flight work includes activities, child workflows, Nexus operations, signal/cancel external workflow operations,\nand possibly other features added in the future.\nUser timers are not classified as in-flight work and will be skipped over.\nWhen time advances, it skips to the earlier of the next user timer or the configured bound, if either exists."

openapi/openapiv3.yaml

Lines changed: 6 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -14549,9 +14549,7 @@ components:
1454914549
timeSkippingConfig:
1455014550
allOf:
1455114551
- $ref: '#/components/schemas/TimeSkippingConfig'
14552-
description: |-
14553-
Initial time-skipping configuration for the child workflow execution.
14554-
This field cannot be set explicitly; it is propagated from the parent workflow.
14552+
description: The propagated time-skipping config for the child workflow.
1455514553
StartWorkflowExecutionRequest:
1455614554
type: object
1455714555
properties:
@@ -15107,13 +15105,12 @@ components:
1510715105
enabled:
1510815106
type: boolean
1510915107
description: Enables or disables time skipping for this workflow execution.
15110-
disableChildWorkflowPropagation:
15111-
type: boolean
15108+
propagatedSkippedDuration:
15109+
pattern: ^-?(?:0|[1-9][0-9]{0,11})(?:\.[0-9]{1,9})?s$
15110+
type: string
1511215111
description: |-
15113-
By default, the time skipping configuration (enabled and bound) is propagated to child workflows,
15114-
using the same values as the parent workflow.
15115-
If set, child workflows will be started with time skipping disabled.
15116-
Regardless of this field, the start time of the child workflow uses the parent's virtual time.
15112+
If this execution was started by a previous execution that already skipped some time,
15113+
it inherits the virtual time through the propagated skipped duration.
1511715114
maxSkippedDuration:
1511815115
pattern: ^-?(?:0|[1-9][0-9]{0,11})(?:\.[0-9]{1,9})?s$
1511915116
type: string
@@ -15130,12 +15127,6 @@ components:
1513015127
Absolute virtual timestamp at which time skipping is disabled.
1513115128
Time skipping will not advance beyond this point.
1513215129
format: date-time
15133-
propagatedSkippedDuration:
15134-
pattern: ^-?(?:0|[1-9][0-9]{0,11})(?:\.[0-9]{1,9})?s$
15135-
type: string
15136-
description: |-
15137-
If this execution was started by a previous execution that already skipped some time,
15138-
it inherits the virtual time through the propagated skipped duration.
1513915130
description: |-
1514015131
Configuration for time skipping during a workflow execution.
1514115132
When enabled, virtual time advances automatically whenever there is no in-flight work.

temporal/api/history/v1/message.proto

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -771,8 +771,7 @@ message StartChildWorkflowExecutionInitiatedEventAttributes {
771771
// Priority metadata
772772
temporal.api.common.v1.Priority priority = 20;
773773

774-
// Initial time-skipping configuration for the child workflow execution.
775-
// This field cannot be set explicitly; it is propagated from the parent workflow.
774+
// The propagated time-skipping config for the child workflow.
776775
temporal.api.workflow.v1.TimeSkippingConfig time_skipping_config = 21;
777776
}
778777

temporal/api/workflow/v1/message.proto

Lines changed: 3 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -596,11 +596,9 @@ message TimeSkippingConfig {
596596
// Enables or disables time skipping for this workflow execution.
597597
bool enabled = 1;
598598

599-
// By default, the time skipping configuration (enabled and bound) is propagated to child workflows,
600-
// using the same values as the parent workflow.
601-
// If set, child workflows will be started with time skipping disabled.
602-
// Regardless of this field, the start time of the child workflow uses the parent's virtual time.
603-
bool disable_child_workflow_propagation = 3;
599+
// If this execution was started by a previous execution that already skipped some time,
600+
// it inherits the virtual time through the propagated skipped duration.
601+
google.protobuf.Duration propagated_skipped_duration = 3;
604602

605603
// Optional bound that limits how far virtual time can advance while time skipping is active.
606604
// Once the bound is reached, time skipping is automatically disabled,
@@ -628,11 +626,6 @@ message TimeSkippingConfig {
628626
// Time skipping will not advance beyond this point.
629627
google.protobuf.Timestamp max_target_time = 6;
630628
}
631-
632-
// If this execution was started by a previous execution that already skipped some time,
633-
// it inherits the virtual time through the propagated skipped duration.
634-
google.protobuf.Duration propagated_skipped_duration = 7;
635-
636629
}
637630

638631
// Used to override the versioning behavior (and pinned deployment version, if applicable) of a

0 commit comments

Comments
 (0)