Skip to content

Commit be3ff37

Browse files
committed
rm the flexibility of disable propagation for simplicity
1 parent 907c659 commit be3ff37

4 files changed

Lines changed: 14 additions & 35 deletions

File tree

openapi/openapiv2.json

Lines changed: 4 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -16759,7 +16759,7 @@
1675916759
},
1676016760
"timeSkippingConfig": {
1676116761
"$ref": "#/definitions/v1TimeSkippingConfig",
16762-
"description": "Initial time-skipping configuration for the child workflow execution.\nThis field cannot be set explicitly; it is propagated from the parent workflow."
16762+
"description": "The propagated time-skipping config for the child workflow."
1676316763
}
1676416764
}
1676516765
},
@@ -17134,9 +17134,9 @@
1713417134
"type": "boolean",
1713517135
"description": "Enables or disables time skipping for this workflow execution."
1713617136
},
17137-
"disableChildWorkflowPropagation": {
17138-
"type": "boolean",
17139-
"description": "By default, the time skipping configuration (enabled and bound) is propagated to child workflows,\nusing the same values as the parent workflow.\nIf set, child workflows will be started with time skipping disabled.\nRegardless of this field, the start time of the child workflow uses the parent's virtual time."
17137+
"propagatedSkippedDuration": {
17138+
"type": "string",
17139+
"description": "If this execution was started by a previous execution that already skipped some time,\nit inherits the virtual time through the propagated skipped duration."
1714017140
},
1714117141
"maxSkippedDuration": {
1714217142
"type": "string",
@@ -17150,10 +17150,6 @@
1715017150
"type": "string",
1715117151
"format": "date-time",
1715217152
"description": "Absolute virtual timestamp at which time skipping is disabled.\nTime skipping will not advance beyond this point."
17153-
},
17154-
"propagatedSkippedDuration": {
17155-
"type": "string",
17156-
"description": "If this execution was started by a previous execution that already skipped some time,\nit inherits the virtual time through the propagated skipped duration."
1715717153
}
1715817154
},
1715917155
"description": "Configuration for time skipping during a workflow execution.\nWhen enabled, virtual time advances automatically whenever there is no in-flight work.\nIn-flight work includes activities, child workflows, Nexus operations, signal/cancel external workflow operations,\nand possibly other features added in the future.\nUser timers are not classified as in-flight work and will be skipped over.\nWhen time advances, it skips to the earlier of the next user timer or the configured bound, if either exists."

openapi/openapiv3.yaml

Lines changed: 6 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -14552,9 +14552,7 @@ components:
1455214552
timeSkippingConfig:
1455314553
allOf:
1455414554
- $ref: '#/components/schemas/TimeSkippingConfig'
14555-
description: |-
14556-
Initial time-skipping configuration for the child workflow execution.
14557-
This field cannot be set explicitly; it is propagated from the parent workflow.
14555+
description: The propagated time-skipping config for the child workflow.
1455814556
StartWorkflowExecutionRequest:
1455914557
type: object
1456014558
properties:
@@ -15110,13 +15108,12 @@ components:
1511015108
enabled:
1511115109
type: boolean
1511215110
description: Enables or disables time skipping for this workflow execution.
15113-
disableChildWorkflowPropagation:
15114-
type: boolean
15111+
propagatedSkippedDuration:
15112+
pattern: ^-?(?:0|[1-9][0-9]{0,11})(?:\.[0-9]{1,9})?s$
15113+
type: string
1511515114
description: |-
15116-
By default, the time skipping configuration (enabled and bound) is propagated to child workflows,
15117-
using the same values as the parent workflow.
15118-
If set, child workflows will be started with time skipping disabled.
15119-
Regardless of this field, the start time of the child workflow uses the parent's virtual time.
15115+
If this execution was started by a previous execution that already skipped some time,
15116+
it inherits the virtual time through the propagated skipped duration.
1512015117
maxSkippedDuration:
1512115118
pattern: ^-?(?:0|[1-9][0-9]{0,11})(?:\.[0-9]{1,9})?s$
1512215119
type: string
@@ -15133,12 +15130,6 @@ components:
1513315130
Absolute virtual timestamp at which time skipping is disabled.
1513415131
Time skipping will not advance beyond this point.
1513515132
format: date-time
15136-
propagatedSkippedDuration:
15137-
pattern: ^-?(?:0|[1-9][0-9]{0,11})(?:\.[0-9]{1,9})?s$
15138-
type: string
15139-
description: |-
15140-
If this execution was started by a previous execution that already skipped some time,
15141-
it inherits the virtual time through the propagated skipped duration.
1514215133
description: |-
1514315134
Configuration for time skipping during a workflow execution.
1514415135
When enabled, virtual time advances automatically whenever there is no in-flight work.

temporal/api/history/v1/message.proto

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -771,8 +771,7 @@ message StartChildWorkflowExecutionInitiatedEventAttributes {
771771
// Priority metadata
772772
temporal.api.common.v1.Priority priority = 20;
773773

774-
// Initial time-skipping configuration for the child workflow execution.
775-
// This field cannot be set explicitly; it is propagated from the parent workflow.
774+
// The propagated time-skipping config for the child workflow.
776775
temporal.api.workflow.v1.TimeSkippingConfig time_skipping_config = 21;
777776
}
778777

temporal/api/workflow/v1/message.proto

Lines changed: 3 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -596,11 +596,9 @@ message TimeSkippingConfig {
596596
// Enables or disables time skipping for this workflow execution.
597597
bool enabled = 1;
598598

599-
// By default, the time skipping configuration (enabled and bound) is propagated to child workflows,
600-
// using the same values as the parent workflow.
601-
// If set, child workflows will be started with time skipping disabled.
602-
// Regardless of this field, the start time of the child workflow uses the parent's virtual time.
603-
bool disable_child_workflow_propagation = 3;
599+
// If this execution was started by a previous execution that already skipped some time,
600+
// it inherits the virtual time through the propagated skipped duration.
601+
google.protobuf.Duration propagated_skipped_duration = 3;
604602

605603
// Optional bound that limits how far virtual time can advance while time skipping is active.
606604
// Once the bound is reached, time skipping is automatically disabled,
@@ -628,11 +626,6 @@ message TimeSkippingConfig {
628626
// Time skipping will not advance beyond this point.
629627
google.protobuf.Timestamp max_target_time = 6;
630628
}
631-
632-
// If this execution was started by a previous execution that already skipped some time,
633-
// it inherits the virtual time through the propagated skipped duration.
634-
google.protobuf.Duration propagated_skipped_duration = 7;
635-
636629
}
637630

638631
// Used to override the versioning behavior (and pinned deployment version, if applicable) of a

0 commit comments

Comments
 (0)