Skip to content

Commit c217a5e

Browse files
authored
Remove .gitmodules (#422)
* Remove .gitmodules * gen openapi
1 parent 29b1f4e commit c217a5e

File tree

4 files changed

+10
-12
lines changed

4 files changed

+10
-12
lines changed

.gitmodules

-3
This file was deleted.

openapi/openapiv2.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -3945,7 +3945,7 @@
39453945
"BUILD_ID_TASK_REACHABILITY_UNREACHABLE"
39463946
],
39473947
"default": "BUILD_ID_TASK_REACHABILITY_UNSPECIFIED",
3948-
"description": "Specifies which category of tasks may reach a versioned worker of a certain Build ID.\n\nTask Reachability is eventually consistent; there may be a delay until it converges to the most\naccurate value but it is designed in a way to take the more conservative side until it converges.\nFor example REACHABLE is more conservative than CLOSED_WORKFLOWS_ONLY.\n\nNote: future activities who inherit their workflow's Build ID but not its Task Queue will not be\naccounted for reachability as server cannot know if they'll happen as they do not use\nassignment rules of their Task Queue. Same goes for Child Workflows or Continue-As-New Workflows\nwho inherit the parent/previous workflow's Build ID but not its Task Queue. In those cases, make\nsure to query reachability for the parent/previous workflow's Task Queue as well.\n\n - BUILD_ID_TASK_REACHABILITY_UNSPECIFIED: Task reachability is not reported\n - BUILD_ID_TASK_REACHABILITY_REACHABLE: Build ID may be used by new workflows or activities (base on versioning rules), or there MAY\nbe open workflows or backlogged activities assigned to it.\n - BUILD_ID_TASK_REACHABILITY_CLOSED_WORKFLOWS_ONLY: Build ID does not have open workflows and is not reachable by new workflows,\nbut MAY have closed workflows within the namespace retention period.\nNot applicable to activity-only task queues.\n - BUILD_ID_TASK_REACHABILITY_UNREACHABLE: Build ID is not used for new executions, nor it has been used by any existing execution\nwithin the retention period."
3948+
"description": "Specifies which category of tasks may reach a versioned worker of a certain Build ID.\n\nTask Reachability is eventually consistent; there may be a delay (up to few minutes) until it\nconverges to the most accurate value but it is designed in a way to take the more conservative\nside until it converges. For example REACHABLE is more conservative than CLOSED_WORKFLOWS_ONLY.\n\nNote: future activities who inherit their workflow's Build ID but not its Task Queue will not be\naccounted for reachability as server cannot know if they'll happen as they do not use\nassignment rules of their Task Queue. Same goes for Child Workflows or Continue-As-New Workflows\nwho inherit the parent/previous workflow's Build ID but not its Task Queue. In those cases, make\nsure to query reachability for the parent/previous workflow's Task Queue as well.\n\n - BUILD_ID_TASK_REACHABILITY_UNSPECIFIED: Task reachability is not reported\n - BUILD_ID_TASK_REACHABILITY_REACHABLE: Build ID may be used by new workflows or activities (base on versioning rules), or there MAY\nbe open workflows or backlogged activities assigned to it.\n - BUILD_ID_TASK_REACHABILITY_CLOSED_WORKFLOWS_ONLY: Build ID does not have open workflows and is not reachable by new workflows,\nbut MAY have closed workflows within the namespace retention period.\nNot applicable to activity-only task queues.\n - BUILD_ID_TASK_REACHABILITY_UNREACHABLE: Build ID is not used for new executions, nor it has been used by any existing execution\nwithin the retention period."
39493949
},
39503950
"v1CalendarSpec": {
39513951
"type": "object",

temporal/api/enums/v1/task_queue.proto

+3-3
Original file line numberDiff line numberDiff line change
@@ -81,9 +81,9 @@ enum TaskReachability {
8181

8282
// Specifies which category of tasks may reach a versioned worker of a certain Build ID.
8383
//
84-
// Task Reachability is eventually consistent; there may be a delay until it converges to the most
85-
// accurate value but it is designed in a way to take the more conservative side until it converges.
86-
// For example REACHABLE is more conservative than CLOSED_WORKFLOWS_ONLY.
84+
// Task Reachability is eventually consistent; there may be a delay (up to few minutes) until it
85+
// converges to the most accurate value but it is designed in a way to take the more conservative
86+
// side until it converges. For example REACHABLE is more conservative than CLOSED_WORKFLOWS_ONLY.
8787
//
8888
// Note: future activities who inherit their workflow's Build ID but not its Task Queue will not be
8989
// accounted for reachability as server cannot know if they'll happen as they do not use

temporal/api/workflowservice/v1/service.proto

+6-5
Original file line numberDiff line numberDiff line change
@@ -563,17 +563,18 @@ service WorkflowService {
563563
// Use this API to manage Worker Versioning Rules for a given Task Queue. There are two types of
564564
// rules: Build ID Assignment rules and Compatible Build ID Redirect rules.
565565
//
566-
// Assignment rules are used to assign a Build ID for a new execution when it starts. Its primary
567-
// use case is to specify the latest Build ID but it has powerful features for gradual rollout
566+
// Assignment rules determine how to assign new executions to a Build IDs. Their primary
567+
// use case is to specify the latest Build ID but they have powerful features for gradual rollout
568568
// of a new Build ID.
569569
//
570-
// Once a Build ID is assigned to a workflow execution and it completes its first Workflow Task,
570+
// Once a workflow execution is assigned to a Build ID and it completes its first Workflow Task,
571571
// the workflow stays on the assigned Build ID regardless of changes in assignment rules. This
572572
// eliminates the need for compatibility between versions when you only care about using the new
573573
// version for new workflows and let existing workflows finish in their own version.
574574
//
575-
// Activities, Child Workflows and Continue-as-New executions have the option to inherit their
576-
// parent/previous workflow or use the latest assigment rules to independently select a Build ID.
575+
// Activities, Child Workflows and Continue-as-New executions have the option to inherit the
576+
// Build ID of their parent/previous workflow or use the latest assignment rules to independently
577+
// select a Build ID.
577578
//
578579
// Redirect rules should only be used when you want to move workflows and activities assigned to
579580
// one Build ID (source) to another compatible Build ID (target). You are responsible to make sure

0 commit comments

Comments
 (0)