Skip to content

Commit d051ae7

Browse files
committed
address comments
1 parent 3385ec2 commit d051ae7

1 file changed

Lines changed: 14 additions & 17 deletions

File tree

temporal/api/workflowservice/v1/request_response.proto

Lines changed: 14 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -257,10 +257,10 @@ message GetWorkflowExecutionHistoryReverseResponse {
257257
message PollWorkflowTaskQueueRequest {
258258
string namespace = 1;
259259
temporal.api.taskqueue.v1.TaskQueue task_queue = 2;
260-
// Client must pass one of the poller group IDs received in `poller_group_infos` of the last
261-
// the PollWorkflowTaskQueueResponse according to the instructions. If not set, the poll is
262-
// routed randomly which can cause it being blocked without receiving a task while the queue
263-
// actually has tasks in another server location.
260+
// Unless this is the first poll, the client must pass one of the poller group IDs received in
261+
// `poller_group_infos` of the last the PollWorkflowTaskQueueResponse according to the
262+
// instructions. If not set, the poll is routed randomly which can cause it being blocked
263+
// without receiving a task while the queue actually has tasks in another server location.
264264
string poller_group_id = 9;
265265
// The identity of the worker/client who is polling this task queue
266266
string identity = 3;
@@ -458,10 +458,10 @@ message RespondWorkflowTaskFailedResponse {
458458
message PollActivityTaskQueueRequest {
459459
string namespace = 1;
460460
temporal.api.taskqueue.v1.TaskQueue task_queue = 2;
461-
// Client must pass one of the poller group IDs received in `poller_group_infos` of the last
462-
// the PollActivityTaskQueueResponse according to the instructions. If not set, the poll is
463-
// routed randomly which can cause it being blocked without receiving a task while the queue
464-
// actually has tasks in another server location.
461+
// Unless this is the first poll, the client must pass one of the poller group IDs received in
462+
// `poller_group_infos` of the last the PollActivityTaskQueueResponse according to the
463+
// instructions. If not set, the poll is routed randomly which can cause it being blocked
464+
// without receiving a task while the queue actually has tasks in another server location.
465465
string poller_group_id = 9;
466466
// The identity of the worker/client
467467
string identity = 3;
@@ -1899,10 +1899,10 @@ message PollWorkflowExecutionUpdateResponse {
18991899
message PollNexusTaskQueueRequest {
19001900
string namespace = 1;
19011901
temporal.api.taskqueue.v1.TaskQueue task_queue = 3;
1902-
// Client must pass one of the poller group IDs received in `poller_group_infos` of the last
1903-
// the PollNexusTaskQueueResponse according to the instructions. If not set, the poll is
1904-
// routed randomly which can cause it being blocked without receiving a task while the queue
1905-
// actually has tasks in another server location.
1902+
// Unless this is the first poll, the client must pass one of the poller group IDs received in
1903+
// `poller_group_infos` of the last the PollNexusTaskQueueResponse according to the
1904+
// instructions. If not set, the poll is routed randomly which can cause it being blocked
1905+
// without receiving a task while the queue actually has tasks in another server location.
19061906
string poller_group_id = 9;
19071907
// The identity of the client who initiated this request.
19081908
string identity = 2;
@@ -1927,21 +1927,18 @@ message PollNexusTaskQueueResponse {
19271927
temporal.api.nexus.v1.Request request = 2;
19281928
// Server-advised information the SDK may use to adjust its poller count.
19291929
temporal.api.taskqueue.v1.PollerScalingDecision poller_scaling_decision = 3;
1930-
// Should be returned in RespondNexusTaskCompletedRequest and RespondNexusTaskFailedRequest
1931-
// for proper routing of handler's response.
1932-
string routing_key = 4;
19331930
// This poller group ID identifies the owner of the nexus task awaiting for synchronous
19341931
// response.
19351932
// Corresponding `RespondNexusTaskCompleted` and `RespondNexusTaskFailed` calls should pass this
19361933
// value for proper response routing.
1937-
string poller_group_id = 5;
1934+
string poller_group_id = 4;
19381935
// The weighted list of poller groups IDs that client should use for future polls to this task
19391936
// queue. Client is expected to:
19401937
// 1. Maintain minimum number of pollers no less than the number of groups.
19411938
// 2. Try to assign the next poll to a group without any pending polls,
19421939
// 3. If every group has some pending polls, assign the next poll to a group randomly
19431940
// according to the weights.
1944-
repeated temporal.api.taskqueue.v1.PollerGroupInfo poller_group_infos = 6;
1941+
repeated temporal.api.taskqueue.v1.PollerGroupInfo poller_group_infos = 5;
19451942
}
19461943

19471944
message RespondNexusTaskCompletedRequest {

0 commit comments

Comments
 (0)