Skip to content

Commit 29b1eb1

Browse files
author
Josh Berry
authored
Adjust dev-server tunables to avoid persistence rate-limiting (#626)
Rationale is explained in the code comments. Closes #621.
1 parent 8d56e1b commit 29b1eb1

1 file changed

Lines changed: 10 additions & 0 deletions

File tree

temporalcli/commands.server.go

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,17 @@ import (
1414
)
1515

1616
var defaultDynamicConfigValues = map[string]any{
17+
// Make search attributes immediately visible on creation, so users don't
18+
// have to wait for eventual consistency to happen when testing against the
19+
// dev-server. Since it's a very rare thing to create search attributes,
20+
// we're comfortable that this is very unlikely to mask bugs in user code.
1721
"system.forceSearchAttributesCacheRefreshOnRead": true,
22+
23+
// Since we disable the SA cache, we need to bump max QPS accordingly.
24+
// These numbers were chosen to maintain the ratio between the two that's
25+
// established in the defaults.
26+
"frontend.persistenceMaxQPS": 10000,
27+
"history.persistenceMaxQPS": 45000,
1828
}
1929

2030
func (t *TemporalServerStartDevCommand) run(cctx *CommandContext, args []string) error {

0 commit comments

Comments
 (0)