Merge branch 'main' into fix-username-bug

Author: chaptersix

.github/workflows/govulncheck.yml

@@ -0,0 +1,18 @@
+name: Govulncheck
+
+on:
+  pull_request:
+
+permissions:
+  contents: read
+
+jobs:
+  govulncheck:
+    name: Govulncheck
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v6
+      - uses: actions/setup-go@v6
+        with:
+          go-version-file: go.mod
+      - uses: temporalio/public-actions/golang/govulncheck@main

internal/temporalcli/commands.taskqueue_config.go

@@ -63,9 +63,9 @@ const (
 )
 
 // printZeroRateLimitWarning prints a warning when a rate limit is set to 0
-func printZeroRateLimitWarning(p *printer.Printer, limitType string) {
-	p.Printlnf("WARNING: Setting %s to 0 will STOP ALL TRAFFIC on this task queue.", limitType)
-	p.Println("         This will prevent any tasks from being dispatched until the limit is changed.")
+func printZeroRateLimitWarning(cctx *CommandContext, limitType string) {
+	fmt.Fprintf(cctx.Options.Stderr, "WARNING: Setting %s to 0 will STOP ALL TRAFFIC on this task queue.\n", limitType)
+	fmt.Fprintln(cctx.Options.Stderr, "         This will prevent any tasks from being dispatched until the limit is changed.")
 }
 
 // parseFairnessKeyWeights parses "key=weight" or "key=default" format strings
@@ -200,7 +200,7 @@ func (c *TemporalTaskQueueConfigSetCommand) run(cctx *CommandContext, args []str
 
 		// Warn about zero rate limit (stops all traffic)
 		if queueRateLimitIsZero {
-			printZeroRateLimitWarning(cctx.Printer, "queue rate limit")
+			printZeroRateLimitWarning(cctx, "queue rate limit")
 		}
 	}
 
@@ -216,7 +216,7 @@ func (c *TemporalTaskQueueConfigSetCommand) run(cctx *CommandContext, args []str
 
 		// Warn about zero rate limit
 		if fairnessRateLimitIsZero {
-			printZeroRateLimitWarning(cctx.Printer, "fairness key rate limit default")
+			printZeroRateLimitWarning(cctx, "fairness key rate limit default")
 		}
 	}
 

internal/temporalcli/commands.taskqueue_config_test.go

@@ -332,8 +332,8 @@ func (s *SharedServerSuite) TestTaskQueue_Config_Validation() {
 		"--queue-rps-limit-reason", "emergency stop",
 	)
 	s.NoError(res.Err)
-	s.Contains(res.Stdout.String(), "WARNING")
-	s.Contains(res.Stdout.String(), "STOP ALL TRAFFIC")
+	s.Contains(res.Stderr.String(), "WARNING")
+	s.Contains(res.Stderr.String(), "STOP ALL TRAFFIC")
 
 	// Duplicate fairness keys - should fail
 	res = s.Execute(