Fix the "delete namespace" prompt (#406)

We were improperly lower-casing the user's input when asking them to
confirm the namespace name, and then providing no feedback to the user
if the name didn't match, leaving them with the false impression that
the namespace was deleted even though we didn't even try.

Closes #405

Author: Josh Berry

common/util.go

@@ -489,7 +489,7 @@ func AllowedEnumValues(names map[int32]string) []string {
 }
 
 func PromptYes(msg string, autoConfirm bool) bool {
-	return Prompt(msg, autoConfirm, "yes", "y")
+	return Prompt(msg, autoConfirm, "yes", "y", "Yes", "YES", "Y")
 }
 
 // Prompt user to confirm/deny action. Supports empty expectedInputs.
@@ -504,16 +504,16 @@ func Prompt(msg string, autoConfirm bool, expectedInputs ...string) bool {
 		fmt.Print(text)
 	} else {
 		text, _ = reader.ReadString('\n')
+		text = strings.TrimRight(text, "\n")
 	}
 	fmt.Println()
 
 	if len(expectedInputs) == 0 {
 		return true
 	}
 
-	textLower := strings.ToLower(strings.TrimSpace(text))
 	for _, expectedInput := range expectedInputs {
-		if expectedInput == textLower {
+		if expectedInput == text {
 			return true
 		}
 	}

namespace/namespace_commands.go

@@ -303,7 +303,7 @@ func DeleteNamespace(c *cli.Context) error {
 
 	promptMsg := color.Red(c, "Are you sure you want to delete namespace %s? Type namespace name to confirm:", ns)
 	if !common.Prompt(promptMsg, c.Bool(common.FlagYes), ns) {
-		return nil
+		return fmt.Errorf("namespace name does not match: expected %v", ns)
 	}
 
 	client := cliclient.Factory(c.App).OperatorClient(c)