Skip to content

Commit c37570a

Browse files
Merge branch 'main' into versioning-3
2 parents f805e7f + cceb892 commit c37570a

1 file changed

Lines changed: 5 additions & 2 deletions

File tree

.github/workflows/ci.yaml

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,10 @@ jobs:
1818
- os: ubuntu-arm
1919
runsOn: buildjet-4vcpu-ubuntu-2204-arm
2020
runs-on: ${{ matrix.runsOn || matrix.os }}
21+
env:
22+
# We can't check this directly in the cloud test's `if:` condition below,
23+
# so we have to check it here and report it in an env variable.
24+
HAS_SECRETS: ${{ secrets.TEMPORAL_CLIENT_CERT != '' && secrets.TEMPORAL_CLIENT_KEY != '' }}
2125
steps:
2226
- name: Checkout repository
2327
uses: actions/checkout@v4
@@ -53,8 +57,7 @@ jobs:
5357
git diff --exit-code
5458
5559
- name: Test cloud
56-
# Only supported in non-fork runs, since secrets are not available in forks
57-
if: ${{ matrix.cloudTestTarget && (github.event.pull_request.head.repo.full_name == '' || github.event.pull_request.head.repo.full_name == 'temporalio/cli') }}
60+
if: ${{ matrix.cloudTestTarget && env.HAS_SECRETS == 'true' }}
5861
env:
5962
TEMPORAL_ADDRESS: ${{ vars.TEMPORAL_CLIENT_NAMESPACE }}.tmprl.cloud:7233
6063
TEMPORAL_NAMESPACE: ${{ vars.TEMPORAL_CLIENT_NAMESPACE }}

0 commit comments

Comments
 (0)