Skip to content

Commit 52f74c5

Browse files
authored
Keep an admintools version separate from temporal version. (#207)
* Keep an admintools version separate from temporal version. This allows us to account for new admintools tagging format. * Adjust release action to take an admintools version.
1 parent 1f95f48 commit 52f74c5

11 files changed

+15
-9
lines changed

.env

+1
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,7 @@ CASSANDRA_VERSION=3.11.9
33
ELASTICSEARCH_VERSION=7.16.2
44
MYSQL_VERSION=8
55
TEMPORAL_VERSION=1.24.0
6+
TEMPORAL_ADMINTOOLS_VERSION=1.24.0-tctl-1.18.1-cli-0.12.0
67
TEMPORAL_UI_VERSION=2.26.2
78
POSTGRESQL_VERSION=13
89
POSTGRES_PASSWORD=temporal

.github/workflows/create-release.yml

+5
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,9 @@ on:
66
tag:
77
description: "Tag for new version (1.23.4)"
88
required: true
9+
admintools_tag:
10+
description: "Admin tools version (1.23.4-tctl-1.0-cli-1.0)"
11+
required: true
912

1013
jobs:
1114
create-tag:
@@ -40,8 +43,10 @@ jobs:
4043
- name: Update images version
4144
env:
4245
TAG: ${{ github.event.inputs.tag }}
46+
ADMINTOOLS_TAG: ${{ github.event.inputs.admintools_tag }}
4347
run: |
4448
sed -i -e "s/^TEMPORAL_VERSION=.*$/TEMPORAL_VERSION=$TAG/g" .env
49+
sed -i -e "s/^TEMPORAL_ADMINTOOLS_VERSION=.*$/TEMPORAL_ADMINTOOLS_VERSION=$ADMINTOOLS_TAG/g" .env
4550
if [ -n "$(git diff --stat)" ]; then
4651
git add .
4752
git commit -m "Bump Server version to $TAG"

docker-compose-cass-es.yml

+1-1
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,7 @@ services:
5353
environment:
5454
- TEMPORAL_ADDRESS=temporal:7233
5555
- TEMPORAL_CLI_ADDRESS=temporal:7233
56-
image: temporalio/admin-tools:${TEMPORAL_VERSION}
56+
image: temporalio/admin-tools:${TEMPORAL_ADMINTOOLS_VERSION}
5757
networks:
5858
- temporal-network
5959
stdin_open: true

docker-compose-cockroach-es.yml

+1-1
Original file line numberDiff line numberDiff line change
@@ -67,7 +67,7 @@ services:
6767
environment:
6868
- TEMPORAL_ADDRESS=temporal:7233
6969
- TEMPORAL_CLI_ADDRESS=temporal:7233
70-
image: temporalio/admin-tools:${TEMPORAL_VERSION}
70+
image: temporalio/admin-tools:${TEMPORAL_ADMINTOOLS_VERSION}
7171
networks:
7272
- temporal-network
7373
stdin_open: true

docker-compose-cockroach.yml

+1-1
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,7 @@ services:
4646
environment:
4747
- TEMPORAL_ADDRESS=temporal:7233
4848
- TEMPORAL_CLI_ADDRESS=temporal:7233
49-
image: temporalio/admin-tools:${TEMPORAL_VERSION}
49+
image: temporalio/admin-tools:${TEMPORAL_ADMINTOOLS_VERSION}
5050
networks:
5151
- temporal-network
5252
stdin_open: true

docker-compose-multirole.yaml

+1-1
Original file line numberDiff line numberDiff line change
@@ -236,7 +236,7 @@ services:
236236
environment:
237237
- TEMPORAL_CLI_ADDRESS=temporal-nginx:7233
238238
- TEMPORAL_ADDRESS=temporal-nginx:7233
239-
image: temporalio/admin-tools:${TEMPORAL_VERSION}
239+
image: temporalio/admin-tools:${TEMPORAL_ADMINTOOLS_VERSION}
240240
stdin_open: true
241241
tty: true
242242
networks:

docker-compose-mysql-es.yml

+1-1
Original file line numberDiff line numberDiff line change
@@ -58,7 +58,7 @@ services:
5858
environment:
5959
- TEMPORAL_ADDRESS=temporal:7233
6060
- TEMPORAL_CLI_ADDRESS=temporal:7233
61-
image: temporalio/admin-tools:${TEMPORAL_VERSION}
61+
image: temporalio/admin-tools:${TEMPORAL_ADMINTOOLS_VERSION}
6262
networks:
6363
- temporal-network
6464
stdin_open: true

docker-compose-mysql.yml

+1-1
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@ services:
3838
environment:
3939
- TEMPORAL_ADDRESS=temporal:7233
4040
- TEMPORAL_CLI_ADDRESS=temporal:7233
41-
image: temporalio/admin-tools:${TEMPORAL_VERSION}
41+
image: temporalio/admin-tools:${TEMPORAL_ADMINTOOLS_VERSION}
4242
networks:
4343
- temporal-network
4444
stdin_open: true

docker-compose-postgres-opensearch.yml

+1-1
Original file line numberDiff line numberDiff line change
@@ -67,7 +67,7 @@ services:
6767
environment:
6868
- TEMPORAL_ADDRESS=temporal:7233
6969
- TEMPORAL_CLI_ADDRESS=temporal:7233
70-
image: temporalio/admin-tools:${TEMPORAL_VERSION}
70+
image: temporalio/admin-tools:${TEMPORAL_ADMINTOOLS_VERSION}
7171
networks:
7272
- temporal-network
7373
stdin_open: true

docker-compose-postgres.yml

+1-1
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,7 @@ services:
3939
environment:
4040
- TEMPORAL_ADDRESS=temporal:7233
4141
- TEMPORAL_CLI_ADDRESS=temporal:7233
42-
image: temporalio/admin-tools:${TEMPORAL_VERSION}
42+
image: temporalio/admin-tools:${TEMPORAL_ADMINTOOLS_VERSION}
4343
networks:
4444
- temporal-network
4545
stdin_open: true

docker-compose.yml

+1-1
Original file line numberDiff line numberDiff line change
@@ -60,7 +60,7 @@ services:
6060
environment:
6161
- TEMPORAL_ADDRESS=temporal:7233
6262
- TEMPORAL_CLI_ADDRESS=temporal:7233
63-
image: temporalio/admin-tools:${TEMPORAL_VERSION}
63+
image: temporalio/admin-tools:${TEMPORAL_ADMINTOOLS_VERSION}
6464
networks:
6565
- temporal-network
6666
stdin_open: true

0 commit comments

Comments
 (0)