Use full chart version in job name to improve Argo compat.

Allow people to disable ttlSecondsAfterFinished but default to setting it as
it's best practise to avoid orphaned pods hanging around.

Based on #792.

Documentation changes to follow.

Author: robholland

charts/temporal/templates/server-job.yaml

@@ -1,7 +1,8 @@
+{{- $jobName := include "temporal.componentname" (list $ (printf "schema-%d-%d" $.Chart.Version $.Release.Revision | replace "." "-")) }}
 apiVersion: batch/v1
 kind: Job
 metadata:
-  name: {{ include "temporal.componentname" (list $ (printf "schema-%d" .Release.Revision | replace "." "-")) }}
+  name: {{ $jobName }}
   labels:
     {{- include "temporal.resourceLabels" (list $ "database" "") | nindent 4 }}
   {{- with $.Values.schema.jobAnnotations }}
@@ -10,10 +11,10 @@ metadata:
   {{- end }}
 spec:
   backoffLimit: {{ $.Values.schema.backoffLimit }}
-  ttlSecondsAfterFinished: 86400
+  ttlSecondsAfterFinished: {{ $.Values.schema.ttlSecondsAfterFinished }}
   template:
     metadata:
-      name: {{ include "temporal.componentname" (list $ (printf "schema-%d" .Release.Revision | replace "." "-")) }}
+      name: {{ $jobName }}
       labels:
         {{- include "temporal.resourceLabels" (list $ "database" "") | nindent 8 }}
         {{- with $.Values.schema.podLabels }}

charts/temporal/tests/server_job_test.yaml

@@ -196,3 +196,29 @@ tests:
       - equal:
           path: spec.template.metadata.labels.custom-pod-label
           value: ghi
+  - it: sets backoffLimit and ttlSecondsAfterFinished on the job
+    set:
+      server:
+        config:
+          persistence:
+            datastores:
+              default:
+                sql:
+                  pluginName: mysql8
+                  connectAddr: "temporal-persistence:3306"
+                  databaseName: temporal
+              visibility:
+                sql:
+                  pluginName: mysql8
+                  connectAddr: "temporal-visibility:3306"
+                  databaseName: temporal_visibility
+      schema:
+        backoffLimit: 5
+        ttlSecondsAfterFinished: 3600
+    asserts:
+      - equal:
+          path: spec.backoffLimit
+          value: 5
+      - equal:
+          path: spec.ttlSecondsAfterFinished
+          value: 3600

charts/temporal/values.yaml

@@ -508,6 +508,7 @@ web:
   podDisruptionBudget: {}
 schema:
   backoffLimit: 100
+  ttlSecondsAfterFinished: 86400
   jobAnnotations: {}
   podAnnotations: {}
   podLabels: {}