Skip to content

Commit bb7cc73

Browse files
authored
#74 bug(timeout): increase worflow pool timeout
#74 bug(timeout): increase workflow pool timeout
2 parents 9e6bf02 + 148a728 commit bb7cc73

2 files changed

Lines changed: 7 additions & 3 deletions

File tree

activity/activity_pool.go

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -70,7 +70,6 @@ func newActivityPool(codec rrt.Codec, graceTimeout time.Duration, listener event
7070
}, nil
7171
}
7272

73-
// initWorkers request workers info from underlying PHP and configures temporal workers linked to the pool.
7473
func (pool *activityPoolImpl) Start(ctx context.Context, temporal client.Temporal) error {
7574
const op = errors.Op("activity_pool_start")
7675
pool.dc = temporal.GetDataConverter()
@@ -90,7 +89,6 @@ func (pool *activityPoolImpl) Start(ctx context.Context, temporal client.Tempora
9089
return nil
9190
}
9291

93-
// initWorkers request workers info from underlying PHP and configures temporal workers linked to the pool.
9492
func (pool *activityPoolImpl) Destroy(ctx context.Context) error {
9593
for i := 0; i < len(pool.tWorkers); i++ {
9694
pool.tWorkers[i].Stop()

workflow/worker.go

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -62,7 +62,13 @@ func newPool(codec rrt.Codec, factory server.Server, graceTimeout time.Duration,
6262
env := map[string]string{RR_MODE: roadrunner_temporal.RRMode, RR_CODEC: codec.GetName()}
6363

6464
cfg := rrPool.Config{
65-
NumWorkers: 1,
65+
Debug: false,
66+
NumWorkers: 1,
67+
MaxJobs: 0,
68+
AllocateTimeout: time.Hour * 240,
69+
DestroyTimeout: time.Second * 30,
70+
// no supervisor for the workflow worker
71+
Supervisor: nil,
6672
}
6773

6874
p, err := factory.NewWorkerPool(

0 commit comments

Comments
 (0)