Review comments

Author: Sushisource

src/WorkerVersioning/AutoUpgradingWorkflowV1.workflow.cs

@@ -41,9 +41,5 @@ await Workflow.ExecuteActivityAsync(
     }
 
     [WorkflowSignal]
-    public Task DoNextSignalAsync(string signal)
-    {
-        signals.Enqueue(signal);
-        return Task.CompletedTask;
-    }
+    public async Task DoNextSignalAsync(string signal) => signals.Enqueue(signal);
 }

…ng/AutoUpgradingWorkflowV1_1.workflow.cs …/AutoUpgradingWorkflowV1Dot1.workflow.cssrc/WorkerVersioning/AutoUpgradingWorkflowV1_1.workflow.cs renamed to src/WorkerVersioning/AutoUpgradingWorkflowV1Dot1.workflow.cs src/WorkerVersioning/AutoUpgradingWorkflowV1_1.workflow.cs renamed to src/WorkerVersioning/AutoUpgradingWorkflowV1Dot1.workflow.cs

@@ -53,9 +53,5 @@ await Workflow.ExecuteActivityAsync(
     }
 
     [WorkflowSignal]
-    public Task DoNextSignalAsync(string signal)
-    {
-        signals.Enqueue(signal);
-        return Task.CompletedTask;
-    }
+    public async Task DoNextSignalAsync(string signal) => signals.Enqueue(signal);
 }

src/WorkerVersioning/PinnedWorkflowV1.workflow.cs

@@ -40,9 +40,5 @@ await Workflow.ExecuteActivityAsync(
     }
 
     [WorkflowSignal]
-    public Task DoNextSignalAsync(string signal)
-    {
-        signals.Enqueue(signal);
-        return Task.CompletedTask;
-    }
+    public async Task DoNextSignalAsync(string signal) => signals.Enqueue(signal);
 }

src/WorkerVersioning/PinnedWorkflowV2.workflow.cs

@@ -41,9 +41,5 @@ await Workflow.ExecuteActivityAsync(
     }
 
     [WorkflowSignal]
-    public Task DoNextSignalAsync(string signal)
-    {
-        signals.Enqueue(signal);
-        return Task.CompletedTask;
-    }
+    public async Task DoNextSignalAsync(string signal) => signals.Enqueue(signal);
 }

src/WorkerVersioning/WorkerV1.cs

@@ -23,8 +23,7 @@ public static async Task RunAsync(ITemporalClient client, CancellationToken canc
             }
             .AddWorkflow<AutoUpgradingWorkflowV1>()
             .AddWorkflow<PinnedWorkflowV1>()
-            .AddActivity(new MyActivities().SomeActivity)
-            .AddActivity(new MyActivities().SomeIncompatibleActivity));
+            .AddAllActivities(new MyActivities()));
 
         Console.WriteLine($"Starting worker with version: {deploymentVersion}");
         await worker.ExecuteAsync(cancellationToken);

src/WorkerVersioning/WorkerV1_1.cs src/WorkerVersioning/WorkerV1Dot1.cssrc/WorkerVersioning/WorkerV1_1.cs renamed to src/WorkerVersioning/WorkerV1Dot1.cs

@@ -23,8 +23,7 @@ public static async Task RunAsync(ITemporalClient client, CancellationToken canc
             }
             .AddWorkflow<AutoUpgradingWorkflowV1Dot1>()
             .AddWorkflow<PinnedWorkflowV1>()
-            .AddActivity(new MyActivities().SomeActivity)
-            .AddActivity(new MyActivities().SomeIncompatibleActivity));
+            .AddAllActivities(new MyActivities()));
 
         Console.WriteLine($"Starting worker with version: {deploymentVersion}");
         await worker.ExecuteAsync(cancellationToken);

src/WorkerVersioning/WorkerV2.cs

@@ -23,8 +23,7 @@ public static async Task RunAsync(ITemporalClient client, CancellationToken canc
             }
             .AddWorkflow<AutoUpgradingWorkflowV1Dot1>()
             .AddWorkflow<PinnedWorkflowV2>()
-            .AddActivity(new MyActivities().SomeActivity)
-            .AddActivity(new MyActivities().SomeIncompatibleActivity));
+            .AddAllActivities(new MyActivities()));
 
         Console.WriteLine($"Starting worker with version: {deploymentVersion}");
         await worker.ExecuteAsync(cancellationToken);