Skip to content

Commit 55dd4d1

Browse files
THardy98THardy98
committed
pr suggestions
1 parent bc3ef4a commit 55dd4d1

41 files changed

Lines changed: 170 additions & 148 deletions

File tree

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

‎activity_heartbeating/starter.rb‎

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -5,11 +5,12 @@
55
require_relative 'my_workflow'
66

77
# Load config and apply defaults
8-
positional_args, keyword_args = Temporalio::EnvConfig::ClientConfig.load_client_connect_options
9-
positional_args = ['localhost:7233', 'default'] if positional_args.empty?
8+
args, kwargs = Temporalio::EnvConfig::ClientConfig.load_client_connect_options
9+
args[0] ||= 'localhost:7233' # Default address
10+
args[1] ||= 'default' # Default namespace
1011

1112
# Create a client
12-
client = Temporalio::Client.connect(*positional_args, **keyword_args)
13+
client = Temporalio::Client.connect(*args, **kwargs)
1314

1415
workflow_id = 'activity-heartbeating-workflow-id'
1516
task_queue = 'activity-heartbeating-sample'

‎activity_heartbeating/worker.rb‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -8,12 +8,12 @@
88
require 'temporalio/worker'
99

1010
# Load config and apply defaults
11-
positional_args, keyword_args = Temporalio::EnvConfig::ClientConfig.load_client_connect_options
12-
positional_args = ['localhost:7233', 'default'] if positional_args.empty?
13-
keyword_args[:logger] = Logger.new($stdout, level: Logger::INFO)
11+
args, kwargs = Temporalio::EnvConfig::ClientConfig.load_client_connect_options
12+
args[0] ||= 'localhost:7233' # Default address
13+
args[1] ||= 'default' # Default namespace
1414

1515
# Create a Temporal client
16-
client = Temporalio::Client.connect(*positional_args, **keyword_args)
16+
client = Temporalio::Client.connect(*args, **kwargs, logger: Logger.new($stdout, level: Logger::INFO))
1717

1818
# Create worker with the activities and workflow
1919
worker = Temporalio::Worker.new(

‎activity_simple/starter.rb‎

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -5,11 +5,12 @@
55
require_relative 'my_workflow'
66

77
# Load config and apply defaults
8-
positional_args, keyword_args = Temporalio::EnvConfig::ClientConfig.load_client_connect_options
9-
positional_args = ['localhost:7233', 'default'] if positional_args.empty?
8+
args, kwargs = Temporalio::EnvConfig::ClientConfig.load_client_connect_options
9+
args[0] ||= 'localhost:7233' # Default address
10+
args[1] ||= 'default' # Default namespace
1011

1112
# Create a client
12-
client = Temporalio::Client.connect(*positional_args, **keyword_args)
13+
client = Temporalio::Client.connect(*args, **kwargs)
1314

1415
# Run workflow
1516
puts 'Executing workflow'

‎activity_simple/worker.rb‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -8,12 +8,12 @@
88
require 'temporalio/worker'
99

1010
# Load config and apply defaults
11-
positional_args, keyword_args = Temporalio::EnvConfig::ClientConfig.load_client_connect_options
12-
positional_args = ['localhost:7233', 'default'] if positional_args.empty?
13-
keyword_args[:logger] = Logger.new($stdout, level: Logger::INFO)
11+
args, kwargs = Temporalio::EnvConfig::ClientConfig.load_client_connect_options
12+
args[0] ||= 'localhost:7233' # Default address
13+
args[1] ||= 'default' # Default namespace
1414

1515
# Create a Temporal client
16-
client = Temporalio::Client.connect(*positional_args, **keyword_args)
16+
client = Temporalio::Client.connect(*args, **kwargs, logger: Logger.new($stdout, level: Logger::INFO))
1717

1818
# Use an instance for the stateful DB activity, other activity we will pass
1919
# in as class meaning it is instantiated each attempt

‎activity_worker/activity_worker.rb‎

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -6,11 +6,12 @@
66
require 'temporalio/worker'
77

88
# Load config and apply defaults
9-
positional_args, keyword_args = Temporalio::EnvConfig::ClientConfig.load_client_connect_options
10-
positional_args = ['localhost:7233', 'default'] if positional_args.empty?
9+
args, kwargs = Temporalio::EnvConfig::ClientConfig.load_client_connect_options
10+
args[0] ||= 'localhost:7233' # Default address
11+
args[1] ||= 'default' # Default namespace
1112

1213
# Create a client
13-
client = Temporalio::Client.connect(*positional_args, **keyword_args)
14+
client = Temporalio::Client.connect(*args, **kwargs)
1415

1516
# Create worker with the client and activity
1617
worker = Temporalio::Worker.new(

‎activity_worker/starter.rb‎

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -4,11 +4,12 @@
44
require 'temporalio/env_config'
55

66
# Load config and apply defaults
7-
positional_args, keyword_args = Temporalio::EnvConfig::ClientConfig.load_client_connect_options
8-
positional_args = ['localhost:7233', 'default'] if positional_args.empty?
7+
args, kwargs = Temporalio::EnvConfig::ClientConfig.load_client_connect_options
8+
args[0] ||= 'localhost:7233' # Default address
9+
args[1] ||= 'default' # Default namespace
910

1011
# Create a client
11-
client = Temporalio::Client.connect(*positional_args, **keyword_args)
12+
client = Temporalio::Client.connect(*args, **kwargs)
1213

1314
# Run workflow
1415
result = client.execute_workflow(

‎coinbase_ruby/starter.rb‎

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -11,11 +11,12 @@
1111
require 'temporal-ruby'
1212

1313
# Load config and apply defaults
14-
positional_args, keyword_args = Temporalio::EnvConfig::ClientConfig.load_client_connect_options
15-
positional_args = ['localhost:7233', 'default'] if positional_args.empty?
14+
args, kwargs = Temporalio::EnvConfig::ClientConfig.load_client_connect_options
15+
args[0] ||= 'localhost:7233' # Default address
16+
args[1] ||= 'default' # Default namespace
1617

1718
# Create Temporal SDK client
18-
client = Temporalio::Client.connect(*positional_args, **keyword_args)
19+
client = Temporalio::Client.connect(*args, **kwargs)
1920

2021
# Run Coinbase workflow
2122
result = client.execute_workflow(

‎coinbase_ruby/worker.rb‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -15,12 +15,12 @@
1515
require 'temporal/worker'
1616

1717
# Load config and apply defaults
18-
positional_args, keyword_args = Temporalio::EnvConfig::ClientConfig.load_client_connect_options
19-
positional_args = ['localhost:7233', 'default'] if positional_args.empty?
20-
keyword_args[:logger] = Logger.new($stdout, level: Logger::INFO)
18+
args, kwargs = Temporalio::EnvConfig::ClientConfig.load_client_connect_options
19+
args[0] ||= 'localhost:7233' # Default address
20+
args[1] ||= 'default' # Default namespace
2121

2222
# Create a Temporal client
23-
client = Temporalio::Client.connect(*positional_args, **keyword_args)
23+
client = Temporalio::Client.connect(*args, **kwargs, logger: Logger.new($stdout, level: Logger::INFO))
2424

2525
# Create Temporal worker with the activity and workflow on the coinbase-ruby-sample-temporal task queue
2626
worker = Temporalio::Worker.new(

‎context_propagation/starter.rb‎

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -7,15 +7,16 @@
77
require_relative 'say_hello_workflow'
88

99
# Load config and apply defaults
10-
positional_args, keyword_args = Temporalio::EnvConfig::ClientConfig.load_client_connect_options
11-
positional_args = ['localhost:7233', 'default'] if positional_args.empty?
12-
keyword_args[:logger] = Logger.new($stdout, level: Logger::INFO)
10+
args, kwargs = Temporalio::EnvConfig::ClientConfig.load_client_connect_options
11+
args[0] ||= 'localhost:7233' # Default address
12+
args[1] ||= 'default' # Default namespace
1313
# Add the context propagation interceptor to propagate the :my_user
1414
# thread/fiber local
15-
keyword_args[:interceptors] = [ContextPropagation::Interceptor.new(:my_user)]
15+
interceptors = [ContextPropagation::Interceptor.new(:my_user)]
1616

1717
# Create a Temporal client
18-
client = Temporalio::Client.connect(*positional_args, **keyword_args)
18+
client = Temporalio::Client.connect(*args, **kwargs, logger: Logger.new($stdout, level: Logger::INFO),
19+
interceptors: interceptors)
1920

2021
# Set user as "Alice" which will get propagated in a distributed way through
2122
# the workflow and activity via Temporal headers

‎context_propagation/worker.rb‎

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -9,14 +9,15 @@
99
require 'temporalio/worker'
1010

1111
# Load config and apply defaults
12-
positional_args, keyword_args = Temporalio::EnvConfig::ClientConfig.load_client_connect_options
13-
positional_args = ['localhost:7233', 'default'] if positional_args.empty?
14-
keyword_args[:logger] = Logger.new($stdout, level: Logger::INFO)
12+
args, kwargs = Temporalio::EnvConfig::ClientConfig.load_client_connect_options
13+
args[0] ||= 'localhost:7233' # Default address
14+
args[1] ||= 'default' # Default namespace
1515
# Add the context propagation interceptor to propagate the :my_user thread/fiber local
16-
keyword_args[:interceptors] = [ContextPropagation::Interceptor.new(:my_user)]
16+
interceptors = [ContextPropagation::Interceptor.new(:my_user)]
1717

1818
# Create a Temporal client
19-
client = Temporalio::Client.connect(*positional_args, **keyword_args)
19+
client = Temporalio::Client.connect(*args, **kwargs, logger: Logger.new($stdout, level: Logger::INFO),
20+
interceptors: interceptors)
2021

2122
# Create worker with the activity and workflow
2223
worker = Temporalio::Worker.new(

0 commit comments

Comments
 (0)