add infrequent polling sample, with benign application failure

THardy98 · THardy98 · commit 1f54636e04b8 · 2025-06-21T15:55:12.000+02:00
diff --git a/.scripts/list-of-samples.json b/.scripts/list-of-samples.json
@@ -26,6 +26,7 @@
     "nestjs-exchange-rates",
     "nextjs-ecommerce-oneclick",
     "patching-api",
+    "polling",
     "production",
     "protobufs",
     "query-subscriptions",
diff --git a/polling/infrequent/.eslintignore b/polling/infrequent/.eslintignore
@@ -0,0 +1,5 @@
+node_modules
+coverage
+jest.config.js
+lib
+.eslintrc.js
diff --git a/polling/infrequent/.eslintrc.js b/polling/infrequent/.eslintrc.js
@@ -0,0 +1,48 @@
+const { builtinModules } = require('module');
+
+const ALLOWED_NODE_BUILTINS = new Set(['assert']);
+
+module.exports = {
+  root: true,
+  parser: '@typescript-eslint/parser',
+  parserOptions: {
+    project: './tsconfig.json',
+    tsconfigRootDir: __dirname,
+  },
+  plugins: ['@typescript-eslint', 'deprecation'],
+  extends: [
+    'eslint:recommended',
+    'plugin:@typescript-eslint/eslint-recommended',
+    'plugin:@typescript-eslint/recommended',
+    'prettier',
+  ],
+  rules: {
+    // recommended for safety
+    '@typescript-eslint/no-floating-promises': 'error', // forgetting to await Activities and Workflow APIs is bad
+    'deprecation/deprecation': 'warn',
+
+    // code style preference
+    'object-shorthand': ['error', 'always'],
+
+    // relaxed rules, for convenience
+    '@typescript-eslint/no-unused-vars': [
+      'warn',
+      {
+        argsIgnorePattern: '^_',
+        varsIgnorePattern: '^_',
+      },
+    ],
+    '@typescript-eslint/no-explicit-any': 'off',
+  },
+  overrides: [
+    {
+      files: ['src/workflows.ts', 'src/workflows-*.ts', 'src/workflows/*.ts'],
+      rules: {
+        'no-restricted-imports': [
+          'error',
+          ...builtinModules.filter((m) => !ALLOWED_NODE_BUILTINS.has(m)).flatMap((m) => [m, `node:${m}`]),
+        ],
+      },
+    },
+  ],
+};
diff --git a/polling/infrequent/.gitignore b/polling/infrequent/.gitignore
@@ -0,0 +1,2 @@
+lib
+node_modules
diff --git a/polling/infrequent/.npmrc b/polling/infrequent/.npmrc
@@ -0,0 +1 @@
+package-lock=false
diff --git a/polling/infrequent/.nvmrc b/polling/infrequent/.nvmrc
@@ -0,0 +1 @@
+22
diff --git a/polling/infrequent/.post-create b/polling/infrequent/.post-create
@@ -0,0 +1,18 @@
+To begin development, install the Temporal CLI:
+
+Mac: {cyan brew install temporal}
+Other: Download and extract the latest release from https://github.com/temporalio/cli/releases/latest
+
+Start Temporal Server:
+
+{cyan temporal server start-dev}
+
+Use Node version 18+ (v22.x is recommended):
+
+Mac: {cyan brew install node@22}
+Other: https://nodejs.org/en/download/
+
+Then, in the project directory, using two other shells, run these commands:
+
+{cyan npm run start.watch}
+{cyan npm run workflow}
diff --git a/polling/infrequent/.prettierignore b/polling/infrequent/.prettierignore
@@ -0,0 +1 @@
+lib
diff --git a/polling/infrequent/.prettierrc b/polling/infrequent/.prettierrc
@@ -0,0 +1,2 @@
+printWidth: 120
+singleQuote: true
diff --git a/polling/infrequent/README.md b/polling/infrequent/README.md
@@ -0,0 +1,25 @@
+# Frequently Polling Activity
+
+This sample shows how we can implement frequent polling (1 second or faster) inside our Activity. The implementation is a loop that polls our service and then sleeps for the poll interval (1 second in the sample).
+
+To ensure that polling Activity is restarted in a timely manner, we make sure that it heartbeats on every iteration. Note that heartbeating only works if we set the `heartbeat_timeout` to a shorter value than the Activity `start_to_close_timeout` timeout.
+
+To run, first see [README.md](../../README.md) for prerequisites.
+
+The Workflow will continue to poll the service and heartbeat on every iteration until it succeeds.
+
+Note that with frequent polling, the Activity may execute for a long time, and it may be beneficial to set a Timeout on the Activity to avoid long-running Activities that are not heartbeating.
+
+If the polling interval needs to be changed during runtime, the Activity needs to be canceled and a new instance with the updated arguments needs to be started.
+
+### Testing
+
+- Jest: `npm run test`:
+  - [`src/test/workflows.test.ts`](./src/test/workflows.test.ts)
+
+### Running this sample
+
+1. `temporal server start-dev` to start [Temporal Server](https://github.com/temporalio/cli/#installation).
+2. `npm install` to install dependencies.
+3. `npm run start.watch` to start the Worker.
+4. In another shell, `npm run workflow` to run the Workflow Client.
diff --git a/polling/infrequent/jest.config.js b/polling/infrequent/jest.config.js
@@ -0,0 +1,11 @@
+/** @type {import('ts-jest/dist/types').InitialOptionsTsJest} */
+module.exports = {
+  preset: 'ts-jest',
+  testEnvironment: 'node',
+  modulePathIgnorePatterns: ['lib'],
+  clearMocks: true,
+  collectCoverage: true,
+  coverageDirectory: 'coverage',
+  coveragePathIgnorePatterns: ['/node_modules/', '/lib/'],
+  coverageProvider: 'babel',
+};
diff --git a/polling/infrequent/package.json b/polling/infrequent/package.json
@@ -0,0 +1,50 @@
+{
+  "name": "temporal-polling-frequent",
+  "version": "0.1.0",
+  "private": true,
+  "scripts": {
+    "build": "tsc --build",
+    "build.watch": "tsc --build --watch",
+    "format": "prettier --write .",
+    "format:check": "prettier --check .",
+    "lint": "eslint .",
+    "start": "ts-node src/worker.ts",
+    "start.watch": "nodemon src/worker.ts",
+    "test": "jest",
+    "workflow": "ts-node src/client.ts"
+  },
+  "nodemonConfig": {
+    "execMap": {
+      "ts": "ts-node"
+    },
+    "ext": "ts",
+    "watch": [
+      "src"
+    ]
+  },
+  "dependencies": {
+    "@temporalio/activity": "^1.11.8",
+    "@temporalio/client": "^1.11.8",
+    "@temporalio/worker": "^1.11.8",
+    "@temporalio/workflow": "^1.11.8",
+    "nanoid": "3.x"
+  },
+  "devDependencies": {
+    "@temporalio/testing": "^1.11.8",
+    "@tsconfig/node18": "^18.2.4",
+    "@types/jest": "^29.5.14",
+    "@types/mocha": "8.x",
+    "@types/node": "^22.9.1",
+    "@typescript-eslint/eslint-plugin": "^8.18.0",
+    "@typescript-eslint/parser": "^8.18.0",
+    "eslint": "^8.57.1",
+    "eslint-config-prettier": "^9.1.0",
+    "eslint-plugin-deprecation": "^3.0.0",
+    "jest": "^29.7.0",
+    "nodemon": "^3.1.7",
+    "prettier": "^3.4.2",
+    "ts-jest": "^29.2.5",
+    "ts-node": "^10.9.2",
+    "typescript": "^5.6.3"
+  }
+}
diff --git a/polling/infrequent/src/activities.ts b/polling/infrequent/src/activities.ts
@@ -0,0 +1,20 @@
+import { ComposeGreetingInput, getServiceResult } from "./service";
+import {
+  ApplicationFailure,
+  ApplicationFailureCategory,
+} from '@temporalio/common';
+
+export async function composeGreeting(input: ComposeGreetingInput): Promise<string> {
+    try {
+      return await getServiceResult(input);
+    } catch (err) {
+      const message = err instanceof Error ? err.message : String(err);
+      throw ApplicationFailure.create({
+        message,
+        // Set the error as BENIGN to indicate it is an expected error.
+        // BENIGN errors have activity failure logs downgraded to DEBUG level
+        // and do not emit activity failure metrics.
+        category: ApplicationFailureCategory.BENIGN,
+      });
+    }
+}
diff --git a/polling/infrequent/src/client.ts b/polling/infrequent/src/client.ts
@@ -0,0 +1,23 @@
+// @@@SNIPSTART typescript-polling-frequent
+import { Connection, Client } from '@temporalio/client';
+import { greetingWorkflow } from './workflows';
+import { nanoid } from 'nanoid';
+
+async function run() {
+  const connection = await Connection.connect({ address: 'localhost:7233' });
+  const client = new Client({ connection });
+
+  const handle = await client.workflow.start(greetingWorkflow, {
+    taskQueue: 'frequent-activity-polling-task-queue',
+    workflowId: 'workflow-' + nanoid(),
+  });
+  console.log(`Started workflow ${handle.workflowId}`);
+
+  console.log(await handle.result());
+}
+
+run().catch((err) => {
+  console.error(err);
+  process.exit(1);
+});
+// @@@SNIPEND
diff --git a/polling/infrequent/src/service.ts b/polling/infrequent/src/service.ts
@@ -0,0 +1,21 @@
+import { activityInfo } from '@temporalio/activity';
+
+export interface ComposeGreetingInput {
+    greeting: string;
+    name: string;
+}
+
+const ERROR_ATTEMPTS = 5
+const attempts = new Map<string, number> ();
+
+export async function getServiceResult(input: ComposeGreetingInput): Promise<string> {
+    const workflowId = activityInfo().workflowId;
+    const currentCount = attempts.get(workflowId) ?? 0;
+    attempts.set(workflowId, currentCount + 1);
+
+    console.log(`Attempt ${attempts[workflowId]} of ${ERROR_ATTEMPTS} to invoke service`);
+    if (attempts[workflowId] === ERROR_ATTEMPTS) {
+        return `${input.greeting}, ${input.name}!`
+    }
+    throw new Error("service is down");
+}
diff --git a/polling/infrequent/src/test/workflows.test.ts b/polling/infrequent/src/test/workflows.test.ts
@@ -0,0 +1,49 @@
+import { TestWorkflowEnvironment } from '@temporalio/testing';
+import { Worker } from '@temporalio/worker';
+import * as activities from '../activities';
+import type * as activitiesType from '../activities';
+import { greetingWorkflow } from '../workflows';
+import { nanoid } from 'nanoid';
+
+describe('frequent polling workflow', function () {
+  let testEnv: TestWorkflowEnvironment;
+  const taskQueue = 'frequent-activity-polling-task-queue';
+
+  beforeAll(async () => {
+    testEnv = await TestWorkflowEnvironment.createLocal();
+  });
+
+  afterAll(async () => {
+    await testEnv?.teardown();
+  });
+
+  it('runs returns expected greeting', async () => {
+    const { client, nativeConnection } = testEnv;
+
+    const mockActivities: typeof activitiesType = {
+      composeGreeting: jest.fn(activities.composeGreeting),
+    };
+
+    const worker = await Worker.create({
+      connection: nativeConnection,
+      workflowsPath: require.resolve('../workflows'),
+      activities: mockActivities,
+      taskQueue,
+    });
+
+    expect(mockActivities.composeGreeting).toHaveBeenCalledTimes(0);
+
+    const result = await worker.runUntil(
+      client.workflow.execute(greetingWorkflow, {
+        args: ['Temporal'],
+        workflowId: nanoid(),
+        taskQueue,
+      }),
+    );
+
+    assert.equal(result, 'Hello, Temporal!');
+    // Check that the activity isn't being retried. The recurring polling is
+    // happeing within the activity.
+    expect(mockActivities.composeGreeting).toHaveBeenCalledTimes(1);
+  });
+});
diff --git a/polling/infrequent/src/worker.ts b/polling/infrequent/src/worker.ts
@@ -0,0 +1,28 @@
+// @@@SNIPSTART typescript-polling-frequent
+import { NativeConnection, Worker } from '@temporalio/worker';
+import * as activities from './activities';
+
+async function run() {
+  const connection = await NativeConnection.connect({
+    address: 'localhost:7233',
+  });
+  try {
+    const worker = await Worker.create({
+      connection,
+      namespace: 'default',
+      taskQueue: 'frequent-activity-polling-task-queue',
+      workflowsPath: require.resolve('./workflows'),
+      activities,
+    });
+    await worker.run();
+  } finally {
+    // Close the connection once the worker has stopped
+    await connection.close();
+  }
+}
+
+run().catch((err) => {
+  console.error(err);
+  process.exit(1);
+});
+// @@@SNIPEND
diff --git a/polling/infrequent/src/workflows.ts b/polling/infrequent/src/workflows.ts
@@ -0,0 +1,15 @@
+// @@@SNIPSTART typescript-polling-frequent
+import type * as activities from './activities';
+
+const { composeGreeting } = proxyActivities<typeof activities>({
+  startToCloseTimeout: '1 minute',
+  heartbeatTimeout: '2s',
+});
+
+export async function greetingWorkflow(name: string): Promise<string> {
+  return await composeGreeting({
+    greeting: "Hello",
+    name,
+  })
+}
+// @@@SNIPEND
diff --git a/polling/infrequent/tsconfig.json b/polling/infrequent/tsconfig.json
@@ -0,0 +1,13 @@
+{
+  "extends": "@tsconfig/node18/tsconfig.json",
+  "version": "5.6.3",
+  "compilerOptions": {
+    "lib": ["es2021"],
+    "declaration": true,
+    "declarationMap": true,
+    "sourceMap": true,
+    "rootDir": "./src",
+    "outDir": "./lib"
+  },
+  "include": ["src/**/*.ts"]
+}

Original file line number	Diff line number	Diff line change
`@@ -0,0 +1,2 @@`
	`1`	`+printWidth: 120`
	`2`	`+singleQuote: true`