fix not - invoked closures

Author: Quinn-With-Two-Ns

contrib/tools/workflowcheck/determinism/checker.go

@@ -516,6 +516,11 @@ func containsAnonAssignToVar(node ast.Node, obj types.Object, callPos token.Pos,
 		if found || n == nil || n.Pos() >= callPos {
 			return false
 		}
+		// Don't descend into function literals — assignments inside closures
+		// that are only defined (not invoked) should not count.
+		if _, ok := n.(*ast.FuncLit); ok {
+			return false
+		}
 		if assign, ok := n.(*ast.AssignStmt); ok {
 			for i, lhs := range assign.Lhs {
 				if lhsIdent, ok := lhs.(*ast.Ident); ok && info.ObjectOf(lhsIdent) == obj && i < len(assign.Rhs) {

contrib/tools/workflowcheck/workflow/testdata/src/a/workflow.go

@@ -138,6 +138,16 @@ func WorkflowLocalActivityIfElseOverridden(ctx workflow.Context) error {
 	return nil
 }
 
+func WorkflowLocalActivityAnonInClosure(ctx workflow.Context) error {
+	f := myLocalActivity
+	_ = func() {
+		f = func(ctx context.Context) error { return nil }
+		_ = f
+	}
+	workflow.ExecuteLocalActivity(ctx, f)
+	return nil
+}
+
 func WorkflowLocalActivityFuncParam(ctx workflow.Context, f func(ctx context.Context) error) error {
 	workflow.ExecuteLocalActivity(ctx, f)
 	return nil