Merge branch 'master' into d/20260406-164203

Author: donald-pinckney

.github/workflows/build-native-image.yml

@@ -69,36 +69,39 @@ jobs:
           ref: ${{ env.INPUT_REF }}
 
       - name: Set up Java
-        if: matrix.os_family != 'Linux'
+        if: matrix.os_family != 'linux'
         uses: actions/setup-java@v5
         with:
           java-version: 23
           distribution: "graalvm"
 
       - name: Set up Gradle
-        if: matrix.os_family != 'Linux'
+        if: matrix.os_family != 'linux'
         uses: gradle/actions/setup-gradle@v5
 
       - name: Build native test server (non-Docker)
-        if: matrix.os_family != 'Linux'
+        if: matrix.os_family != 'linux'
         run: |
           ./gradlew -PnativeBuild :temporal-test-server:nativeCompile
 
       - name: Build native test server (Docker non-musl)
-        if: matrix.os_family == 'Linux' && matrix.musl == false
+        if: matrix.os_family == 'linux' && matrix.musl == false
         run: |
+          IMAGE_ID=$(docker build -q ./docker/native-image)
           docker run \
             --rm -w /github/workspace -v "$(pwd):/github/workspace" \
-            $(docker build -q ./docker/native-image) \
+            "$IMAGE_ID" \
             sh -c "./gradlew -PnativeBuild :temporal-test-server:nativeCompile"
 
       - name: Build native test server (Docker musl)
-        if: matrix.os_family == 'Linux' && matrix.musl == true
+        if: matrix.os_family == 'linux' && matrix.musl == true
         run: |
+          IMAGE_ID=$(docker build -q ./docker/native-image-musl)
           docker run \
             --rm -w /github/workspace -v "$(pwd):/github/workspace" \
-            $(docker build -q ./docker/native-image-musl) \
+            "$IMAGE_ID" \
             sh -c "./gradlew -PnativeBuild -PnativeBuildMusl  :temporal-test-server:nativeCompile"
+
       # path ends in a wildcard because on windows the file ends in '.exe'
       - name: Upload executable to workflow
         if: ${{ inputs.upload_artifact }}

.github/workflows/ci.yml

@@ -191,7 +191,7 @@ jobs:
       - name: Set up Java
         uses: actions/setup-java@v5
         with:
-          java-version: "11"
+          java-version: "23"
           distribution: "temurin"
 
       - name: Set up Gradle
@@ -200,6 +200,30 @@ jobs:
       - name: Run copyright and code format checks
         run: ./gradlew --no-daemon spotlessCheck
 
+  javadoc:
+    name: Javadoc
+    runs-on: ubuntu-latest
+    timeout-minutes: 20
+    steps:
+      - name: Checkout repo
+        uses: actions/checkout@v5
+        with:
+          fetch-depth: 0
+          submodules: recursive
+          ref: ${{ github.event.pull_request.head.sha }}
+
+      - name: Set up Java
+        uses: actions/setup-java@v5
+        with:
+          java-version: "23"
+          distribution: "temurin"
+
+      - name: Set up Gradle
+        uses: gradle/actions/setup-gradle@v5
+
+      - name: Run javadoc
+        run: ./gradlew --no-daemon javadoc
+
   build_native_images:
     name: Build native test server
     uses: ./.github/workflows/build-native-image.yml

.gitignore

@@ -18,4 +18,6 @@ src/main/idls/*
 .settings
 .vscode/
 */bin
-/.claude
+/.claude
+mise.local.toml
+**/.factorypath

docker/native-image/dockerfile

@@ -6,7 +6,7 @@ ENV JAVA_HOME=/usr/lib64/graalvm/graalvm-community-java23
 COPY --from=ghcr.io/graalvm/native-image-community:23 $JAVA_HOME $JAVA_HOME
 ENV PATH="${JAVA_HOME}/bin:${PATH}"
 RUN apt-get -y update --allow-releaseinfo-change && apt-get install -V -y software-properties-common
-RUN add-apt-repository ppa:ubuntu-toolchain-r/test
+RUN add-apt-repository -y ppa:ubuntu-toolchain-r/test
 RUN apt-get update
 # We need to update gcc and g++ to 10 for Graal to work on ARM64
 RUN apt-get install -y git build-essential zlib1g-dev gcc-10 g++-10

gradle/java.gradle

@@ -32,9 +32,8 @@ subprojects {
 
     javadoc {
         options.encoding = 'UTF-8'
-        if (JavaVersion.current().isJava8Compatible()) {
-            options.addStringOption('Xdoclint:none', '-quiet')
-        }
+        options.addStringOption('Xdoclint:reference', '-quiet')
+        options.addBooleanOption('Werror', true)
         if (JavaVersion.current().isJava9Compatible()) {
             options.addBooleanOption('html5', true)
         }

temporal-envconfig/src/main/java/io/temporal/envconfig/ClientConfig.java

@@ -44,13 +44,16 @@ public static ClientConfig getDefaultInstance() {
   private static String getDefaultConfigFilePath() {
     String userDir = System.getProperty("user.home");
     if (userDir == null || userDir.isEmpty()) {
-      throw new RuntimeException("failed getting user home directory");
+      return null;
     }
     return getDefaultConfigFilePath(userDir, System.getProperty("os.name"), System.getenv());
   }
 
   static String getDefaultConfigFilePath(
       String userDir, String osName, Map<String, String> environment) {
+    if (userDir == null || userDir.isEmpty()) {
+      return null;
+    }
     if (osName != null) {
       String osNameLower = osName.toLowerCase();
       if (osNameLower.contains("mac")) {
@@ -60,7 +63,7 @@ static String getDefaultConfigFilePath(
       if (osNameLower.contains("win")) {
         String appData = environment != null ? environment.get("APPDATA") : null;
         if (appData == null || appData.isEmpty()) {
-          throw new RuntimeException("%APPDATA% is not defined");
+          return null;
         }
         return Paths.get(appData, "temporalio", "temporal.toml").toString();
       }
@@ -122,6 +125,10 @@ public static ClientConfig load(LoadClientConfigOptions options) throws IOExcept
       if (file == null || file.isEmpty()) {
         file = getDefaultConfigFilePath();
       }
+      // No config dir available — return default empty config
+      if (file == null) {
+        return getDefaultInstance();
+      }
       try {
         ClientConfigToml.TomlClientConfig result = reader.readValue(new File(file));
         return new ClientConfig(ClientConfigToml.getClientProfiles(result));
@@ -172,7 +179,7 @@ public static ClientConfig fromToml(byte[] tomlData, ClientConfigFromTomlOptions
    *
    * @param config the client config to convert
    * @return the TOML data as bytes
-   * @apiNote The output will not be identical to the input if the config was loaded from a file
+   *     <p>Note: The output will not be identical to the input if the config was loaded from a file
    *     because comments and formatting are not preserved.
    */
   public static byte[] toTomlAsBytes(ClientConfig config) throws IOException {

temporal-envconfig/src/test/java/io/temporal/envconfig/ClientConfigProfileTest.java

@@ -325,6 +325,22 @@ public void defaultConfigFilePath() {
         ClientConfig.getDefaultConfigFilePath("/home/test", "Linux", Collections.emptyMap()));
   }
 
+  @Test
+  public void loadDefaultConfigMissingHomeDir() throws IOException {
+    String original = System.getProperty("user.home");
+    try {
+      System.setProperty("user.home", "");
+      ClientConfig config =
+          ClientConfig.load(
+              LoadClientConfigOptions.newBuilder().setEnvOverrides(Collections.emptyMap()).build());
+      Assert.assertEquals(ClientConfig.getDefaultInstance(), config);
+    } finally {
+      if (original != null) {
+        System.setProperty("user.home", original);
+      }
+    }
+  }
+
   @Test
   public void parseToml() throws IOException {
     String toml =

temporal-remote-data-encoder/src/main/java/io/temporal/payload/codec/AbstractRemoteDataEncoderCodec.java

@@ -11,8 +11,6 @@
 /**
  * Performs encoding/decoding of the payloads via the Remote Data Encoder (RDE) available over http.
  *
- * <p>
- *
  * <h2>Remote Data Encoder Http Server specification</h2>
  *
  * <p>RDE Server must:

temporal-sdk/src/main/java/io/temporal/activity/ActivityInfo.java

@@ -126,8 +126,8 @@ public interface ActivityInfo {
   /**
    * Return the priority of the activity task.
    *
-   * @apiNote If unset or on an older server version, this method will return {@link
-   *     Priority#getDefaultInstance()}.
+   * <p>Note: If unset or on an older server version, this method will return {@link
+   * Priority#getDefaultInstance()}.
    */
   @Experimental
   @Nonnull

temporal-sdk/src/main/java/io/temporal/activity/ActivityInterface.java

@@ -42,8 +42,6 @@
  * When <code>CImpl</code> instance is registered with the {@link io.temporal.worker.Worker} the
  * following activities are registered:
  *
- * <p>
- *
  * <ul>
  *   <li>B_a
  *   <li>B_b