Skip to content

Commit 2eaf28a

Browse files
committed
Remove unused listActivitiesPaginated interceptor
1 parent 5d8d055 commit 2eaf28a

5 files changed

Lines changed: 0 additions & 148 deletions

File tree

temporal-sdk/src/main/java/io/temporal/client/ActivityListPage.java

Lines changed: 0 additions & 63 deletions
This file was deleted.

temporal-sdk/src/main/java/io/temporal/common/interceptors/ActivityClientCallsInterceptor.java

Lines changed: 0 additions & 44 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,6 @@
55
import io.temporal.client.ActivityExecutionDescription;
66
import io.temporal.client.ActivityExecutionMetadata;
77
import io.temporal.client.ActivityFailedException;
8-
import io.temporal.client.ActivityListPage;
98
import io.temporal.client.StartActivityOptions;
109
import io.temporal.common.Experimental;
1110
import java.lang.reflect.Type;
@@ -89,16 +88,6 @@ public interface ActivityClientCallsInterceptor {
8988
*/
9089
ListActivitiesOutput listActivities(ListActivitiesInput input);
9190

92-
/**
93-
* Returns a single page of activity execution metadata matching the Visibility query in {@code
94-
* input}. The returned {@link ActivityListPage} includes a token that can be passed back in a
95-
* subsequent call to retrieve the next page.
96-
*
97-
* @param input Visibility query string, optional next-page token, and pagination options
98-
* @return output containing the page of results and a next-page token ({@code null} if last page)
99-
*/
100-
ListActivitiesPaginatedOutput listActivitiesPaginated(ListActivitiesPaginatedInput input);
101-
10291
/**
10392
* Returns the count of activity executions matching the Visibility query in {@code input}.
10493
*
@@ -383,39 +372,6 @@ public Stream<ActivityExecutionMetadata> getStream() {
383372
}
384373
}
385374

386-
@Experimental
387-
final class ListActivitiesPaginatedInput {
388-
private final String query;
389-
private final @Nullable byte[] nextPageToken;
390-
391-
public ListActivitiesPaginatedInput(String query, @Nullable byte[] nextPageToken) {
392-
this.query = query;
393-
this.nextPageToken = nextPageToken;
394-
}
395-
396-
public String getQuery() {
397-
return query;
398-
}
399-
400-
@Nullable
401-
public byte[] getNextPageToken() {
402-
return nextPageToken;
403-
}
404-
}
405-
406-
@Experimental
407-
final class ListActivitiesPaginatedOutput {
408-
private final ActivityListPage page;
409-
410-
public ListActivitiesPaginatedOutput(ActivityListPage page) {
411-
this.page = page;
412-
}
413-
414-
public ActivityListPage getPage() {
415-
return page;
416-
}
417-
}
418-
419375
@Experimental
420376
final class CountActivitiesInput {
421377
private final String query;

temporal-sdk/src/main/java/io/temporal/common/interceptors/ActivityClientCallsInterceptorBase.java

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -47,11 +47,6 @@ public ListActivitiesOutput listActivities(ListActivitiesInput input) {
4747
return next.listActivities(input);
4848
}
4949

50-
@Override
51-
public ListActivitiesPaginatedOutput listActivitiesPaginated(ListActivitiesPaginatedInput input) {
52-
return next.listActivitiesPaginated(input);
53-
}
54-
5550
@Override
5651
public CountActivitiesOutput countActivities(CountActivitiesInput input) {
5752
return next.countActivities(input);

temporal-sdk/src/main/java/io/temporal/internal/client/RootActivityClientInvoker.java

Lines changed: 0 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,6 @@
44
import static io.temporal.internal.common.WorkflowExecutionUtils.makeUserMetaData;
55

66
import com.google.common.collect.Iterators;
7-
import com.google.protobuf.ByteString;
87
import io.grpc.Deadline;
98
import io.grpc.Status;
109
import io.grpc.StatusRuntimeException;
@@ -336,27 +335,6 @@ public ListActivitiesOutput listActivities(ListActivitiesInput input) {
336335
Spliterators.spliteratorUnknownSize(wrappedIterator, CHARACTERISTICS), false));
337336
}
338337

339-
@Override
340-
public ListActivitiesPaginatedOutput listActivitiesPaginated(ListActivitiesPaginatedInput input) {
341-
ListActivityExecutionsRequest.Builder req =
342-
ListActivityExecutionsRequest.newBuilder().setNamespace(clientOptions.getNamespace());
343-
if (input.getQuery() != null) {
344-
req.setQuery(input.getQuery());
345-
}
346-
if (input.getNextPageToken() != null) {
347-
req.setNextPageToken(ByteString.copyFrom(input.getNextPageToken()));
348-
}
349-
ListActivityExecutionsResponse response = genericClient.listActivities(req.build());
350-
List<ActivityExecutionMetadata> activities = new ArrayList<>();
351-
for (io.temporal.api.activity.v1.ActivityExecutionListInfo info :
352-
response.getExecutionsList()) {
353-
activities.add(ActivityExecutionMetadata.fromListInfo(info));
354-
}
355-
byte[] nextToken =
356-
response.getNextPageToken().isEmpty() ? null : response.getNextPageToken().toByteArray();
357-
return new ListActivitiesPaginatedOutput(new ActivityListPage(activities, nextToken));
358-
}
359-
360338
@Override
361339
public CountActivitiesOutput countActivities(CountActivitiesInput input) {
362340
CountActivityExecutionsRequest.Builder req =

temporal-sdk/src/test/java/io/temporal/common/interceptors/ActivityClientCallsInterceptorBaseTest.java

Lines changed: 0 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,6 @@
77
import io.temporal.client.ActivityExecutionDescription;
88
import io.temporal.client.ActivityExecutionMetadata;
99
import io.temporal.client.ActivityFailedException;
10-
import io.temporal.client.ActivityListPage;
1110
import io.temporal.client.StartActivityOptions;
1211
import io.temporal.common.interceptors.ActivityClientCallsInterceptor.*;
1312
import java.time.Duration;
@@ -147,17 +146,4 @@ public void testCountActivitiesDelegatesToNext() {
147146
assertSame(output, result);
148147
verify(next).countActivities(input);
149148
}
150-
151-
@Test
152-
public void testListActivitiesPaginatedDelegatesToNext() {
153-
ActivityListPage page = new ActivityListPage(Collections.emptyList(), null);
154-
ListActivitiesPaginatedOutput output = new ListActivitiesPaginatedOutput(page);
155-
when(next.listActivitiesPaginated(any(ListActivitiesPaginatedInput.class))).thenReturn(output);
156-
157-
ListActivitiesPaginatedInput input = new ListActivitiesPaginatedInput("query", null);
158-
ListActivitiesPaginatedOutput result = base.listActivitiesPaginated(input);
159-
160-
assertSame(output, result);
161-
verify(next).listActivitiesPaginated(input);
162-
}
163149
}

0 commit comments

Comments
 (0)