Apply DataConverter to results of .getLastFailure

Author: GregoryTravis

temporal-sdk/src/main/java/io/temporal/client/ActivityExecutionDescription.java

@@ -132,8 +132,10 @@ public Instant getLastStartedTime() {
 
   /** Failure details from the last failed attempt. {@code null} if no failure has occurred. */
   @Nullable
-  public io.temporal.api.failure.v1.Failure getLastFailure() {
-    return info().hasLastFailure() ? info().getLastFailure() : null;
+  public Exception getLastFailure() {
+    return info().hasLastFailure()
+        ? dataConverter.failureToException(info().getLastFailure())
+        : null;
   }
 
   /** Identity of the worker that last processed this activity. */

temporal-sdk/src/test/java/io/temporal/client/functional/StandaloneActivityTest.java

@@ -14,7 +14,6 @@
 import io.temporal.api.enums.v1.ActivityExecutionStatus;
 import io.temporal.api.enums.v1.ActivityIdConflictPolicy;
 import io.temporal.api.enums.v1.ActivityIdReusePolicy;
-import io.temporal.api.failure.v1.Failure;
 import io.temporal.client.*;
 import io.temporal.common.RetryOptions;
 import io.temporal.common.interceptors.ActivityClientCallsInterceptor;
@@ -816,12 +815,10 @@ public void testDescribeLastFailureIsPopulatedDuringRetryBackoff() {
           Duration.ofSeconds(60),
           () -> {
             ActivityExecutionDescription desc = handle.describe();
-            Failure lastFailure = desc.getLastFailure();
+            Exception lastFailure = desc.getLastFailure();
             assertNotNull("last_failure should be set after a failed attempt", lastFailure);
             assertEquals("deliberate failure", lastFailure.getMessage());
-            // raw info must agree with the typed accessor
             assertTrue(desc.getRawInfo().hasLastFailure());
-            assertEquals(lastFailure, desc.getRawInfo().getLastFailure());
           });
     } finally {
       try {