Merge branch 'master' into dependabot/github_actions/mikepenz/action-junit-report-6

Author: tconley1428

.github/workflows/build-native-image.yml

@@ -102,7 +102,7 @@ jobs:
       # path ends in a wildcard because on windows the file ends in '.exe'
       - name: Upload executable to workflow
         if: ${{ inputs.upload_artifact }}
-        uses: actions/upload-artifact@v4
+        uses: actions/upload-artifact@v5
         with:
           name: ${{ matrix.musl && format('{0}_{1}_musl', matrix.os_family, matrix.arch) || format('{0}_{1}', matrix.os_family, matrix.arch)}}
           path: |

.github/workflows/nightly-throughput-stress.yml

@@ -4,9 +4,6 @@ on:
   schedule:
     # Run at 3 AM PST (11:00 UTC) - offset from existing nightly
     - cron: '00 11 * * *'
-  push:
-    branches:
-      - add-nightly-throughput-stress-workflow
   workflow_dispatch:
     inputs:
       duration:
@@ -24,8 +21,15 @@ on:
         required: false
         default: 360
         type: number
+      is_experiment:
+        description: 'Mark this run as an experiment (excluded from nightly dashboards)'
+        required: false
+        default: false
+        type: boolean
+
 permissions:
     contents: read
+    id-token: write
 
 env:
   # Workflow configuration
@@ -35,11 +39,20 @@ env:
   # Logging and artifacts
   WORKER_LOG_DIR: /tmp/throughput-stress-logs
 
+  # AWS S3 metrics upload ARN
+  AWS_S3_METRICS_UPLOAD_ROLE_ARN: ${{ vars.AWS_S3_METRICS_UPLOAD_ROLE_ARN }}
+
   # Omes configuration
   OMES_REPO: temporalio/omes
   OMES_REF: main
   RUN_ID: ${{ github.run_id }}-throughput-stress
 
+  # Prometheus version
+  PROM_VERSION: "3.8.0"
+
+  # Language
+  SDK_LANG: "java"
+
 jobs:
   throughput-stress:
     runs-on: ubuntu-latest-4-cores
@@ -68,7 +81,7 @@ jobs:
           path: omes
 
       - name: Setup Go
-        uses: actions/setup-go@v5
+        uses: actions/setup-go@v6
         with:
           go-version-file: omes/go.mod
           cache-dependency-path: omes/go.sum
@@ -88,6 +101,13 @@ jobs:
       - name: Install Temporal CLI
         uses: temporalio/setup-temporal@v0
 
+      - name: Install Prometheus
+        run: |
+          wget -q https://github.com/prometheus/prometheus/releases/download/v${PROM_VERSION}/prometheus-${PROM_VERSION}.linux-amd64.tar.gz
+          tar xzf prometheus-${PROM_VERSION}.linux-amd64.tar.gz
+          sudo mv prometheus-${PROM_VERSION}.linux-amd64/prometheus /usr/local/bin/
+          prometheus --version
+
       - name: Setup log directory
         run: mkdir -p $WORKER_LOG_DIR
 
@@ -114,22 +134,47 @@ jobs:
           # to give CI a bit more time for visibility consistency
           go run ./cmd run-scenario-with-worker \
             --scenario throughput_stress \
-            --language java \
+            --language $SDK_LANG \
             --version $(pwd)/.. \
             --run-id $RUN_ID \
             --duration $TEST_DURATION \
             --timeout $TEST_TIMEOUT \
             --max-concurrent 10 \
+            --prom-listen-address 127.0.0.1:9091 \
+            --worker-prom-listen-address 127.0.0.1:9092 \
+            --prom-instance-addr 127.0.0.1:9090 \
+            --prom-instance-config \
+            --prom-export-worker-metrics $RUN_ID.parquet \
             --option internal-iterations=10 \
             --option continue-as-new-after-iterations=3 \
             --option sleep-time=1s \
             --option visibility-count-timeout=5m \
             --option min-throughput-per-hour=1000 \
             2>&1 | tee $WORKER_LOG_DIR/scenario.log
 
+      - name: Configure AWS credentials
+        if: always()
+        uses: aws-actions/configure-aws-credentials@v4
+        with:
+          role-to-assume: ${{ env.AWS_S3_METRICS_UPLOAD_ROLE_ARN }}
+          aws-region: us-west-2
+    
+      - name: Upload metrics to S3
+        if: always()
+        run: |
+          DATE=$(date +%Y-%m-%d)
+          IS_EXPERIMENT="false"
+          # Set as an experiment if we are not on the main branch or input as an experiment
+          if [[ "$GH_REF" != "refs/heads/main" || "$IS_EXPERIMENT_INPUT" == "true" ]]; then
+            IS_EXPERIMENT="true"
+          fi
+          echo "Uploading metrics: is_experiment=$IS_EXPERIMENT, language=$SDK_LANG, date=$DATE"
+          aws s3 cp omes/$RUN_ID.parquet \
+            "s3://cloud-data-ingest-prod/github/sdk_load_test/is_experiment=$IS_EXPERIMENT/language=$SDK_LANG/date=$DATE/$RUN_ID.parquet"
+
       - name: Upload logs on failure
         if: failure() || cancelled()
-        uses: actions/upload-artifact@v4
+        uses: actions/upload-artifact@v5
         with:
           name: throughput-stress-logs
           path: ${{ env.WORKER_LOG_DIR }}

.github/workflows/prepare-release.yml

@@ -148,7 +148,7 @@ jobs:
 
       # when no artifact is specified, all artifacts are downloaded and expanded into CWD
       - name: Fetch executables
-        uses: actions/download-artifact@v5
+        uses: actions/download-artifact@v6
 
       # example: linux_amd64/ -> temporal-test-server_1.2.3_linux_amd64
       # the name of the directory created becomes the basename of the archive (*.tar.gz or *.zip) and
@@ -165,7 +165,7 @@ jobs:
         run: for dir in *windows*; do zip -r "${dir}.zip" "$dir"; done
 
       - name: Upload release archives
-        uses: actions/upload-artifact@v4
+        uses: actions/upload-artifact@v5
         with:
           name: release-archives
           path: |

releases/v1.32.1

@@ -0,0 +1,15 @@
+# Bugfixes
+
+## Spring Boot
+
+Fixed a bug preventing using the in-memory test server for non-root namespaces.
+
+## Environment Config
+
+Fixed a bug causing an exception to be thrown if the default config file was not present.
+
+# What's Changed
+
+2025-11-26 - 0bfa9103 - fix(spring-boot): use in-memory test server for non-root namespaces (#2736)
+2025-11-28 - 6bb0fdf6 - Fix Javadoc for RateLimitsConfigurationProperties (#2729)
+2025-11-29 - b06f15d6 - Allow for FileNotFound. Do not error, instead return a default instance (#2739)

temporal-envconfig/src/main/java/io/temporal/envconfig/ClientConfig.java

@@ -5,11 +5,22 @@
 import com.fasterxml.jackson.dataformat.toml.TomlMapper;
 import io.temporal.common.Experimental;
 import java.io.*;
+import java.nio.file.Paths;
 import java.util.HashMap;
 import java.util.Map;
 import java.util.Objects;
 
-/** ClientConfig represents a client config file. */
+/**
+ * ClientConfig represents a client config file.
+ *
+ * <p>The default config file path is OS-specific:
+ *
+ * <ul>
+ *   <li>macOS: $HOME/Library/Application Support/temporalio/temporal.toml
+ *   <li>Windows: %APPDATA%\temporalio\temporal.toml
+ *   <li>Linux/other: $HOME/.config/temporalio/temporal.toml
+ * </ul>
+ */
 @Experimental
 public class ClientConfig {
   /** Creates a new builder to build a {@link ClientConfig}. */
@@ -32,13 +43,31 @@ public static ClientConfig getDefaultInstance() {
     return new ClientConfig.Builder().build();
   }
 
-  /** Get the default config file path: $HOME/.config/temporalio/temporal.toml */
   private static String getDefaultConfigFilePath() {
     String userDir = System.getProperty("user.home");
     if (userDir == null || userDir.isEmpty()) {
       throw new RuntimeException("failed getting user home directory");
     }
-    return userDir + "/.config/temporalio/temporal.toml";
+    return getDefaultConfigFilePath(userDir, System.getProperty("os.name"), System.getenv());
+  }
+
+  static String getDefaultConfigFilePath(
+      String userDir, String osName, Map<String, String> environment) {
+    if (osName != null) {
+      String osNameLower = osName.toLowerCase();
+      if (osNameLower.contains("mac")) {
+        return Paths.get(userDir, "Library", "Application Support", "temporalio", "temporal.toml")
+            .toString();
+      }
+      if (osNameLower.contains("win")) {
+        String appData = environment != null ? environment.get("APPDATA") : null;
+        if (appData == null || appData.isEmpty()) {
+          throw new RuntimeException("%APPDATA% is not defined");
+        }
+        return Paths.get(appData, "temporalio", "temporal.toml").toString();
+      }
+    }
+    return Paths.get(userDir, ".config", "temporalio", "temporal.toml").toString();
   }
 
   /**

temporal-envconfig/src/test/java/io/temporal/envconfig/ClientConfigProfileTest.java

@@ -7,6 +7,7 @@
 import io.grpc.netty.shaded.io.netty.handler.ssl.SslContext;
 import io.temporal.serviceclient.WorkflowServiceStubsOptions;
 import java.io.*;
+import java.nio.file.Paths;
 import java.util.Collections;
 import org.junit.Assert;
 import org.junit.Test;
@@ -302,6 +303,28 @@ public void loadClientConfigProfileMissingFileReturnsDefault() throws IOExceptio
     Assert.assertNull(profile.getNamespace());
   }
 
+  @Test
+  public void defaultConfigFilePath() {
+    // macOS: ~/Library/Application Support
+    Assert.assertEquals(
+        Paths.get("/Users/test", "Library", "Application Support", "temporalio", "temporal.toml")
+            .toString(),
+        ClientConfig.getDefaultConfigFilePath("/Users/test", "Mac OS X", Collections.emptyMap()));
+
+    // Windows: %APPDATA%
+    Assert.assertEquals(
+        Paths.get("C:/Users/test/AppData/Roaming", "temporalio", "temporal.toml").toString(),
+        ClientConfig.getDefaultConfigFilePath(
+            "C:/Users/test",
+            "Windows 10",
+            Collections.singletonMap("APPDATA", "C:/Users/test/AppData/Roaming")));
+
+    // Linux: ~/.config
+    Assert.assertEquals(
+        Paths.get("/home/test", ".config", "temporalio", "temporal.toml").toString(),
+        ClientConfig.getDefaultConfigFilePath("/home/test", "Linux", Collections.emptyMap()));
+  }
+
   @Test
   public void parseToml() throws IOException {
     String toml =

temporal-sdk/src/main/java/io/temporal/internal/replay/ReplayWorkflowExecutor.java

@@ -3,7 +3,6 @@
 import com.google.common.annotations.VisibleForTesting;
 import com.google.protobuf.InvalidProtocolBufferException;
 import com.google.protobuf.util.Timestamps;
-import com.uber.m3.tally.Scope;
 import io.temporal.api.command.v1.ContinueAsNewWorkflowExecutionCommandAttributes;
 import io.temporal.api.common.v1.Payloads;
 import io.temporal.api.history.v1.HistoryEvent;
@@ -14,14 +13,12 @@
 import io.temporal.api.update.v1.Input;
 import io.temporal.api.update.v1.Request;
 import io.temporal.failure.CanceledFailure;
-import io.temporal.internal.common.FailureUtils;
 import io.temporal.internal.common.ProtobufTimeUtils;
 import io.temporal.internal.common.UpdateMessage;
 import io.temporal.internal.statemachines.WorkflowStateMachines;
 import io.temporal.internal.sync.SignalHandlerInfo;
 import io.temporal.internal.sync.UpdateHandlerInfo;
 import io.temporal.internal.worker.WorkflowExecutionException;
-import io.temporal.worker.MetricsType;
 import io.temporal.worker.NonDeterministicException;
 import io.temporal.workflow.HandlerUnfinishedPolicy;
 import java.util.List;
@@ -63,16 +60,13 @@ final class ReplayWorkflowExecutor {
 
   private final ReplayWorkflowContextImpl context;
 
-  private final Scope metricsScope;
-
   public ReplayWorkflowExecutor(
       ReplayWorkflow workflow,
       WorkflowStateMachines workflowStateMachines,
       ReplayWorkflowContextImpl context) {
     this.workflow = workflow;
     this.workflowStateMachines = workflowStateMachines;
     this.context = context;
-    this.metricsScope = context.getMetricsScope();
   }
 
   public void eventLoop() {
@@ -131,12 +125,8 @@ private void completeWorkflow(@Nullable WorkflowExecutionException failure) {
 
     if (context.isCancelRequested()) {
       workflowStateMachines.cancelWorkflow();
-      metricsScope.counter(MetricsType.WORKFLOW_CANCELED_COUNTER).inc(1);
     } else if (failure != null) {
       workflowStateMachines.failWorkflow(failure.getFailure());
-      if (!FailureUtils.isBenignApplicationFailure(failure.getFailure())) {
-        metricsScope.counter(MetricsType.WORKFLOW_FAILED_COUNTER).inc(1);
-      }
     } else {
       ContinueAsNewWorkflowExecutionCommandAttributes attributes =
           context.getContinueAsNewOnCompletion();
@@ -152,23 +142,17 @@ private void completeWorkflow(@Nullable WorkflowExecutionException failure) {
         //  This way attributes will need to be carried over in the mutable state and the flow
         //  generally will be aligned with the flow of other commands.
         workflowStateMachines.continueAsNewWorkflow(attributes);
-
-        // TODO Issue #1590
-        metricsScope.counter(MetricsType.WORKFLOW_CONTINUE_AS_NEW_COUNTER).inc(1);
       } else {
         Optional<Payloads> workflowOutput = workflow.getOutput();
         workflowStateMachines.completeWorkflow(workflowOutput);
-
-        // TODO Issue #1590
-        metricsScope.counter(MetricsType.WORKFLOW_COMPLETED_COUNTER).inc(1);
       }
     }
 
     com.uber.m3.util.Duration d =
         ProtobufTimeUtils.toM3Duration(
             Timestamps.fromMillis(System.currentTimeMillis()),
             Timestamps.fromMillis(context.getRunStartedTimestampMillis()));
-    metricsScope.timer(MetricsType.WORKFLOW_E2E_LATENCY).record(d);
+    workflowStateMachines.setPostCompletionEndToEndLatency(d);
   }
 
   public void handleWorkflowExecutionCancelRequested(HistoryEvent event) {

temporal-sdk/src/main/java/io/temporal/internal/replay/ReplayWorkflowRunTaskHandler.java

@@ -185,6 +185,21 @@ public WorkflowTaskResult handleWorkflowTask(
       if (workflow.getWorkflowContext() != null) {
         result.setVersioningBehavior(workflow.getWorkflowContext().getVersioningBehavior());
       }
+      // Setup post-completion metrics to be applied after task response accepted
+      String postCompleteCounter = workflowStateMachines.getPostCompletionMetricCounter();
+      com.uber.m3.util.Duration postCompleteLatency =
+          workflowStateMachines.getPostCompletionEndToEndLatency();
+      if (postCompleteCounter != null || postCompleteLatency != null) {
+        result.setApplyPostCompletionMetrics(
+            () -> {
+              if (postCompleteCounter != null) {
+                metricsScope.counter(postCompleteCounter).inc(1);
+              }
+              if (postCompleteLatency != null) {
+                metricsScope.timer(MetricsType.WORKFLOW_E2E_LATENCY).record(postCompleteLatency);
+              }
+            });
+      }
       return result.build();
     } finally {
       lock.unlock();

temporal-sdk/src/main/java/io/temporal/internal/replay/ReplayWorkflowTaskHandler.java

@@ -252,7 +252,8 @@ private Result createCompletedWFTRequest(
         null,
         null,
         result.isFinalCommand(),
-        eventIdSetHandle);
+        eventIdSetHandle,
+        result.getApplyPostCompletionMetrics());
   }
 
   private Result failureToWFTResult(
@@ -275,7 +276,8 @@ private Result failureToWFTResult(
                               .setFailure(((WorkflowExecutionException) e).getFailure()))
                       .build())
               .build();
-      return new WorkflowTaskHandler.Result(workflowType, response, null, null, null, false, null);
+      return new WorkflowTaskHandler.Result(
+          workflowType, response, null, null, null, false, null, null);
     }
 
     WorkflowExecution execution = workflowTask.getWorkflowExecution();
@@ -316,7 +318,7 @@ private Result failureToWFTResult(
           WorkflowTaskFailedCause.WORKFLOW_TASK_FAILED_CAUSE_WORKFLOW_WORKER_UNHANDLED_FAILURE);
     }
     return new WorkflowTaskHandler.Result(
-        workflowType, null, failedRequest.build(), null, null, false, null);
+        workflowType, null, failedRequest.build(), null, null, false, null, null);
   }
 
   private Result createDirectQueryResult(
@@ -346,6 +348,7 @@ private Result createDirectQueryResult(
         queryCompletedRequest.build(),
         null,
         false,
+        null,
         null);
   }