Skip to content

Commit cfa9427

Browse files
GregoryTravisGregoryTravis
committed
useless test comments
1 parent f9f7dc9 commit cfa9427

1 file changed

Lines changed: 1 addition & 126 deletions

File tree

‎temporal-sdk/src/test/java/io/temporal/client/functional/StandaloneActivityTest.java‎

Lines changed: 1 addition & 126 deletions
Original file line numberDiff line numberDiff line change
@@ -30,8 +30,7 @@
3030
import org.junit.Test;
3131

3232
/**
33-
* Integration tests for standalone activities started via {@link ActivityClient}. These tests are a
34-
* parallel to the .NET SDK's {@code TemporalClientActivityTests}.
33+
* Integration tests for standalone activities started via {@link ActivityClient}.
3534
*
3635
* <p>All tests are gated behind {@link SDKTestWorkflowRule#useExternalService} because the embedded
3736
* test server may not support the standalone activity APIs.
@@ -199,11 +198,6 @@ private ActivityClient newActivityClient() {
199198
ActivityClientOptions.newBuilder().setNamespace(SDKTestWorkflowRule.NAMESPACE).build());
200199
}
201200

202-
// ---------------------------------------------------------------------------
203-
// Test 1: execute simple activity by interface + method ref — typed result
204-
// (.NET: ExecuteActivityAsync_SimpleWithResult_Succeeds)
205-
// ---------------------------------------------------------------------------
206-
207201
@Test
208202
public void testExecuteActivitySimpleWithResult() {
209203
assumeTrue(SDKTestWorkflowRule.useExternalService);
@@ -214,22 +208,12 @@ public void testExecuteActivitySimpleWithResult() {
214208
assertEquals("echo:hello", result);
215209
}
216210

217-
// ---------------------------------------------------------------------------
218-
// Test 2: execute void activity by interface + method ref
219-
// (.NET: ExecuteActivityAsync_VoidResult_Succeeds)
220-
// ---------------------------------------------------------------------------
221-
222211
@Test
223212
public void testExecuteActivityVoidResult() {
224213
assumeTrue(SDKTestWorkflowRule.useExternalService);
225214
newActivityClient().execute(VoidActivity.class, VoidActivity::execute, simpleOpts(uniqueId()));
226215
}
227216

228-
// ---------------------------------------------------------------------------
229-
// Test 3: execute activity by string type name
230-
// (.NET: ExecuteActivityAsync_ByName_Succeeds)
231-
// ---------------------------------------------------------------------------
232-
233217
@Test
234218
public void testExecuteActivityByName() {
235219
assumeTrue(SDKTestWorkflowRule.useExternalService);
@@ -239,11 +223,6 @@ public void testExecuteActivityByName() {
239223
assertEquals("echo:world", result);
240224
}
241225

242-
// ---------------------------------------------------------------------------
243-
// Test 4: starting an already-running activity with conflict policy Fail throws
244-
// (.NET: StartActivityAsync_AlreadyStarted_Throws)
245-
// ---------------------------------------------------------------------------
246-
247226
@Test
248227
public void testStartActivityAlreadyStartedThrows() {
249228
assumeTrue(SDKTestWorkflowRule.useExternalService);
@@ -277,11 +256,6 @@ public void testStartActivityAlreadyStartedThrows() {
277256
}
278257
}
279258

280-
// ---------------------------------------------------------------------------
281-
// Test 5: reject-duplicate ID reuse policy throws on re-start after completion
282-
// (.NET: StartActivityAsync_IdReusePolicyRejectDuplicate_Throws)
283-
// ---------------------------------------------------------------------------
284-
285259
@Test
286260
public void testStartActivityIdReusePolicyRejectDuplicateThrows() {
287261
assumeTrue(SDKTestWorkflowRule.useExternalService);
@@ -306,11 +280,6 @@ public void testStartActivityIdReusePolicyRejectDuplicateThrows() {
306280
assertEquals(activityId, err.getActivityId());
307281
}
308282

309-
// ---------------------------------------------------------------------------
310-
// Test 6: get handle for a completed activity and read its result
311-
// (.NET: GetActivityHandle_ExistingActivity_Succeeds)
312-
// ---------------------------------------------------------------------------
313-
314283
@Test
315284
public void testGetActivityHandleExistingActivitySucceeds() {
316285
assumeTrue(SDKTestWorkflowRule.useExternalService);
@@ -327,11 +296,6 @@ public void testGetActivityHandleExistingActivitySucceeds() {
327296
assertEquals("echo:test", handle2.getResult(String.class));
328297
}
329298

330-
// ---------------------------------------------------------------------------
331-
// Test 7: describe while running and after termination
332-
// (.NET: DescribeAsync_RunningAndTerminated_IsAccurate)
333-
// ---------------------------------------------------------------------------
334-
335299
@Test
336300
public void testDescribeRunningAndTerminatedIsAccurate() {
337301
assumeTrue(SDKTestWorkflowRule.useExternalService);
@@ -382,11 +346,6 @@ public void testDescribeRunningAndTerminatedIsAccurate() {
382346
}
383347
}
384348

385-
// ---------------------------------------------------------------------------
386-
// Test 8: user metadata (staticSummary / staticDetails) is preserved in describe
387-
// (.NET: DescribeAsync_UserMetadata_IsAccurate)
388-
// ---------------------------------------------------------------------------
389-
390349
@Test
391350
public void testDescribeUserMetadataIsAccurate() {
392351
assumeTrue(SDKTestWorkflowRule.useExternalService);
@@ -409,11 +368,6 @@ public void testDescribeUserMetadataIsAccurate() {
409368
assertEquals("Test details\nLine 2", desc.getStaticDetails());
410369
}
411370

412-
// ---------------------------------------------------------------------------
413-
// Test 9: cancel a running activity; getResult throws ActivityFailedException(CanceledFailure)
414-
// (.NET: CancelAsync_RunningActivity_Succeeds)
415-
// ---------------------------------------------------------------------------
416-
417371
@Test
418372
public void testCancelRunningActivitySucceeds() throws InterruptedException {
419373
assumeTrue(SDKTestWorkflowRule.useExternalService);
@@ -450,11 +404,6 @@ public void testCancelRunningActivitySucceeds() throws InterruptedException {
450404
}
451405
}
452406

453-
// ---------------------------------------------------------------------------
454-
// Test 10: list, count, and paginate activities
455-
// (.NET: ListActivitiesAsync_SimpleList_IsAccurate)
456-
// ---------------------------------------------------------------------------
457-
458407
@Test
459408
public void testListActivitiesSimpleListIsAccurate() {
460409
assumeTrue(SDKTestWorkflowRule.useExternalService);
@@ -516,11 +465,6 @@ public void testListActivitiesSimpleListIsAccurate() {
516465
});
517466
}
518467

519-
// ---------------------------------------------------------------------------
520-
// Test 11: interceptors are invoked for all activity operations
521-
// (.NET: StartActivityAsync_Interceptors_AreCalledProperly)
522-
// ---------------------------------------------------------------------------
523-
524468
@Test
525469
public void testStartActivityInterceptorsAreCalledProperly() throws InterruptedException {
526470
assumeTrue(SDKTestWorkflowRule.useExternalService);
@@ -572,11 +516,6 @@ public void testStartActivityInterceptorsAreCalledProperly() throws InterruptedE
572516
}
573517
}
574518

575-
// ---------------------------------------------------------------------------
576-
// Test 12: ActivityInfo inside the activity body reflects standalone context
577-
// (.NET: ExecuteActivityAsync_WorkerActivityInfo_IsAccurate)
578-
// ---------------------------------------------------------------------------
579-
580519
@Test
581520
public void testExecuteActivityWorkerActivityInfoIsAccurate() {
582521
assumeTrue(SDKTestWorkflowRule.useExternalService);
@@ -599,10 +538,6 @@ public void testExecuteActivityWorkerActivityInfoIsAccurate() {
599538
assertNull(info.workflowType);
600539
}
601540

602-
// ---------------------------------------------------------------------------
603-
// Test 13: executeAsync via interface + method ref
604-
// ---------------------------------------------------------------------------
605-
606541
@Test
607542
public void testExecuteAsyncReturnsResult() throws Exception {
608543
assumeTrue(SDKTestWorkflowRule.useExternalService);
@@ -613,10 +548,6 @@ public void testExecuteAsyncReturnsResult() throws Exception {
613548
assertEquals("echo:hello", future.get());
614549
}
615550

616-
// ---------------------------------------------------------------------------
617-
// Test 14: getResultAsync on an UntypedActivityHandle returns a resolved future
618-
// ---------------------------------------------------------------------------
619-
620551
@Test
621552
public void testGetResultAsyncOnHandle() throws Exception {
622553
assumeTrue(SDKTestWorkflowRule.useExternalService);
@@ -626,10 +557,6 @@ public void testGetResultAsyncOnHandle() throws Exception {
626557
assertEquals("echo:world", future.get());
627558
}
628559

629-
// ---------------------------------------------------------------------------
630-
// Test 15: typed ActivityHandle<R>.getResult() no-arg path via fromUntyped
631-
// ---------------------------------------------------------------------------
632-
633560
@Test
634561
public void testTypedHandleGetResultNoArg() throws ActivityFailedException {
635562
assumeTrue(SDKTestWorkflowRule.useExternalService);
@@ -639,10 +566,6 @@ public void testTypedHandleGetResultNoArg() throws ActivityFailedException {
639566
assertEquals("echo:typed", typed.getResult());
640567
}
641568

642-
// ---------------------------------------------------------------------------
643-
// Test 16: client.getHandle(id, runId, Class<R>) returns a typed ActivityHandle<R>
644-
// ---------------------------------------------------------------------------
645-
646569
@Test
647570
public void testGetHandleTypedReturnsActivityHandleR() throws ActivityFailedException {
648571
assumeTrue(SDKTestWorkflowRule.useExternalService);
@@ -658,42 +581,26 @@ public void testGetHandleTypedReturnsActivityHandleR() throws ActivityFailedExce
658581
assertEquals("echo:typed", typed.getResult());
659582
}
660583

661-
// ---------------------------------------------------------------------------
662-
// Test 17: Proc1 (void, 0 args) — execute
663-
// ---------------------------------------------------------------------------
664-
665584
@Test
666585
public void testExecuteVoidActivity() {
667586
assumeTrue(SDKTestWorkflowRule.useExternalService);
668587
newActivityClient().execute(VoidActivity.class, VoidActivity::execute, simpleOpts(uniqueId()));
669588
}
670589

671-
// ---------------------------------------------------------------------------
672-
// Test 18: Proc2 (void, 1 arg) — execute
673-
// ---------------------------------------------------------------------------
674-
675590
@Test
676591
public void testExecuteVoidActivity1Arg() {
677592
assumeTrue(SDKTestWorkflowRule.useExternalService);
678593
newActivityClient()
679594
.execute(EchoVoidActivity.class, EchoVoidActivity::echo1, simpleOpts(uniqueId()), "hello");
680595
}
681596

682-
// ---------------------------------------------------------------------------
683-
// Test 19: Proc3 (void, 2 args) — execute
684-
// ---------------------------------------------------------------------------
685-
686597
@Test
687598
public void testExecuteVoidActivity2Args() {
688599
assumeTrue(SDKTestWorkflowRule.useExternalService);
689600
newActivityClient()
690601
.execute(EchoVoidActivity.class, EchoVoidActivity::echo2, simpleOpts(uniqueId()), "a", "b");
691602
}
692603

693-
// ---------------------------------------------------------------------------
694-
// Test 20: Func1 (returning, 0 args) — execute
695-
// ---------------------------------------------------------------------------
696-
697604
@Test
698605
public void testExecuteReturningActivity0Args() {
699606
assumeTrue(SDKTestWorkflowRule.useExternalService);
@@ -708,10 +615,6 @@ public void testExecuteReturningActivity0Args() {
708615
assertFalse(info.isWorkflowActivity);
709616
}
710617

711-
// ---------------------------------------------------------------------------
712-
// Test 21: Func2 (returning, 1 arg) — execute
713-
// ---------------------------------------------------------------------------
714-
715618
@Test
716619
public void testExecuteReturningActivity1Arg() {
717620
assumeTrue(SDKTestWorkflowRule.useExternalService);
@@ -722,10 +625,6 @@ public void testExecuteReturningActivity1Arg() {
722625
assertEquals("echo:hello", result);
723626
}
724627

725-
// ---------------------------------------------------------------------------
726-
// Test 22: Func3 (returning, 2 args) — execute
727-
// ---------------------------------------------------------------------------
728-
729628
@Test
730629
public void testExecuteReturningActivity2Args() {
731630
assumeTrue(SDKTestWorkflowRule.useExternalService);
@@ -736,10 +635,6 @@ public void testExecuteReturningActivity2Args() {
736635
assertEquals("foo+bar", result);
737636
}
738637

739-
// ---------------------------------------------------------------------------
740-
// Test 23: Proc1 — start returns ActivityHandle<Void>
741-
// ---------------------------------------------------------------------------
742-
743638
@Test
744639
public void testStartVoidActivity0Args() {
745640
assumeTrue(SDKTestWorkflowRule.useExternalService);
@@ -749,10 +644,6 @@ public void testStartVoidActivity0Args() {
749644
handle.getResult();
750645
}
751646

752-
// ---------------------------------------------------------------------------
753-
// Test 24: Proc2 — start with 1 arg returns ActivityHandle<Void>
754-
// ---------------------------------------------------------------------------
755-
756647
@Test
757648
public void testStartVoidActivity1Arg() {
758649
assumeTrue(SDKTestWorkflowRule.useExternalService);
@@ -763,10 +654,6 @@ public void testStartVoidActivity1Arg() {
763654
handle.getResult();
764655
}
765656

766-
// ---------------------------------------------------------------------------
767-
// Test 25: Func1 — start with 0 args returns ActivityHandle<R>
768-
// ---------------------------------------------------------------------------
769-
770657
@Test
771658
public void testStartReturningActivity0Args() {
772659
assumeTrue(SDKTestWorkflowRule.useExternalService);
@@ -782,10 +669,6 @@ public void testStartReturningActivity0Args() {
782669
assertFalse(info.isWorkflowActivity);
783670
}
784671

785-
// ---------------------------------------------------------------------------
786-
// Test 26: Func2 — start with 1 arg returns ActivityHandle<R>
787-
// ---------------------------------------------------------------------------
788-
789672
@Test
790673
public void testStartReturningActivity1Arg() {
791674
assumeTrue(SDKTestWorkflowRule.useExternalService);
@@ -795,10 +678,6 @@ public void testStartReturningActivity1Arg() {
795678
assertEquals("echo:hello", handle.getResult());
796679
}
797680

798-
// ---------------------------------------------------------------------------
799-
// Test 27: Func3 — start with 2 args returns ActivityHandle<R>
800-
// ---------------------------------------------------------------------------
801-
802681
@Test
803682
public void testStartReturningActivity2Args() {
804683
assumeTrue(SDKTestWorkflowRule.useExternalService);
@@ -809,10 +688,6 @@ public void testStartReturningActivity2Args() {
809688
assertEquals("foo+bar", handle.getResult());
810689
}
811690

812-
// ---------------------------------------------------------------------------
813-
// Test 28: executeAsync via interface + method ref
814-
// ---------------------------------------------------------------------------
815-
816691
@Test
817692
public void testExecuteAsyncWithMethodRef() throws Exception {
818693
assumeTrue(SDKTestWorkflowRule.useExternalService);

0 commit comments

Comments
 (0)