Skip to content

Commit d47fc5e

Browse files
committed
Rename isWorkflowActivity to isInWorkflow
1 parent 632a23d commit d47fc5e

3 files changed

Lines changed: 9 additions & 9 deletions

File tree

temporal-sdk/src/main/java/io/temporal/activity/ActivityInfo.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -144,7 +144,7 @@ public interface ActivityInfo {
144144
* @return {@code true} if this activity was scheduled by a workflow execution; {@code false} for
145145
* standalone activities.
146146
*/
147-
default boolean isWorkflowActivity() {
147+
default boolean isInWorkflow() {
148148
return getWorkflowId() != null;
149149
}
150150

temporal-sdk/src/test/java/io/temporal/client/functional/StandaloneActivityTest.java

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -103,7 +103,7 @@ public static class ActivityInfoSnapshot {
103103
public String namespace;
104104
public String taskQueue;
105105
public boolean isLocal;
106-
public boolean isWorkflowActivity;
106+
public boolean isInWorkflow;
107107
public String workflowId;
108108
public String workflowRunId;
109109
public String workflowType;
@@ -170,7 +170,7 @@ public ActivityInfoSnapshot inspectInfo() {
170170
snapshot.namespace = info.getNamespace();
171171
snapshot.taskQueue = info.getActivityTaskQueue();
172172
snapshot.isLocal = info.isLocal();
173-
snapshot.isWorkflowActivity = info.isWorkflowActivity();
173+
snapshot.isInWorkflow = info.isInWorkflow();
174174
snapshot.workflowId = info.getWorkflowId();
175175
snapshot.workflowRunId = info.getWorkflowRunId();
176176
snapshot.workflowType = info.getWorkflowType();
@@ -553,7 +553,7 @@ public void testExecuteActivityWorkerActivityInfoIsAccurate() {
553553
assertEquals(SDKTestWorkflowRule.NAMESPACE, info.namespace);
554554
assertEquals(testWorkflowRule.getTaskQueue(), info.taskQueue);
555555
assertFalse(info.isLocal);
556-
assertFalse(info.isWorkflowActivity);
556+
assertFalse(info.isInWorkflow);
557557
assertNull(info.workflowId);
558558
assertNull(info.workflowRunId);
559559
assertNull(info.workflowType);
@@ -633,7 +633,7 @@ public void testExecuteReturningActivity0Args() {
633633
InspectInfoActivity::inspectInfo,
634634
simpleOpts(activityId));
635635
assertEquals(activityId, info.activityId);
636-
assertFalse(info.isWorkflowActivity);
636+
assertFalse(info.isInWorkflow);
637637
}
638638

639639
@Test
@@ -687,7 +687,7 @@ public void testStartReturningActivity0Args() {
687687
simpleOpts(activityId));
688688
ActivityInfoSnapshot info = handle.getResult();
689689
assertEquals(activityId, info.activityId);
690-
assertFalse(info.isWorkflowActivity);
690+
assertFalse(info.isInWorkflow);
691691
}
692692

693693
@Test

temporal-sdk/src/test/java/io/temporal/internal/activity/ActivityInfoStandaloneTest.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,7 @@ public void testWorkflowActivityReturnsWorkflowInfo() {
3939
assertEquals("wf-id", info.getWorkflowId());
4040
assertEquals("run-id", info.getWorkflowRunId());
4141
assertEquals("MyWorkflow", info.getWorkflowType());
42-
assertTrue(info.isWorkflowActivity());
42+
assertTrue(info.isInWorkflow());
4343
}
4444

4545
@Test
@@ -51,7 +51,7 @@ public void testStandaloneActivityReturnsNullWorkflowInfo() {
5151
assertNull(info.getWorkflowId());
5252
assertNull(info.getWorkflowRunId());
5353
assertNull(info.getWorkflowType());
54-
assertFalse(info.isWorkflowActivity());
54+
assertFalse(info.isInWorkflow());
5555
}
5656

5757
@Test
@@ -65,7 +65,7 @@ public void testEmptyWorkflowIdTreatedAsStandalone() {
6565
ActivityInfoImpl info = new ActivityInfoImpl(response, NAMESPACE, "task-queue", false, null);
6666
assertNull(info.getWorkflowId());
6767
assertNull(info.getWorkflowRunId());
68-
assertFalse(info.isWorkflowActivity());
68+
assertFalse(info.isInWorkflow());
6969
}
7070

7171
@Test

0 commit comments

Comments
 (0)