Skip to content

Commit e10dbd6

Browse files
committed
Added tests testGetHandleWithNullRunId and testVoidExecuteOverloadDiscardsNonVoidResult.
Renames: ActivityInfoStandaloneTest -> ActivityInfoImplTest, testDescribeNoToken -> testDescribe in ActivityHandleImplTest.
1 parent 9429e47 commit e10dbd6

3 files changed

Lines changed: 21 additions & 2 deletions

File tree

temporal-sdk/src/test/java/io/temporal/client/functional/StandaloneActivityTest.java

Lines changed: 19 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -602,6 +602,25 @@ public void testGetHandleTypedReturnsActivityHandleTyped() throws ActivityFailed
602602
assertEquals("echo:typed", typed.getResult());
603603
}
604604

605+
@Test
606+
public void testGetHandleWithNullRunId() throws ActivityFailedException {
607+
assumeTrue(SDKTestWorkflowRule.useExternalService);
608+
ActivityClient client = newActivityClient();
609+
String activityId = uniqueId();
610+
client.start(SimpleActivity.class, SimpleActivity::execute, simpleOpts(activityId), "nullrun");
611+
612+
ActivityHandle<String> handle = client.getHandle(activityId, null, String.class);
613+
assertEquals("echo:nullrun", handle.getResult());
614+
}
615+
616+
@Test
617+
public void testVoidExecuteOverloadDiscardsNonVoidResult() {
618+
assumeTrue(SDKTestWorkflowRule.useExternalService);
619+
// SimpleActivity.execute returns a non-void String; the void string-based overload must
620+
// complete successfully and silently discard the return value.
621+
newActivityClient().execute("SimpleActivity", simpleOpts(uniqueId()), "discard");
622+
}
623+
605624
@Test
606625
public void testExecuteVoidActivity() {
607626
assumeTrue(SDKTestWorkflowRule.useExternalService);

temporal-sdk/src/test/java/io/temporal/internal/activity/ActivityInfoStandaloneTest.java renamed to temporal-sdk/src/test/java/io/temporal/internal/activity/ActivityInfoImplTest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@
1111
import org.junit.Test;
1212

1313
/** Verifies that {@link ActivityInfoImpl} correctly handles standalone vs workflow-hosted tasks. */
14-
public class ActivityInfoStandaloneTest {
14+
public class ActivityInfoImplTest {
1515

1616
private static final String NAMESPACE = "test-ns";
1717

temporal-sdk/src/test/java/io/temporal/internal/client/ActivityHandleImplTest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,7 @@ public void testGetResultAsync() throws Exception {
5252
}
5353

5454
@Test
55-
public void testDescribeNoToken() {
55+
public void testDescribe() {
5656
ActivityExecutionDescription desc = mock(ActivityExecutionDescription.class);
5757
DescribeActivityOutput output = new DescribeActivityOutput(desc);
5858
when(interceptor.describeActivity(any(DescribeActivityInput.class))).thenReturn(output);

0 commit comments

Comments
 (0)