temporal-spring-ai: disable workflow caching in side-effect replay tests

Configure TestWorkflowEnvironment with WorkflowCacheSize(0) so the
worker replays from history on every workflow task instead of
resuming from in-memory cached state. That is the regime in which
side-effect safety actually has to hold: a missing Workflow.sideEffect
wrap or an un-guarded in-workflow mutation would run on each replay,
which cached resumes mask.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

Author: donald-pinckney

temporal-spring-ai/src/test/java/io/temporal/springai/replay/ActivityToolSideEffectTest.java

@@ -12,9 +12,11 @@
 import io.temporal.springai.activity.ChatModelActivityImpl;
 import io.temporal.springai.chat.TemporalChatClient;
 import io.temporal.springai.model.ActivityChatModel;
+import io.temporal.testing.TestEnvironmentOptions;
 import io.temporal.testing.TestWorkflowEnvironment;
 import io.temporal.testing.WorkflowReplayer;
 import io.temporal.worker.Worker;
+import io.temporal.worker.WorkerFactoryOptions;
 import io.temporal.workflow.Workflow;
 import io.temporal.workflow.WorkflowInterface;
 import io.temporal.workflow.WorkflowMethod;
@@ -48,7 +50,15 @@ class ActivityToolSideEffectTest {
 
   @BeforeEach
   void setUp() {
-    testEnv = TestWorkflowEnvironment.newInstance();
+    // WorkflowCacheSize(0) forces the worker to replay from history on every workflow task
+    // instead of resuming from in-memory cached state — the regime in which a missing
+    // Workflow.sideEffect wrap or an un-guarded in-workflow mutation would actually bite.
+    testEnv =
+        TestWorkflowEnvironment.newInstance(
+            TestEnvironmentOptions.newBuilder()
+                .setWorkerFactoryOptions(
+                    WorkerFactoryOptions.newBuilder().setWorkflowCacheSize(0).build())
+                .build());
     client = testEnv.getWorkflowClient();
     addActivity = new AddActivityImpl();
   }

temporal-spring-ai/src/test/java/io/temporal/springai/replay/ChatModelSideEffectTest.java

@@ -8,9 +8,11 @@
 import io.temporal.common.WorkflowExecutionHistory;
 import io.temporal.springai.activity.ChatModelActivityImpl;
 import io.temporal.springai.model.ActivityChatModel;
+import io.temporal.testing.TestEnvironmentOptions;
 import io.temporal.testing.TestWorkflowEnvironment;
 import io.temporal.testing.WorkflowReplayer;
 import io.temporal.worker.Worker;
+import io.temporal.worker.WorkerFactoryOptions;
 import io.temporal.workflow.WorkflowInterface;
 import io.temporal.workflow.WorkflowMethod;
 import java.util.List;
@@ -43,7 +45,16 @@ class ChatModelSideEffectTest {
 
   @BeforeEach
   void setUp() {
-    testEnv = TestWorkflowEnvironment.newInstance();
+    // WorkflowCacheSize(0) forces the worker to replay from history on every workflow task
+    // instead of resuming from in-memory cached state, which is what we actually need to
+    // assert side-effect safety: any un-wrapped side effect in workflow code would run on
+    // each replay and bump the counter.
+    testEnv =
+        TestWorkflowEnvironment.newInstance(
+            TestEnvironmentOptions.newBuilder()
+                .setWorkerFactoryOptions(
+                    WorkerFactoryOptions.newBuilder().setWorkflowCacheSize(0).build())
+                .build());
     client = testEnv.getWorkflowClient();
     model = new CountingChatModel("pong");
   }

temporal-spring-ai/src/test/java/io/temporal/springai/replay/SideEffectToolReplayTest.java

@@ -10,9 +10,11 @@
 import io.temporal.springai.chat.TemporalChatClient;
 import io.temporal.springai.model.ActivityChatModel;
 import io.temporal.springai.tool.SideEffectTool;
+import io.temporal.testing.TestEnvironmentOptions;
 import io.temporal.testing.TestWorkflowEnvironment;
 import io.temporal.testing.WorkflowReplayer;
 import io.temporal.worker.Worker;
+import io.temporal.worker.WorkerFactoryOptions;
 import io.temporal.workflow.WorkflowInterface;
 import io.temporal.workflow.WorkflowMethod;
 import java.util.List;
@@ -51,7 +53,15 @@ class SideEffectToolReplayTest {
   @BeforeEach
   void setUp() {
     CALL_COUNT.set(0);
-    testEnv = TestWorkflowEnvironment.newInstance();
+    // WorkflowCacheSize(0) forces the worker to replay from history on every workflow task.
+    // This is exactly the regime a missing Workflow.sideEffect wrap would fail in: every
+    // tick the @Tool body would run again and bump the counter past 1.
+    testEnv =
+        TestWorkflowEnvironment.newInstance(
+            TestEnvironmentOptions.newBuilder()
+                .setWorkerFactoryOptions(
+                    WorkerFactoryOptions.newBuilder().setWorkflowCacheSize(0).build())
+                .build());
     client = testEnv.getWorkflowClient();
   }