Non-mocked completion client tests.

Author: GregoryTravis

temporal-sdk/src/test/java/io/temporal/client/functional/StandaloneActivityTest.java

@@ -65,6 +65,12 @@ public interface InspectInfoActivity {
     ActivityInfoSnapshot inspectInfo();
   }
 
+  @ActivityInterface
+  public interface AsyncCompletionActivity {
+    @ActivityMethod(name = "AsyncCompletion")
+    String complete();
+  }
+
   @ActivityInterface
   public interface EchoVoidActivity {
     @ActivityMethod(name = "Echo1")
@@ -110,6 +116,10 @@ public void execute() {}
    */
   private static volatile CountDownLatch cancelLatch;
 
+  private static volatile CountDownLatch asyncStartLatch;
+  private static volatile String asyncActivityId;
+  private static volatile String asyncActivityRunId;
+
   public static class WaitForCancelActivityImpl implements WaitForCancelActivity {
     @Override
     public void waitForCancel() {
@@ -127,6 +137,19 @@ public void waitForCancel() {
     }
   }
 
+  public static class AsyncCompletionActivityImpl implements AsyncCompletionActivity {
+    @Override
+    public String complete() {
+      ActivityInfo info = Activity.getExecutionContext().getInfo();
+      asyncActivityId = info.getActivityId();
+      asyncActivityRunId = info.getActivityRunId();
+      Activity.getExecutionContext().doNotCompleteOnReturn();
+      CountDownLatch latch = asyncStartLatch;
+      if (latch != null) latch.countDown();
+      return null;
+    }
+  }
+
   public static class InspectInfoActivityImpl implements InspectInfoActivity {
     @Override
     public ActivityInfoSnapshot inspectInfo() {
@@ -171,6 +194,7 @@ public String concat(String a, String b) {
               new SimpleActivityImpl(),
               new VoidActivityImpl(),
               new WaitForCancelActivityImpl(),
+              new AsyncCompletionActivityImpl(),
               new InspectInfoActivityImpl(),
               new EchoVoidActivityImpl(),
               new ConcatActivityImpl())
@@ -698,6 +722,58 @@ public void testExecuteAsyncWithMethodRef() throws Exception {
     assertEquals("echo:async", fut.get());
   }
 
+  @Test
+  public void testCompletionClientStandaloneCompleteByActivityId() throws InterruptedException {
+    assumeTrue(SDKTestWorkflowRule.useExternalService);
+    asyncStartLatch = new CountDownLatch(1);
+    try {
+      ActivityClient client = newActivityClient();
+      ActivityHandle<String> handle =
+          client.start(
+              AsyncCompletionActivity.class,
+              AsyncCompletionActivity::complete,
+              simpleOpts(uniqueId()));
+
+      assertTrue("Activity did not start within 30s", asyncStartLatch.await(30, TimeUnit.SECONDS));
+
+      client
+          .newActivityCompletionClient()
+          .complete(asyncActivityId, Optional.empty(), "ext-result");
+
+      assertEquals("ext-result", handle.getResult());
+    } finally {
+      asyncStartLatch = null;
+      asyncActivityId = null;
+      asyncActivityRunId = null;
+    }
+  }
+
+  @Test
+  public void testCompletionClientStandaloneCompleteWithRunId() throws InterruptedException {
+    assumeTrue(SDKTestWorkflowRule.useExternalService);
+    asyncStartLatch = new CountDownLatch(1);
+    try {
+      ActivityClient client = newActivityClient();
+      ActivityHandle<String> handle =
+          client.start(
+              AsyncCompletionActivity.class,
+              AsyncCompletionActivity::complete,
+              simpleOpts(uniqueId()));
+
+      assertTrue("Activity did not start within 30s", asyncStartLatch.await(30, TimeUnit.SECONDS));
+
+      client
+          .newActivityCompletionClient()
+          .complete(asyncActivityId, Optional.of(asyncActivityRunId), "ext-result-with-run");
+
+      assertEquals("ext-result-with-run", handle.getResult());
+    } finally {
+      asyncStartLatch = null;
+      asyncActivityId = null;
+      asyncActivityRunId = null;
+    }
+  }
+
   // ---------------------------------------------------------------------------
   // Interceptor helpers
   // ---------------------------------------------------------------------------

temporal-sdk/src/test/java/io/temporal/payload/context/ActivitySerializationContextTest.java

@@ -0,0 +1,25 @@
+package io.temporal.payload.context;
+
+import static org.junit.Assert.assertNull;
+
+import org.junit.Test;
+
+public class ActivitySerializationContextTest {
+
+  @Test
+  public void standaloneActivityContextAllowsNullWorkflowFields() {
+    // Standalone activities have no enclosing workflow, so workflowId and workflowType
+    // must be nullable. This currently throws NullPointerException.
+    ActivitySerializationContext ctx =
+        new ActivitySerializationContext(
+            "my-namespace",
+            null, // workflowId — absent for standalone activities
+            null, // workflowType — absent for standalone activities
+            "MyActivity",
+            "my-task-queue",
+            false);
+
+    assertNull(ctx.getWorkflowId());
+    assertNull(ctx.getWorkflowType());
+  }
+}