Cleanup

Author: dandavison

temporalio/worker/_nexus.py

@@ -71,7 +71,7 @@ def __init__(
     def _validate_nexus_services(
         self, nexus_services: Sequence[Any]
     ) -> dict[str, dict[str, nexusrpc.handler.Operation]]:
-        # TODO(dan): Fail if multiple services implement the same service interface.
+        # TODO(dan): Fail if multiple services have the same name.
         nexus_services_by_name: dict[str, dict[str, nexusrpc.handler.Operation]] = {}
         for service in nexus_services:
             defn = nexusrpc.handler.NexusServiceDefinition.from_implementation(service)
@@ -217,11 +217,6 @@ async def _handle_start_operation(
             print(
                 f"🟢 Nexus operation {request.operation} started with async response {result}"
             )
-            # TODO(dan): is it not valid to instantiate proto objects with an argument?
-            # "When called, it accepts no arguments and returns a new featureless instance
-            # that has no instance attributes and cannot be given any.""
-
-            # TODO(dan): python proto instantiation
             op_resp = temporalio.api.nexus.v1.StartOperationResponse(
                 async_success=temporalio.api.nexus.v1.StartOperationResponse.Async(
                     operation_token=result.token,
@@ -243,7 +238,6 @@ async def _handle_start_operation(
             )
         completion = temporalio.bridge.proto.nexus.NexusTaskCompletion(
             task_token=task_token,
-            # TODO(dan): python proto instantiation
             completed=temporalio.api.nexus.v1.Response(start_operation=op_resp),
         )
         await self._bridge_worker().complete_nexus_task(completion)
@@ -269,7 +263,6 @@ async def _handle_cancel_operation(
         # TODO(dan): HandlerError
         completion = temporalio.bridge.proto.nexus.NexusTaskCompletion(
             task_token=task_token,
-            # TODO(dan): python proto instantiation
             completed=temporalio.api.nexus.v1.Response(
                 cancel_operation=temporalio.api.nexus.v1.CancelOperationResponse()
             ),

tests/worker/test_nexus.py

@@ -668,6 +668,9 @@ class ServiceClassNameOutput:
 
 
 # TODO(dan): test interface op types not matching
+# TODO(dan): test multiple registered services with the same name
+# TODO(dan): test no such registered service
+# TODO(dan): test no such registered operation
 
 
 @nexusrpc.interface.service