Try pytest plain asserts on 3.9

Author: Sushisource

Diff for: .github/workflows/ci.yml

@@ -15,6 +15,10 @@ jobs:
         python: ["3.9", "3.13"]
         os: [ubuntu-latest, ubuntu-arm, macos-intel, macos-arm, windows-latest]
         include:
+          # On 3.9 there is a problem with import errors caused by pytests' loader that surface due
+          # to a bug in CPython, so we avoid using the assert rewriter.
+          - python: "3.9"
+            pytestExtraArgs: "--assert=plain"
           - os: ubuntu-latest
             python: "3.13"
             docsTarget: true
@@ -54,13 +58,13 @@ jobs:
       - run: poe lint
       - run: poe build-develop
       - run: mkdir junit-xml
-      - run: poe test -s --junit-xml=junit-xml/${{ matrix.python }}--${{ matrix.os }}.xml
+      - run: poe test ${{matrix.pytestExtraArgs}} -s --junit-xml=junit-xml/${{ matrix.python }}--${{ matrix.os }}.xml
       # Time skipping doesn't yet support ARM
       - if: ${{ !endsWith(matrix.os, '-arm') }}
-        run: poe test -s --workflow-environment time-skipping --junit-xml=junit-xml/${{ matrix.python }}--${{ matrix.os }}--time-skipping.xml
+        run: poe test ${{matrix.pytestExtraArgs}} -s --workflow-environment time-skipping --junit-xml=junit-xml/${{ matrix.python }}--${{ matrix.os }}--time-skipping.xml
       # Check cloud if proper target and not on fork
       - if: ${{ matrix.cloudTestTarget && (github.event.pull_request.head.repo.full_name == '' || github.event.pull_request.head.repo.full_name == 'temporalio/sdk-python') }}
-        run: poe test -s -k test_cloud_client --junit-xml=junit-xml/${{ matrix.python }}--${{ matrix.os }}--cloud.xml
+        run: poe test ${{matrix.pytestExtraArgs}} -s -k test_cloud_client --junit-xml=junit-xml/${{ matrix.python }}--${{ matrix.os }}--cloud.xml
         env:
           TEMPORAL_CLIENT_CLOUD_API_KEY: ${{ secrets.TEMPORAL_CLIENT_CLOUD_API_KEY }}
           TEMPORAL_CLIENT_CLOUD_API_VERSION: 2024-05-13-00

Diff for: tests/testing/test_workflow.py

@@ -1,5 +1,6 @@
 import asyncio
 import platform
+import sys
 import uuid
 from datetime import datetime, timedelta, timezone
 from time import monotonic
@@ -223,7 +224,9 @@ def assert_proper_error(err: Optional[BaseException]) -> None:
         # In unsandboxed workflows, this message has extra diff info appended
         # due to pytest's custom loader that does special assert tricks. But in
         # sandboxed workflows, this just has the first line.
-        assert err.message.startswith("assert 'foo' == 'bar'")
+        # The plain asserter is used for 3.9 & below due to import issues
+        if sys.version_info[:2] > (3, 9):
+            assert err.message.startswith("assert 'foo' == 'bar'")
 
     async with WorkflowEnvironment.from_client(client) as env:
         async with new_worker(env.client, AssertFailWorkflow) as worker:

Diff for: tests/worker/test_worker.py

@@ -565,10 +565,10 @@ def __init__(self) -> None:
     async def run(self):
         await workflow.wait_condition(lambda: self.finish)
         depver = workflow.info().get_current_deployment_version()
-        # assert depver
-        # assert depver.build_id == "2.0"
+        assert depver
+        assert depver.build_id == "2.0"
         # Just ensuring the rust object was converted properly and this method still works
-        # workflow.logger.debug(f"Dep string: {depver.to_canonical_string()}")
+        workflow.logger.debug(f"Dep string: {depver.to_canonical_string()}")
         return "version-v2"
 
     @workflow.signal
@@ -602,9 +602,6 @@ def state(self):
         return "v3"
 
 
-@pytest.mark.skipif(
-    sys.version_info < (3, 12), reason="Skipping for < 3.12 due to import race bug"
-)
 async def test_worker_with_worker_deployment_config(
     client: Client, env: WorkflowEnvironment
 ):
@@ -697,9 +694,6 @@ async def test_worker_with_worker_deployment_config(
         assert res3 == "version-v3"
 
 
-@pytest.mark.skipif(
-    sys.version_info < (3, 12), reason="Skipping for < 3.12 due to import race bug"
-)
 async def test_worker_deployment_ramp(client: Client, env: WorkflowEnvironment):
     if env.supports_time_skipping:
         pytest.skip("Test Server doesn't support worker deployments")
@@ -790,9 +784,6 @@ async def run(self, args: Sequence[RawValue]) -> str:
         return "dynamic"
 
 
-@pytest.mark.skipif(
-    sys.version_info < (3, 12), reason="Skipping for < 3.12 due to import race bug"
-)
 async def test_worker_deployment_dynamic_workflow_on_run(
     client: Client, env: WorkflowEnvironment
 ):
@@ -849,9 +840,6 @@ async def run(self, args: Sequence[RawValue]) -> str:
         return "whee"
 
 
-@pytest.mark.skipif(
-    sys.version_info < (3, 12), reason="Skipping for < 3.12 due to import race bug"
-)
 async def test_workflows_must_have_versioning_behavior_when_feature_turned_on(
     client: Client, env: WorkflowEnvironment
 ):
@@ -886,9 +874,6 @@ async def test_workflows_must_have_versioning_behavior_when_feature_turned_on(
     assert "must specify a versioning behavior" in str(exc_info.value)
 
 
-@pytest.mark.skipif(
-    sys.version_info < (3, 12), reason="Skipping for < 3.12 due to import race bug"
-)
 async def test_workflows_can_use_default_versioning_behavior(
     client: Client, env: WorkflowEnvironment
 ):