Skip to content

Commit 8e13c1e

Browse files
Stop skipping some Nexus tests on time skipping test server (#1338)
Stop skipping some Nexus tests
1 parent 391338b commit 8e13c1e

3 files changed

Lines changed: 0 additions & 32 deletions

File tree

tests/nexus/test_use_existing_conflict_policy.py

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,6 @@
44
import uuid
55
from dataclasses import dataclass
66

7-
import pytest
87
from nexusrpc.handler import service_handler
98

109
from temporalio import nexus, workflow
@@ -91,9 +90,6 @@ async def nexus_operations_have_started(self) -> None:
9190
async def test_multiple_operation_invocations_can_connect_to_same_handler_workflow(
9291
client: Client, env: WorkflowEnvironment
9392
):
94-
if env.supports_time_skipping:
95-
pytest.skip("Nexus tests don't work with time-skipping server")
96-
9793
task_queue = str(uuid.uuid4())
9894
workflow_id = str(uuid.uuid4())
9995

tests/nexus/test_workflow_caller.py

Lines changed: 0 additions & 25 deletions
Original file line numberDiff line numberDiff line change
@@ -663,8 +663,6 @@ async def run(self, input: WorkflowRunHeaderTestCallerWfInput) -> HeaderTestOutp
663663

664664

665665
async def test_sync_operation_happy_path(client: Client, env: WorkflowEnvironment):
666-
if env.supports_time_skipping:
667-
pytest.skip("Nexus tests don't work with time-skipping server")
668666
task_queue = str(uuid.uuid4())
669667
async with Worker(
670668
client,
@@ -701,8 +699,6 @@ async def test_sync_operation_happy_path(client: Client, env: WorkflowEnvironmen
701699
async def test_workflow_run_operation_happy_path(
702700
client: Client, env: WorkflowEnvironment
703701
):
704-
if env.supports_time_skipping:
705-
pytest.skip("Nexus tests don't work with time-skipping server")
706702
task_queue = str(uuid.uuid4())
707703
async with Worker(
708704
client,
@@ -903,9 +899,6 @@ async def test_workflow_run_operation_headers(
903899
env: WorkflowEnvironment,
904900
):
905901
"""Test that headers are propagated to @workflow_run_operation handlers."""
906-
if env.supports_time_skipping:
907-
pytest.skip("Nexus tests don't work with time-skipping server")
908-
909902
task_queue = str(uuid.uuid4())
910903
test_headers = {"x-custom-workflow-run": "workflow-run-value"}
911904

@@ -1387,9 +1380,6 @@ async def run(
13871380
async def test_service_interface_and_implementation_names(
13881381
client: Client, env: WorkflowEnvironment
13891382
):
1390-
if env.supports_time_skipping:
1391-
pytest.skip("Nexus tests don't work with time-skipping server")
1392-
13931383
# Note that:
13941384
# - The caller can specify the service & operation via a reference to either the
13951385
# interface or implementation class.
@@ -1518,9 +1508,6 @@ async def test_workflow_run_operation_can_execute_workflow_before_starting_backi
15181508
client: Client,
15191509
env: WorkflowEnvironment,
15201510
):
1521-
if env.supports_time_skipping:
1522-
pytest.skip("Nexus tests don't work with time-skipping server")
1523-
15241511
task_queue = str(uuid.uuid4())
15251512
async with Worker(
15261513
client,
@@ -1574,9 +1561,6 @@ async def test_nexus_operation_summary(
15741561
client: Client,
15751562
env: WorkflowEnvironment,
15761563
):
1577-
if env.supports_time_skipping:
1578-
pytest.skip("Nexus tests don't work with time-skipping server")
1579-
15801564
task_queue = f"task-queue-{uuid.uuid4()}"
15811565
async with Worker(
15821566
client,
@@ -1869,9 +1853,6 @@ async def run(self, op: str, input: OverloadTestValue) -> OverloadTestValue:
18691853
async def test_workflow_run_operation_overloads(
18701854
client: Client, env: WorkflowEnvironment, op: str
18711855
):
1872-
if env.supports_time_skipping:
1873-
pytest.skip("Nexus tests don't work with time-skipping server")
1874-
18751856
task_queue = str(uuid.uuid4())
18761857
async with Worker(
18771858
client,
@@ -1940,9 +1921,6 @@ async def run(self, task_queue: str) -> None:
19401921

19411922

19421923
async def test_workflow_caller_custom_metrics(client: Client, env: WorkflowEnvironment):
1943-
if env.supports_time_skipping:
1944-
pytest.skip("Nexus tests don't work with time-skipping server")
1945-
19461924
task_queue = str(uuid.uuid4())
19471925
endpoint_name = make_nexus_endpoint_name(task_queue)
19481926
await env.create_nexus_endpoint(endpoint_name, task_queue)
@@ -2019,9 +1997,6 @@ async def test_workflow_caller_custom_metrics(client: Client, env: WorkflowEnvir
20191997
async def test_workflow_caller_buffered_metrics(
20201998
client: Client, env: WorkflowEnvironment
20211999
):
2022-
if env.supports_time_skipping:
2023-
pytest.skip("Nexus tests don't work with time-skipping server")
2024-
20252000
# Create runtime with metric buffer
20262001
buffer = MetricBuffer(10000)
20272002
runtime = Runtime(

tests/nexus/test_workflow_caller_cancellation_types.py

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -238,9 +238,6 @@ async def test_cancellation_type(
238238
env: WorkflowEnvironment,
239239
cancellation_type_name: str,
240240
):
241-
if env.supports_time_skipping:
242-
pytest.skip("Nexus tests don't work with time-skipping server")
243-
244241
cancellation_type = workflow.NexusOperationCancellationType[cancellation_type_name]
245242
global test_context
246243
test_context = TestContext(

0 commit comments

Comments
 (0)