rename functions

Author: brianstrauch

tests/helpers/__init__.py

@@ -269,20 +269,13 @@ async def get_pending_activity_info(
 _wait_for_pause_events: dict[str, threading.Event] = {}
 
 
-def wait_for_pause_release(activity_id: str) -> None:
-    """Block a sync activity until pause_and_assert releases it.
-
-    No-op if no event is registered: pause_and_assert may finish (and clean up
-    the event) before the activity catches its cancel, since the server has
-    already committed paused=true by the time pause_activity returns.
-    """
+def wait_for_pause_event(activity_id: str) -> None:
     event = _wait_for_pause_events.get(activity_id)
     if event is not None:
         event.wait()
 
 
-async def async_wait_for_pause_release(activity_id: str) -> None:
-    """Block an async activity until pause_and_assert releases it. No-op if not registered."""
+async def async_wait_for_pause_event(activity_id: str) -> None:
     event = _wait_for_pause_events.get(activity_id)
     if event is not None:
         await asyncio.get_running_loop().run_in_executor(None, event.wait)

tests/worker/test_workflow.py

@@ -130,14 +130,14 @@
     assert_pending_activity_exists_eventually,
     assert_task_fail_eventually,
     assert_workflow_exists_eventually,
-    async_wait_for_pause_release,
+    async_wait_for_pause_event,
     ensure_search_attributes_present,
     find_free_port,
     get_pending_activity_info,
     new_worker,
     pause_and_assert,
     unpause_and_assert,
-    wait_for_pause_release,
+    wait_for_pause_event,
     workflow_update_exists,
 )
 from tests.helpers.cache_eviction import (
@@ -7784,7 +7784,7 @@ async def heartbeat_activity(
     except (CancelledError, asyncio.CancelledError) as err:
         if not catch_err:
             raise err
-        await async_wait_for_pause_release(activity.info().activity_id)
+        await async_wait_for_pause_event(activity.info().activity_id)
         return activity.cancellation_details()
     finally:
         activity.heartbeat("finally-complete")
@@ -7804,7 +7804,7 @@ def sync_heartbeat_activity(
     except (CancelledError, asyncio.CancelledError) as err:
         if not catch_err:
             raise err
-        wait_for_pause_release(activity.info().activity_id)
+        wait_for_pause_event(activity.info().activity_id)
         return activity.cancellation_details()
     finally:
         activity.heartbeat("finally-complete")