Last review

Author: Sushisource

temporalio/.yardopts

@@ -1,2 +1,2 @@
 --readme README.md
---protected
+--protected

temporalio/lib/temporalio/worker.rb

@@ -88,6 +88,14 @@ def self._load_default_build_id
       build_id
     end
 
+    # @return [DeploymentOptions] Default deployment options, which does not use worker versioning
+    #   or a deployment name, and sets the build id to the one from {self.default_build_id}.
+    def self.default_deployment_options
+      @default_deployment_options ||= DeploymentOptions.new(
+        version: WorkerDeploymentVersion.new(deployment_name: '', build_id: Worker.default_build_id)
+      )
+    end
+
     # Run all workers until cancellation or optional block completes. When the cancellation or block is complete, the
     # workers are shut down. This will return the block result if everything successful or raise an error if not. See
     # {run} for details on how worker shutdown works.
@@ -376,7 +384,7 @@ def initialize(
       workflow_failure_exception_types: [],
       workflow_payload_codec_thread_pool: nil,
       unsafe_workflow_io_enabled: false,
-      deployment_options: nil,
+      deployment_options: Worker.default_deployment_options,
       debug_mode: %w[true 1].include?(ENV['TEMPORAL_DEBUG'].to_s.downcase)
     )
       raise ArgumentError, 'Must have at least one activity or workflow' if activities.empty? && workflows.empty?
@@ -414,13 +422,6 @@ def initialize(
         debug_mode:
       ).freeze
 
-      if deployment_options.nil?
-        deployment_options = DeploymentOptions.new(
-          version: WorkerDeploymentVersion.new(deployment_name: '',
-                                               build_id: Worker.default_build_id)
-        )
-      end
-
       should_enforce_versioning_behavior =
         deployment_options.use_worker_versioning &&
         deployment_options.default_versioning_behavior == VersioningBehavior::UNSPECIFIED

temporalio/lib/temporalio/worker/workflow_replayer.rb

@@ -217,10 +217,7 @@ def initialize(
               graceful_shutdown_period: 0.0,
               nondeterminism_as_workflow_fail:,
               nondeterminism_as_workflow_fail_for_types:,
-              deployment_options: DeploymentOptions.new(
-                version: WorkerDeploymentVersion.new(deployment_name: '',
-                                                     build_id: Worker.default_build_id)
-              )._to_bridge_options
+              deployment_options: Worker.default_deployment_options._to_bridge_options
             )
           )
 

temporalio/sig/temporalio/worker.rbs

@@ -65,6 +65,7 @@ module Temporalio
 
     def self.default_build_id: -> String
     def self._load_default_build_id: -> String
+    def self.default_deployment_options: -> Worker::DeploymentOptions
 
     def self.run_all: [T] (
       *Worker workers,