Last review comments

Author: Sushisource

temporalio/lib/temporalio/client/interceptor.rb

@@ -37,7 +37,6 @@ def intercept_client(next_interceptor)
         :start_delay,
         :request_eager_start,
         :headers,
-        :priority,
         :versioning_override,
         :priority,
         :rpc_options

temporalio/lib/temporalio/worker.rb

@@ -392,8 +392,8 @@ def initialize(
       workflow_payload_codec_thread_pool: nil,
       unsafe_workflow_io_enabled: false,
       deployment_options: Worker.default_deployment_options,
-      workflow_task_poller_behavior: SimpleMaximumPollerBehavior.new(maximum: max_concurrent_workflow_task_polls),
-      activity_task_poller_behavior: SimpleMaximumPollerBehavior.new(maximum: max_concurrent_activity_task_polls),
+      workflow_task_poller_behavior: PollerBehavior::SimpleMaximum.new(max_concurrent_workflow_task_polls),
+      activity_task_poller_behavior: PollerBehavior::SimpleMaximum.new(max_concurrent_activity_task_polls),
       debug_mode: %w[true 1].include?(ENV['TEMPORAL_DEBUG'].to_s.downcase)
     )
       raise ArgumentError, 'Must have at least one activity or workflow' if activities.empty? && workflows.empty?

temporalio/lib/temporalio/worker/poller_behavior.rb

@@ -16,7 +16,7 @@ class SimpleMaximum < PollerBehavior
         attr_reader :maximum
 
         # @param maximum [Integer] Maximum number of concurrent poll requests.
-        def initialize(maximum: 5)
+        def initialize(maximum)
           super()
           @maximum = maximum
         end

temporalio/sig/temporalio/versioning_override.rbs

@@ -1,17 +1,17 @@
 module Temporalio
   class VersioningOverride
     def _to_proto: -> untyped
-  end
 
-  class Pinned < VersioningOverride
-    attr_reader version: WorkerDeploymentVersion
+    class Pinned < VersioningOverride
+        attr_reader version: WorkerDeploymentVersion
 
-    def initialize: (WorkerDeploymentVersion version) -> void
-    def _to_proto: -> untyped
-  end
+        def initialize: (WorkerDeploymentVersion version) -> void
+        def _to_proto: -> untyped
+    end
 
-  class AutoUpgrade < VersioningOverride
-    def initialize: -> void
-    def _to_proto: -> untyped
+    class AutoUpgrade < VersioningOverride
+        def initialize: -> void
+        def _to_proto: -> untyped
+    end
   end
 end

temporalio/sig/temporalio/worker/poller_behavior.rbs

@@ -7,7 +7,7 @@ module Temporalio
     class SimpleMaximum < PollerBehavior
       attr_reader maximum: Integer
 
-      def initialize: (?maximum: Integer) -> void
+      def initialize: (Integer) -> void
       def _to_bridge_options: -> Internal::Bridge::Worker::PollerBehaviorSimpleMaximum
     end
 

temporalio/test/worker_test.rb

@@ -207,23 +207,22 @@ def test_can_run_with_autoscaling_poller_behavior
       )
     )
     worker.run do
-      # Give pollers a beat to get started
-      sleep(0.3)
-
-      dump = Net::HTTP.get(URI("http://#{prom_addr}/metrics"))
-      lines = dump.split("\n")
-
-      matches = lines.select { |l| l.include?('temporal_num_pollers') }
-      activity_pollers = matches.select { |l| l.include?('activity_task') }
-      assert_equal 1, activity_pollers.size
-      assert activity_pollers[0].end_with?('2')
-
-      workflow_pollers = matches.select { |l| l.include?('workflow_task') }
-      assert_equal 2, workflow_pollers.size
-      # There's sticky & non-sticky pollers, and they may have a count of 1 or 2 depending on
-      # initialization timing.
-      assert(workflow_pollers[0].end_with?('2') || workflow_pollers[0].end_with?('1'))
-      assert(workflow_pollers[1].end_with?('2') || workflow_pollers[1].end_with?('1'))
+      assert_eventually do
+        dump = Net::HTTP.get(URI("http://#{prom_addr}/metrics"))
+        lines = dump.split("\n")
+
+        matches = lines.select { |l| l.include?('temporal_num_pollers') }
+        activity_pollers = matches.select { |l| l.include?('activity_task') }
+        assert_equal 1, activity_pollers.size
+        assert activity_pollers[0].end_with?('2')
+
+        workflow_pollers = matches.select { |l| l.include?('workflow_task') }
+        assert_equal 2, workflow_pollers.size
+        # There's sticky & non-sticky pollers, and they may have a count of 1 or 2 depending on
+        # initialization timing.
+        assert(workflow_pollers[0].end_with?('2') || workflow_pollers[0].end_with?('1'))
+        assert(workflow_pollers[1].end_with?('2') || workflow_pollers[1].end_with?('1'))
+      end
 
       handles = Array.new(20) do
         env.client.start_workflow(