Skip to content

Commit ddb2762

Browse files
fix: use workflow type name in WorkflowAlreadyStartedError (#411)
* test: add failing test asserting workflow type * fix: use workflow type name in WorkflowAlreadyStartedError
1 parent bcc7510 commit ddb2762

2 files changed

Lines changed: 9 additions & 5 deletions

File tree

temporalio/lib/temporalio/internal/client/implementation.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -228,7 +228,7 @@ def start_update_with_start_workflow(input)
228228
if details
229229
e = Error::WorkflowAlreadyStartedError.new(
230230
workflow_id: start_options.id,
231-
workflow_type: start_req.workflow_type,
231+
workflow_type: start_req.workflow_type.name,
232232
run_id: details.run_id
233233
)
234234
end

temporalio/test/worker_workflow_handler_test.rb

Lines changed: 8 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -742,14 +742,16 @@ def test_update_with_start_simple
742742
UpdateWithStartWorkflow, 123,
743743
id:, task_queue: worker.task_queue, id_conflict_policy: Temporalio::WorkflowIDConflictPolicy::FAIL
744744
)
745-
assert_raises(Temporalio::Error::WorkflowAlreadyStartedError) do
745+
err = assert_raises(Temporalio::Error::WorkflowAlreadyStartedError) do
746746
env.client.execute_update_with_start_workflow(
747747
UpdateWithStartWorkflow.increment_counter, 456, start_workflow_operation:
748748
)
749749
end
750-
assert_raises(Temporalio::Error::WorkflowAlreadyStartedError) do
750+
assert_equal 'UpdateWithStartWorkflow', err.workflow_type
751+
err = assert_raises(Temporalio::Error::WorkflowAlreadyStartedError) do
751752
start_workflow_operation.workflow_handle
752753
end
754+
assert_equal 'UpdateWithStartWorkflow', err.workflow_type
753755
end
754756
end
755757

@@ -830,15 +832,17 @@ def test_update_with_start_start_fail
830832
UpdateWithStartWorkflow, 123,
831833
id:, task_queue: worker.task_queue, id_conflict_policy: Temporalio::WorkflowIDConflictPolicy::FAIL
832834
)
833-
assert_raises(Temporalio::Error::WorkflowAlreadyStartedError) do
835+
err = assert_raises(Temporalio::Error::WorkflowAlreadyStartedError) do
834836
env.client.start_update_with_start_workflow(
835837
UpdateWithStartWorkflow.increment_counter, 456,
836838
wait_for_stage: Temporalio::Client::WorkflowUpdateWaitStage::ACCEPTED, start_workflow_operation:
837839
)
838840
end
839-
assert_raises(Temporalio::Error::WorkflowAlreadyStartedError) do
841+
assert_equal 'UpdateWithStartWorkflow', err.workflow_type
842+
err = assert_raises(Temporalio::Error::WorkflowAlreadyStartedError) do
840843
start_workflow_operation.workflow_handle
841844
end
845+
assert_equal 'UpdateWithStartWorkflow', err.workflow_type
842846
end
843847
end
844848

0 commit comments

Comments
 (0)