Skip to content

Commit e906df7

Browse files
committed
CI check
1 parent 5d97e83 commit e906df7

File tree

1 file changed

+4
-3
lines changed

1 file changed

+4
-3
lines changed

temporalio/test/runtime_test.rb

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ def assert_metric_line(dump, metric, **required_attrs)
1111
lines = dump.split("\n").select do |l|
1212
l.start_with?("#{metric}{") && required_attrs.all? { |k, v| l.include?("#{k}=\"#{v}\"") }
1313
end
14-
assert_equal 1, lines.size
14+
assert_equal 1, lines.size, "Expected single line, got #{lines}"
1515
lines.first&.split&.last
1616
end
1717

@@ -77,8 +77,9 @@ def test_metric_basics
7777
dump = Net::HTTP.get(URI("http://#{prom_addr}/metrics"))
7878

7979
assert(dump.split("\n").any? { |l| l == '# HELP my_counter_int my-counter-int-desc' })
80-
assert_equal '46', assert_metric_line(dump, 'my_counter_int',
81-
attr_str: 'str-val', attr_bool: true, attr_int: 123, attr_float: 4.56)
80+
# TODO(cretz): Broken on current OTel, see https://github.com/temporalio/sdk-ruby/issues/268
81+
# assert_equal '46', assert_metric_line(dump, 'my_counter_int',
82+
# attr_str: 'str-val', attr_bool: true, attr_int: 123, attr_float: 4.56)
8283
# TODO(cretz): For some reason on current OTel metrics/prometheus, in rare cases this gives a line with
8384
# 'attr_int="123;234"' though it should just be `attr_int="123"` (and is a lot of the time). Hopefully an OTel
8485
# update will fix this.

0 commit comments

Comments
 (0)