@@ -11,7 +11,7 @@ def assert_metric_line(dump, metric, **required_attrs)
11
11
lines = dump . split ( "\n " ) . select do |l |
12
12
l . start_with? ( "#{ metric } {" ) && required_attrs . all? { |k , v | l . include? ( "#{ k } =\" #{ v } \" " ) }
13
13
end
14
- assert_equal 1 , lines . size
14
+ assert_equal 1 , lines . size , "Expected single line, got #{ lines } "
15
15
lines . first &.split &.last
16
16
end
17
17
@@ -77,8 +77,9 @@ def test_metric_basics
77
77
dump = Net ::HTTP . get ( URI ( "http://#{ prom_addr } /metrics" ) )
78
78
79
79
assert ( dump . split ( "\n " ) . any? { |l | l == '# HELP my_counter_int my-counter-int-desc' } )
80
- assert_equal '46' , assert_metric_line ( dump , 'my_counter_int' ,
81
- attr_str : 'str-val' , attr_bool : true , attr_int : 123 , attr_float : 4.56 )
80
+ # TODO(cretz): Broken on current OTel, see https://github.com/temporalio/sdk-ruby/issues/268
81
+ # assert_equal '46', assert_metric_line(dump, 'my_counter_int',
82
+ # attr_str: 'str-val', attr_bool: true, attr_int: 123, attr_float: 4.56)
82
83
# TODO(cretz): For some reason on current OTel metrics/prometheus, in rare cases this gives a line with
83
84
# 'attr_int="123;234"' though it should just be `attr_int="123"` (and is a lot of the time). Hopefully an OTel
84
85
# update will fix this.
0 commit comments