attempt to remove non-determism in type checking

Author: chris-olszewski

temporalio/test/support/sig_applicator.rb

@@ -43,18 +43,6 @@ module SigApplicator
   @mutex = Mutex.new
 
   class << self
-    # Known type mismatches that are not RBI issues. Internal terminal
-    # interceptor implementations intentionally pass nil as next_interceptor,
-    # and some tests intentionally pass wrong types to verify error handling.
-    IGNORED_ERRORS = [
-      # WorkerActivityTest passes a non-activity class to test validation
-      # 'WorkerActivityTest::NotAnActivity',
-      # implementation.rb:231 passes proto WorkflowType object instead of .name
-      # 'Temporalio::Api::Common::V1::WorkflowType',
-      # Proto conversion edge case returning inspect string
-      # 'got type String with value "#<data Temporalio::RetryPo'
-    ].freeze
-
     def apply_all!
       configure_error_handler!
       register_summary_hook!
@@ -79,15 +67,31 @@ def apply_all!
     end
 
     def record_type_error(message)
-      Temporalio::Workflow::Unsafe.illegal_call_tracing_disabled do
-        @mutex.synchronize { @type_errors << message }
-      end
+      return if Thread.current[:sig_applicator_suppressed]
+
+      # Avoid illegal_call_tracing_disabled here — interacting with the
+      # workflow tracer + mutex from inside error handlers can cause
+      # non-deterministic behavior. Instead, rescue the NondeterminismError
+      # that fires when accessing Mutex from within a workflow.
+      @mutex.synchronize { @type_errors << message }
+    rescue Temporalio::Workflow::NondeterminismError
+      # Best-effort: append without synchronization when inside a workflow
+      @type_errors << message
     end
 
     def type_errors
       @mutex.synchronize { @type_errors.dup }
     end
 
+    # Suppress type error recording for the duration of a block.
+    # Use for tests that intentionally pass wrong types.
+    def suppress_errors
+      Thread.current[:sig_applicator_suppressed] = true
+      yield
+    ensure
+      Thread.current[:sig_applicator_suppressed] = false
+    end
+
     private
 
     def configure_error_handler!
@@ -105,8 +109,6 @@ def configure_error_handler!
           return
         end
 
-        return if IGNORED_ERRORS.any? { |pattern| message.include?(pattern) }
-
         # Include location for debugging
         location = opts[:location]
         full = location ? "#{message}\n  Location: #{location}" : message

temporalio/test/worker_activity_test.rb

@@ -153,11 +153,20 @@ class NotAnActivity # rubocop:disable Lint/EmptyClass
 
   def test_not_an_activity
     error = assert_raises(ArgumentError) do
-      Temporalio::Worker.new(
-        client: env.client,
-        task_queue: "tq-#{SecureRandom.uuid}",
-        activities: [NotAnActivity]
-      )
+      # Intentionally passing a non-activity class to test validation.
+      # Suppress sorbet runtime errors since the wrong type is deliberate.
+      block = proc do
+        Temporalio::Worker.new(
+          client: env.client,
+          task_queue: "tq-#{SecureRandom.uuid}",
+          activities: [NotAnActivity]
+        )
+      end
+      if defined?(SigApplicator)
+        SigApplicator.suppress_errors(&block)
+      else
+        block.call
+      end
     end
     assert error.message.end_with?('does not extend Temporalio::Activity::Definition')
   end