clean up

Author: yuandrew

client/src/lib.rs

@@ -390,7 +390,7 @@ pub struct ConfiguredClient<C> {
     headers: Arc<RwLock<ClientHeaders>>,
     /// Capabilities as read from the `get_system_info` RPC call made on client connection
     capabilities: Option<get_system_info_response::Capabilities>,
-    workers: Arc<ClientWorkerSet>, // ClientWorkerSet
+    workers: Arc<ClientWorkerSet>,
 }
 
 impl<C> ConfiguredClient<C> {

client/src/worker_registry/mod.rs

@@ -109,7 +109,9 @@ impl SlotManagerImpl {
     }
 }
 
+/// This trait represents a shared namespace worker that sends worker heartbeats and worker commands.
 pub trait SharedNamespaceWorkerTrait: std::fmt::Debug {
+    /// Namespace that the shared namespace worker is connected to.
     fn namespace(&self) -> String;
 
     /// Unregisters a heartbeat callback. Returns the callback removed, as well as a bool that
@@ -120,6 +122,7 @@ pub trait SharedNamespaceWorkerTrait: std::fmt::Debug {
         worker_instance_key: String,
     ) -> (Option<Box<dyn Fn() -> WorkerHeartbeat + Send + Sync>>, bool);
 
+    /// Registers a heartbeat callback.
     fn register_callback(
         &self,
         worker_instance_key: String,
@@ -184,7 +187,7 @@ impl ClientWorkerSet {
         worker.register_callback(worker_instance_key, heartbeat_callback)
     }
 
-    /// Unregister
+    /// Unregister a worker with the worker heartbeat manager.
     pub fn unregister_heartbeat_worker(
         &self,
         namespace: String,

core/src/core_tests/workflow_tasks.rs

@@ -2995,7 +2995,7 @@ async fn both_normal_and_sticky_pollers_poll_concurrently() {
         Some("stickytq".to_string()),
         Arc::new(mock_client),
         None,
-        false,
+        None,
     );
 
     for _ in 1..50 {

core/src/telemetry/metrics.rs

@@ -1,3 +1,5 @@
+#[cfg(test)]
+use crate::TelemetryInstance;
 use crate::abstractions::dbg_panic;
 
 use std::{

core/src/test_help/integ_helpers.rs

@@ -185,7 +185,7 @@ pub fn build_fake_worker(
 }
 
 pub fn mock_worker(mocks: MocksHolder) -> Worker {
-    let sticky_q = sticky_q_name_for_worker("unit-test", &mocks.inputs.config);
+    let sticky_q = sticky_q_name_for_worker("unit-test", mocks.inputs.config.max_cached_workflows);
     let act_poller = if mocks.inputs.config.no_remote_activities {
         None
     } else {