Proto updates again

Author: Sushisource

core/src/pollers/poll_buffer.rs

@@ -20,8 +20,7 @@ use temporal_sdk_core_api::worker::{
     ActivitySlotKind, NexusSlotKind, PollerBehavior, SlotKind, WorkflowSlotKind,
 };
 use temporal_sdk_core_protos::temporal::api::{
-    sdk::v1::PollerScalingDecision,
-    taskqueue::v1::TaskQueue,
+    taskqueue::v1::{PollerScalingDecision, TaskQueue},
     workflowservice::v1::{
         PollActivityTaskQueueResponse, PollNexusTaskQueueResponse, PollWorkflowTaskQueueResponse,
     },
@@ -298,14 +297,16 @@ impl PollScalerReportHandle {
                     return;
                 }
                 if let Some(scaling_decision) = res.scaling_decision() {
-                    match scaling_decision.poller_delta.cmp(&0) {
+                    match scaling_decision.poll_request_delta_suggestion.cmp(&0) {
                         cmp::Ordering::Less => self.change_target(
                             usize::saturating_sub,
-                            scaling_decision.poller_delta.unsigned_abs() as usize,
+                            scaling_decision
+                                .poll_request_delta_suggestion
+                                .unsigned_abs() as usize,
                         ),
                         cmp::Ordering::Greater => self.change_target(
                             usize::saturating_add,
-                            scaling_decision.poller_delta as usize,
+                            scaling_decision.poll_request_delta_suggestion as usize,
                         ),
                         cmp::Ordering::Equal => {}
                     }

sdk-core-protos/protos/api_upstream/openapi/openapiv2.json

@@ -11432,12 +11432,13 @@
     "v1PollerScalingDecision": {
       "type": "object",
       "properties": {
-        "pollerDelta": {
+        "pollRequestDeltaSuggestion": {
           "type": "integer",
           "format": "int32",
-          "description": "How many pollers should be added or removed, if any. As of now, server only scales up or down\nby 1. However, SDKs should allow for other values (while staying within defined min/max)."
+          "description": "How many poll requests to suggest should be added or removed, if any. As of now, server only\nscales up or down by 1. However, SDKs should allow for other values (while staying within\ndefined min/max).\n\nThe SDK is free to ignore this suggestion, EX: making more polls would not make sense because\nall slots are already occupied."
         }
-      }
+      },
+      "description": "Attached to task responses to give hints to the SDK about how it may adjust its number of\npollers."
     },
     "v1ProtocolMessageCommandAttributes": {
       "type": "object",

sdk-core-protos/protos/api_upstream/openapi/openapiv3.yaml

@@ -8595,12 +8595,19 @@ components:
     PollerScalingDecision:
       type: object
       properties:
-        pollerDelta:
+        pollRequestDeltaSuggestion:
           type: integer
           description: |-
-            How many pollers should be added or removed, if any. As of now, server only scales up or down
-             by 1. However, SDKs should allow for other values (while staying within defined min/max).
+            How many poll requests to suggest should be added or removed, if any. As of now, server only
+             scales up or down by 1. However, SDKs should allow for other values (while staying within
+             defined min/max).
+
+             The SDK is free to ignore this suggestion, EX: making more polls would not make sense because
+             all slots are already occupied.
           format: int32
+      description: |-
+        Attached to task responses to give hints to the SDK about how it may adjust its number of
+         pollers.
     QueryRejected:
       type: object
       properties:

sdk-core-protos/protos/api_upstream/temporal/api/sdk/v1/poller_scaling.proto

@@ -323,4 +323,16 @@ message TimestampedBuildIdAssignmentRule {
 message TimestampedCompatibleBuildIdRedirectRule {
     CompatibleBuildIdRedirectRule rule = 1;
     google.protobuf.Timestamp create_time = 2;
-}
+}
+
+// Attached to task responses to give hints to the SDK about how it may adjust its number of
+// pollers.
+message PollerScalingDecision {
+  // How many poll requests to suggest should be added or removed, if any. As of now, server only
+  // scales up or down by 1. However, SDKs should allow for other values (while staying within
+  // defined min/max).
+  //
+  // The SDK is free to ignore this suggestion, EX: making more polls would not make sense because
+  // all slots are already occupied.
+  int32 poll_request_delta_suggestion = 1;
+}

sdk-core-protos/protos/api_upstream/temporal/api/taskqueue/v1/message.proto

@@ -58,7 +58,6 @@ import "temporal/api/taskqueue/v1/message.proto";
 import "temporal/api/update/v1/message.proto";
 import "temporal/api/version/v1/message.proto";
 import "temporal/api/batch/v1/message.proto";
-import "temporal/api/sdk/v1/poller_scaling.proto";
 import "temporal/api/sdk/v1/task_complete_metadata.proto";
 import "temporal/api/sdk/v1/user_metadata.proto";
 import "temporal/api/nexus/v1/message.proto";
@@ -333,7 +332,7 @@ message PollWorkflowTaskQueueResponse {
     // Protocol messages piggybacking on a WFT as a transport
     repeated temporal.api.protocol.v1.Message messages = 15;
     // Server-advised information the SDK may use to adjust its poller count.
-    temporal.api.sdk.v1.PollerScalingDecision poller_scaling_decision = 16;
+    temporal.api.taskqueue.v1.PollerScalingDecision poller_scaling_decision = 16;
 }
 
 message RespondWorkflowTaskCompletedRequest {
@@ -500,7 +499,7 @@ message PollActivityTaskQueueResponse {
     // values are not specified or exceed configured system limits.
     temporal.api.common.v1.RetryPolicy retry_policy = 17;
     // Server-advised information the SDK may use to adjust its poller count.
-    temporal.api.sdk.v1.PollerScalingDecision poller_scaling_decision = 18;
+    temporal.api.taskqueue.v1.PollerScalingDecision poller_scaling_decision = 18;
 }
 
 message RecordActivityTaskHeartbeatRequest {
@@ -1739,7 +1738,7 @@ message PollNexusTaskQueueResponse {
     // Embedded request as translated from the incoming frontend request.
     temporal.api.nexus.v1.Request request = 2;
     // Server-advised information the SDK may use to adjust its poller count.
-    temporal.api.sdk.v1.PollerScalingDecision poller_scaling_decision = 3;
+    temporal.api.taskqueue.v1.PollerScalingDecision poller_scaling_decision = 3;
 }
 
 message RespondNexusTaskCompletedRequest {
@@ -2113,7 +2112,7 @@ message ListWorkerDeploymentsResponse {
     bytes next_page_token = 1;
     // The list of worker deployments.
     repeated WorkerDeploymentSummary worker_deployments = 2;
-  
+
     // (-- api-linter: core::0123::resource-annotation=disabled --)
     // A subset of WorkerDeploymentInfo
     message WorkerDeploymentSummary {

sdk-core-protos/protos/api_upstream/temporal/api/workflowservice/v1/request_response.proto

@@ -24,7 +24,7 @@ use tracing::info;
 #[tokio::test]
 async fn poller_load_spiky() {
     const SIGNAME: &str = "signame";
-    let num_workflows = 250;
+    let num_workflows = 1000;
     let wf_name = "poller_load";
     let (telemopts, addr, _aborter) =
         if std::env::var("PAR_JOBNUM").unwrap_or("1".to_string()) == "1" {