Refactor cloud tests to a separate test library and CI job

Author: tconley1428

.cargo/config.toml

@@ -5,6 +5,7 @@ CLI_VERSION_OVERRIDE = "v1.3.1-priority.0"
 
 [alias]
 integ-test = ["run", "--package", "temporal-sdk-core", "--example", "integ_runner", "--"]
+cloud-test = ["run", "--package", "temporal-sdk-core", "--example", "integ_runner", "--", "--test-name", "cloud_tests"]
 lint = ["clippy", "--workspace", "--examples", "--all-features",
     "--test", "integ_tests", "--test", "heavy_tests", "--test", "manual_tests",
     "--", "--D", "warnings"]

.github/workflows/per-pr.yml

@@ -76,11 +76,6 @@ jobs:
 
   integ-tests:
     name: Integ tests
-    env:
-      TEMPORAL_CLOUD_ADDRESS: https://${{ vars.TEMPORAL_CLIENT_NAMESPACE }}.tmprl.cloud:7233
-      TEMPORAL_CLOUD_NAMESPACE: ${{ vars.TEMPORAL_CLIENT_NAMESPACE }}
-      TEMPORAL_CLIENT_CERT: ${{ secrets.TEMPORAL_CLIENT_CERT }}
-      TEMPORAL_CLIENT_KEY: ${{ secrets.TEMPORAL_CLIENT_KEY }}
     timeout-minutes: 20
     strategy:
       fail-fast: false
@@ -111,6 +106,31 @@ jobs:
       - uses: Swatinem/rust-cache@v2
       - run: cargo integ-test
 
+  cloud-tests:
+    if: github.repository_owner == 'temporalio'
+    name: Cloud tests
+    env:
+      TEMPORAL_CLOUD_ADDRESS: https://${{ vars.TEMPORAL_CLIENT_NAMESPACE }}.tmprl.cloud:7233
+      TEMPORAL_CLOUD_NAMESPACE: ${{ vars.TEMPORAL_CLIENT_NAMESPACE }}
+      TEMPORAL_CLIENT_CERT: ${{ secrets.TEMPORAL_CLIENT_CERT }}
+      TEMPORAL_CLIENT_KEY: ${{ secrets.TEMPORAL_CLIENT_KEY }}
+    timeout-minutes: 20
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v4
+      - uses: dtolnay/rust-toolchain@stable
+        with:
+          toolchain: 1.85.0
+      - name: Install protoc
+        uses: arduino/setup-protoc@v3
+        with:
+          # TODO: Upgrade proto once https://github.com/arduino/setup-protoc/issues/99 is fixed
+          version: '23.x'
+          repo-token: ${{ secrets.GITHUB_TOKEN }}
+
+      - uses: Swatinem/rust-cache@v2
+      - run: cargo cloud-test
+
   docker-integ-tests:
     name: Docker integ tests
     env:

core/Cargo.toml

@@ -120,6 +120,11 @@ name = "global_metric_tests"
 path = "../tests/global_metric_tests.rs"
 test = false
 
+[[test]]
+name = "cloud_tests"
+path = "../tests/cloud_tests.rs"
+test = false
+
 [[bench]]
 name = "workflow_replay"
 harness = false

tests/cloud_tests.rs

@@ -0,0 +1,48 @@
+use std::env;
+use std::str::FromStr;
+use url::Url;
+use temporal_client::{Client, ClientOptionsBuilder, ClientTlsConfig, RetryClient, TlsConfig, WorkflowClientTrait};
+
+async fn get_client() -> RetryClient<Client> {
+    let cloud_addr = env::var("TEMPORAL_CLOUD_ADDRESS").unwrap();
+    let cloud_key = env::var("TEMPORAL_CLIENT_KEY").unwrap();
+
+    let client_cert = env::var("TEMPORAL_CLIENT_CERT")
+        .expect("TEMPORAL_CLIENT_CERT must be set")
+        .replace("\\n", "\n")
+        .into_bytes();
+    let client_private_key = cloud_key.replace("\\n", "\n").into_bytes();
+    let sgo = ClientOptionsBuilder::default()
+        .target_url(Url::from_str(&cloud_addr).unwrap())
+        .client_name("tls_tester")
+        .client_version("clientver")
+        .tls_cfg(TlsConfig {
+            client_tls_config: Some(ClientTlsConfig {
+                client_cert,
+                client_private_key,
+            }),
+            ..Default::default()
+        })
+        .build()
+        .unwrap();
+    sgo
+        .connect(
+            env::var("TEMPORAL_CLOUD_NAMESPACE").expect("TEMPORAL_CLOUD_NAMESPACE must be set"),
+            None,
+        )
+        .await
+        .unwrap()
+}
+
+#[tokio::test]
+async fn tls_test() {
+    let con = get_client().await;
+    con.list_workflow_executions(100, vec![], "".to_string())
+        .await
+        .unwrap();
+}
+
+#[tokio::test]
+async fn grpc_message_too_large_test() {
+    // TODO
+}

tests/main.rs

@@ -66,51 +66,6 @@ mod integ_tests {
             .await;
     }
 
-    #[tokio::test]
-    async fn tls_test() {
-        let cloud_addr = env::var("TEMPORAL_CLOUD_ADDRESS");
-        let cloud_key = env::var("TEMPORAL_CLIENT_KEY");
-
-        let (cloud_addr, cloud_key) = if let (Ok(c), Ok(ck)) = (cloud_addr, cloud_key) {
-            if ck.is_empty() {
-                return; // secret not present in github, could be a fork, just skip
-            }
-            (c, ck)
-        } else {
-            // Skip the test
-            return;
-        };
-
-        let client_cert = env::var("TEMPORAL_CLIENT_CERT")
-            .expect("TEMPORAL_CLIENT_CERT must be set")
-            .replace("\\n", "\n")
-            .into_bytes();
-        let client_private_key = cloud_key.replace("\\n", "\n").into_bytes();
-        let sgo = ClientOptionsBuilder::default()
-            .target_url(Url::from_str(&cloud_addr).unwrap())
-            .client_name("tls_tester")
-            .client_version("clientver")
-            .tls_cfg(TlsConfig {
-                client_tls_config: Some(ClientTlsConfig {
-                    client_cert,
-                    client_private_key,
-                }),
-                ..Default::default()
-            })
-            .build()
-            .unwrap();
-        let con = sgo
-            .connect(
-                env::var("TEMPORAL_CLOUD_NAMESPACE").expect("TEMPORAL_CLOUD_NAMESPACE must be set"),
-                None,
-            )
-            .await
-            .unwrap();
-        con.list_workflow_executions(100, vec![], "".to_string())
-            .await
-            .unwrap();
-    }
-
     pub(crate) async fn mk_nexus_endpoint(starter: &mut CoreWfStarter) -> String {
         let client = starter.get_client().await;
         let endpoint = format!("mycoolendpoint-{}", rand_6_chars());