Fixed circular dependency build issue

Author: maciejdudko

packages/client/src/activity-client.ts

@@ -1,4 +1,5 @@
 import { status } from '@grpc/grpc-js';
+import { v4 as uuid4 } from 'uuid';
 import type {
   LoadedDataConverter,
   Next,
@@ -7,7 +8,13 @@ import type {
   SearchAttributePair,
   TypedSearchAttributes,
 } from '@temporalio/common';
-import { compilePriority, compileRetryPolicy, decodePriority, decompileRetryPolicy } from '@temporalio/common';
+import {
+  compilePriority,
+  compileRetryPolicy,
+  convertDeploymentVersion,
+  decodePriority,
+  decompileRetryPolicy,
+} from '@temporalio/common';
 import type { Duration } from '@temporalio/common/lib/time';
 import { msOptionalToTs, optionalTsToDate, optionalTsToMs } from '@temporalio/common/lib/time';
 import { SymbolBasedInstanceOfError } from '@temporalio/common/lib/type-helpers';
@@ -17,15 +24,13 @@ import {
   encodeUnifiedSearchAttributes,
   searchAttributePayloadConverter,
 } from '@temporalio/common/lib/converter/payload-search-attributes';
-import { convertDeploymentVersion } from '@temporalio/worker/lib/utils';
 import {
   decodeArrayFromPayloads,
   decodeFromPayloadsAtIndex,
   decodeOptionalFailureToOptionalError,
   encodeToPayloads,
   encodeUserMetadata,
 } from '@temporalio/common/lib/internal-non-workflow';
-import { uuid4 } from '@temporalio/workflow';
 import type { temporal } from '@temporalio/proto';
 import type {
   ActivityCancelInput,

packages/common/src/worker-deployments.ts

@@ -1,4 +1,4 @@
-import type { temporal } from '@temporalio/proto';
+import type { coresdk, temporal } from '@temporalio/proto';
 import { makeProtoEnumConverters } from './internal-workflow';
 
 /**
@@ -98,3 +98,19 @@ export const [encodeInitialVersioningBehavior, decodeInitialVersioningBehavior]
   } as const,
   'CONTINUE_AS_NEW_VERSIONING_BEHAVIOR_'
 );
+
+/**
+ * @internal
+ */
+export function convertDeploymentVersion(
+  v: coresdk.common.IWorkerDeploymentVersion | null | undefined
+): WorkerDeploymentVersion | undefined {
+  if (!v || !v.buildId) {
+    return undefined;
+  }
+
+  return {
+    buildId: v.buildId,
+    deploymentName: v.deploymentName ?? '',
+  };
+}

packages/worker/src/utils.ts

@@ -1,4 +1,3 @@
-import type { WorkerDeploymentVersion } from '@temporalio/common';
 import type { coresdk, temporal } from '@temporalio/proto';
 import type { ParentWorkflowInfo, RootWorkflowInfo } from '@temporalio/workflow';
 
@@ -26,19 +25,6 @@ export function convertToParentWorkflowType(
   };
 }
 
-export function convertDeploymentVersion(
-  v: coresdk.common.IWorkerDeploymentVersion | null | undefined
-): WorkerDeploymentVersion | undefined {
-  if (!v || !v.buildId) {
-    return undefined;
-  }
-
-  return {
-    buildId: v.buildId,
-    deploymentName: v.deploymentName ?? '',
-  };
-}
-
 export function convertToRootWorkflowType(
   root: temporal.api.common.v1.IWorkflowExecution | null | undefined
 ): RootWorkflowInfo | undefined {

packages/worker/src/worker.ts

@@ -23,6 +23,7 @@ import {
   decodePriority,
   CancelledFailure,
   ActivityCancellationDetails,
+  convertDeploymentVersion,
 } from '@temporalio/common';
 import type { Decoded } from '@temporalio/common/lib/internal-non-workflow';
 import {
@@ -65,12 +66,7 @@ import type { History } from './runtime';
 import { Runtime } from './runtime';
 import type { CloseableGroupedObservable } from './rxutils';
 import { closeableGroupBy, mapWithState, mergeMapWithState } from './rxutils';
-import {
-  byteArrayToBuffer,
-  convertDeploymentVersion,
-  convertToParentWorkflowType,
-  convertToRootWorkflowType,
-} from './utils';
+import { byteArrayToBuffer, convertToParentWorkflowType, convertToRootWorkflowType } from './utils';
 import type {
   CompiledWorkerOptions,
   CompiledWorkerOptionsWithBuildId,

packages/worker/src/workflow/vm-shared.ts

@@ -5,7 +5,7 @@ import assert from 'node:assert';
 import { URL, URLSearchParams } from 'node:url';
 import { TextDecoder, TextEncoder } from 'node:util';
 import { SourceMapConsumer } from 'source-map';
-import { cutoffStackTrace, IllegalStateError } from '@temporalio/common';
+import { cutoffStackTrace, IllegalStateError, convertDeploymentVersion } from '@temporalio/common';
 import { suggestContinueAsNewReasonsFromProto } from '@temporalio/common/lib/continue-as-new';
 import { tsToMs } from '@temporalio/common/lib/time';
 import { coresdk } from '@temporalio/proto';
@@ -15,7 +15,6 @@ import type * as internals from '@temporalio/workflow/lib/worker-interface';
 import type { Activator } from '@temporalio/workflow/lib/internals';
 import { SdkFlags } from '@temporalio/workflow/lib/flags';
 import { UnhandledRejectionError } from '../errors';
-import { convertDeploymentVersion } from '../utils';
 import type { Workflow } from './interface';
 import type { WorkflowBundleWithSourceMapAndFilename } from './workflow-worker-thread/input';