Skip to content

Commit edb9d78

Browse files
update comments
1 parent 7557c51 commit edb9d78

4 files changed

Lines changed: 6 additions & 6 deletions

File tree

packages/proto/protos/index.d.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -5,14 +5,14 @@
55
*
66
* ### Core SDK API
77
*
8-
* [Core SDK](https://github.com/temporalio/sdk-core) interfaces can be accessed in the `coresdk` namespace.
8+
* [Core SDK](https://github.com/temporalio/sdk-rust) interfaces can be accessed in the `coresdk` namespace.
99
*
1010
* ```ts
1111
* import { coresdk } from '@temporalio/proto';
1212
* const activityTask: coresdk.activity_task.IActivityTask = { ... };
1313
* ```
1414
*
15-
* The source protos are in the [sdk-core repo](https://github.com/temporalio/sdk-core/tree/ts-release/protos/local/temporal/sdk/core), for example [`ActivityTask` in `activity_task.proto`](https://github.com/temporalio/sdk-core/blob/85454935e39f789aaaa81f8a05773f8e2cdbcde2/protos/local/temporal/sdk/core/activity_task/activity_task.proto#L12).
15+
* The source protos are in the [sdk-rust repo](https://github.com/temporalio/sdk-rust/tree/ts-release/protos/local/temporal/sdk/core), for example [`ActivityTask` in `activity_task.proto`](https://github.com/temporalio/sdk-rust/blob/85454935e39f789aaaa81f8a05773f8e2cdbcde2/protos/local/temporal/sdk/core/activity_task/activity_task.proto#L12).
1616
*
1717
* ### Temporal Service API
1818
*
@@ -23,7 +23,7 @@
2323
* const retryPolicy: temporal.api.common.v1.IRetryPolicy = { ... };
2424
* ```
2525
*
26-
* The source protos are in [sdk-core/protos/api_upstream/temporal/api/](https://github.com/temporalio/sdk-core/tree/ts-release/protos/api_upstream/temporal/api), for example [`RetryPolicy` in `temporal/api/common/v1/message.proto`](https://github.com/temporalio/sdk-core/blob/85454935e39f789aaaa81f8a05773f8e2cdbcde2/protos/api_upstream/temporal/api/common/v1/message.proto#L96).
26+
* The source protos are in [sdk-rust/protos/api_upstream/temporal/api/](https://github.com/temporalio/sdk-rust/tree/ts-release/protos/api_upstream/temporal/api), for example [`RetryPolicy` in `temporal/api/common/v1/message.proto`](https://github.com/temporalio/sdk-rust/blob/85454935e39f789aaaa81f8a05773f8e2cdbcde2/protos/api_upstream/temporal/api/common/v1/message.proto#L96).
2727
*
2828
* The gRPC service methods are documented in the proto comments and in the corresponding [`Temporal CLI` docs](https://docs.temporal.io/cli/).
2929
* @module

packages/test/src/run-activation-perf-tests.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -104,7 +104,7 @@ if (!wf.inWorkflowContext()) {
104104
async function activate(workflow: VMWorkflow, activation: coresdk.workflow_activation.IWorkflowActivation) {
105105
// Core guarantees the following jobs ordering:
106106
// initWf -> patches -> update random seed -> signals+update -> others -> Resolve LA
107-
// reference: github.com/temporalio/sdk-core/blob/a8150d5c7c3fc1bfd5a941fd315abff1556cd9dc/core/src/worker/workflow/mod.rs#L1363-L1378
107+
// reference: github.com/temporalio/sdk-rust/blob/a8150d5c7c3fc1bfd5a941fd315abff1556cd9dc/core/src/worker/workflow/mod.rs#L1363-L1378
108108
// Tests are likely to fail if we artifically make an activation that does not follow that order
109109
const jobs: coresdk.workflow_activation.IWorkflowActivationJob[] = activation.jobs ?? [];
110110
function getPriority(job: coresdk.workflow_activation.IWorkflowActivationJob) {

packages/test/src/test-workflows.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -142,7 +142,7 @@ async function activate(t: ExecutionContext<Context>, activation: coresdk.workfl
142142

143143
// Core guarantees the following jobs ordering:
144144
// initWf -> patches -> update random seed -> signals+update -> others -> Resolve LA
145-
// reference: github.com/temporalio/sdk-core/blob/a8150d5c7c3fc1bfd5a941fd315abff1556cd9dc/core/src/worker/workflow/mod.rs#L1363-L1378
145+
// reference: github.com/temporalio/sdk-rust/blob/a8150d5c7c3fc1bfd5a941fd315abff1556cd9dc/core/src/worker/workflow/mod.rs#L1363-L1378
146146
// Tests are likely to fail if we artifically make an activation that does not follow that order
147147
const jobs: coresdk.workflow_activation.IWorkflowActivationJob[] = activation.jobs ?? [];
148148
function getPriority(job: coresdk.workflow_activation.IWorkflowActivationJob) {

packages/test/src/workflows/core-issue-589.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ import { unblockSignal } from './definitions';
44

55
const { customLogger } = wf.proxySinks<CustomLoggerSinks>();
66

7-
// Demo for https://github.com/temporalio/sdk-core/issues/589
7+
// Demo for https://github.com/temporalio/sdk-rust/issues/589
88
export async function coreIssue589(): Promise<void> {
99
wf.setHandler(wf.defineQuery('q'), () => {
1010
return 'not important';

0 commit comments

Comments
 (0)