Changed to path/filepath, added min TLS in server connection (#10)

Co-authored-by: Abhinav Nekkanti <10552725+anekkanti@users.noreply.github.com>
Co-authored-by: mattkim <matt@temporal.io>

Author: 3 people

app/connection.go

@@ -28,6 +28,7 @@ func GetServerConnection(c *cli.Context) (context.Context, *grpc.ClientConn, err
 		option = grpc.WithInsecure()
 	default:
 		option = grpc.WithTransportCredentials(credentials.NewTLS(&tls.Config{
+			MinVersion: tls.VersionTLS12,
 			ServerName: hostname,
 		}))
 	}

app/flags.go

@@ -2,7 +2,7 @@ package app
 
 import (
 	"os"
-	"path"
+	"path/filepath"
 
 	"github.com/urfave/cli/v2"
 )
@@ -27,7 +27,7 @@ var (
 	}
 	ConfigDirFlag = &cli.PathFlag{
 		Name:     ConfigDirFlagName,
-		Value:    path.Join(os.Getenv("HOME"), ".config", "tcld"),
+		Value:    filepath.Join(os.Getenv("HOME"), ".config", "tcld"),
 		Usage:    "the config directory to use",
 		Hidden:   true,
 		Required: false,

app/login.go

@@ -8,7 +8,7 @@ import (
 	"net/http"
 	"net/url"
 	"os"
-	"path"
+	"path/filepath"
 	"strings"
 	"time"
 
@@ -56,7 +56,7 @@ type (
 
 func getTokenConfigPath(ctx *cli.Context) string {
 	configDir := ctx.Path(ConfigDirFlagName)
-	return path.Join(configDir, tokenFileName)
+	return filepath.Join(configDir, tokenFileName)
 }
 
 // TODO: support login config on windows