Add ff back for export (#299)

Author: alice-yin

app/feature.go

@@ -11,11 +11,12 @@ import (
 )
 
 var (
+	ExportFeatureFlag   = "enable-export"
 	GCPSinkFeatureFlag  = "enable-gcp-sink"
 	featureflagFileName = "feature.json"
 )
 
-var supportFeatureFlags = []string{GCPSinkFeatureFlag}
+var supportFeatureFlags = []string{GCPSinkFeatureFlag, ExportFeatureFlag}
 
 type FeatureFlag struct {
 	Name  string `json:"Name"`
@@ -118,6 +119,14 @@ func NewFeatureCommand() (CommandOut, error) {
 			Usage:   "feature commands",
 			Hidden:  true,
 			Subcommands: []*cli.Command{
+				{
+					Name:    "toggle-export",
+					Aliases: []string{"te"},
+					Usage:   "switch export on/off",
+					Action: func(c *cli.Context) error {
+						return toggleFeature(ExportFeatureFlag)
+					},
+				},
 				{
 					Name:    "toggle-gcp-sink",
 					Aliases: []string{"tgs"},

app/namespace.go

@@ -1648,17 +1648,20 @@ func NewNamespaceCommand(getNamespaceClientFn GetNamespaceClientFn) (CommandOut,
 		},
 	}
 
-	exportS3Commands.Subcommands = append(exportS3Commands.Subcommands, exportGeneralCommands...)
-	exportCommand.Subcommands = append(exportCommand.Subcommands, exportS3Commands)
+	// TODO: remove Export sink feature flag check when out of pre-release
+	if IsFeatureEnabled(ExportFeatureFlag) {
+		exportS3Commands.Subcommands = append(exportS3Commands.Subcommands, exportGeneralCommands...)
+		exportCommand.Subcommands = append(exportCommand.Subcommands, exportS3Commands)
+
+		// TODO: remove GCP sink feature flag check when out of pre-release
+		if IsFeatureEnabled(GCPSinkFeatureFlag) {
+			exportGCSCommands.Subcommands = append(exportGCSCommands.Subcommands, exportGeneralCommands...)
+			exportCommand.Subcommands = append(exportCommand.Subcommands, exportGCSCommands)
+		}
 
-	// TODO: remove GCP sink feature flag check when out of pre-release
-	if IsFeatureEnabled(GCPSinkFeatureFlag) {
-		exportGCSCommands.Subcommands = append(exportGCSCommands.Subcommands, exportGeneralCommands...)
-		exportCommand.Subcommands = append(exportCommand.Subcommands, exportGCSCommands)
+		subCommands = append(subCommands, exportCommand)
 	}
 
-	subCommands = append(subCommands, exportCommand)
-
 	command := &cli.Command{
 		Name:    "namespace",
 		Aliases: []string{"n"},

app/namespace_test.go

@@ -46,6 +46,9 @@ func (s *NamespaceTestSuite) SetupTest() {
 		},
 	}
 
+	err = s.RunCmd("feature", "toggle-export")
+	s.Require().NoError(err)
+
 	err = s.RunCmd("feature", "toggle-gcp-sink")
 	s.Require().NoError(err)