Skip to content

Commit 89fff33

Browse files
authored
remove service account FF toggle (#386)
1 parent 5fbbd58 commit 89fff33

2 files changed

Lines changed: 5 additions & 18 deletions

File tree

app/app.go

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -32,11 +32,7 @@ func NewApp(params AppParams) (*cli.App, error) {
3232
var commands []*cli.Command
3333

3434
for _, command := range params.Commands {
35-
if command.Name == "service-account" {
36-
if IsFeatureEnabled(ServiceAccountFeatureFlag) {
37-
commands = append(commands, command)
38-
}
39-
} else if command.Name == "nexus" {
35+
if command.Name == "nexus" {
4036
if IsFeatureEnabled(NexusFeatureFlag) {
4137
commands = append(commands, command)
4238
}

app/feature.go

Lines changed: 4 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -11,13 +11,12 @@ import (
1111
)
1212

1313
var (
14-
GCPSinkFeatureFlag = "enable-gcp-sink"
15-
ServiceAccountFeatureFlag = "enable-service-account"
16-
NexusFeatureFlag = "enable-nexus"
17-
featureflagFileName = "feature.json"
14+
GCPSinkFeatureFlag = "enable-gcp-sink"
15+
NexusFeatureFlag = "enable-nexus"
16+
featureflagFileName = "feature.json"
1817
)
1918

20-
var supportFeatureFlags = []string{GCPSinkFeatureFlag, ServiceAccountFeatureFlag, NexusFeatureFlag}
19+
var supportFeatureFlags = []string{GCPSinkFeatureFlag, NexusFeatureFlag}
2120

2221
type FeatureFlag struct {
2322
Name string `json:"Name"`
@@ -134,14 +133,6 @@ func NewFeatureCommand() (CommandOut, error) {
134133
return toggleFeature(GCPSinkFeatureFlag)
135134
},
136135
},
137-
{
138-
Name: "toggle-service-account",
139-
Aliases: []string{"tsa"},
140-
Usage: "switch service account on/off",
141-
Action: func(c *cli.Context) error {
142-
return toggleFeature(ServiceAccountFeatureFlag)
143-
},
144-
},
145136
{
146137
Name: "toggle-nexus",
147138
Aliases: []string{"tnxs"},

0 commit comments

Comments
 (0)