Skip to content

Commit b0ce484

Browse files
committed
remove enabled as flag for validate
1 parent c13dd6b commit b0ce484

2 files changed

Lines changed: 11 additions & 11 deletions

File tree

app/account.go

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -646,7 +646,6 @@ func NewAccountCommand(getAccountClientFn GetAccountClientFn) (CommandOut, error
646646
Flags: []cli.Flag{
647647
// general audit log sink flags
648648
sinkNameFlag,
649-
sinkEnabledFlag,
650649
// kinesis audit log sink flags
651650
roleNameFlag,
652651
destinationUriFlag,
@@ -776,7 +775,6 @@ func NewAccountCommand(getAccountClientFn GetAccountClientFn) (CommandOut, error
776775
Flags: []cli.Flag{
777776
// general audit log sink flags
778777
sinkNameFlag,
779-
sinkEnabledFlag,
780778
// pubsub audit log sink flags
781779
sinkServiceAccountEmailFlag,
782780
topicNameFlag,

app/account_test.go

Lines changed: 11 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1048,14 +1048,15 @@ func (s *AccountTestSuite) TestValidateAuditLogSink() {
10481048
}{
10491049
{
10501050
name: "kinesis audit log sink",
1051-
args: []string{"a", "al", "kinesis", "validate", "--sink-name", "audit_log_01",
1051+
args: []string{"a", "al", "kinesis", "validate",
1052+
"--sink-name", "test-sink",
10521053
"--role-name", "TestRole",
10531054
"--destination-uri", "arn:aws:kinesis:us-east-1:123456789012:stream/TestStream",
1054-
"--region", "us-east-1", "--enabled", "true"},
1055+
"--region", "us-east-1"},
10551056
expectErr: false,
10561057
expectRequest: cloudservice.ValidateAccountAuditLogSinkRequest{
10571058
Spec: &cloudaccount.AuditLogSinkSpec{
1058-
Name: "audit_log_01",
1059+
Name: "test-sink",
10591060
Enabled: true,
10601061
SinkType: &cloudaccount.AuditLogSinkSpec_KinesisSink{
10611062
KinesisSink: &cloudSink.KinesisSpec{
@@ -1069,14 +1070,15 @@ func (s *AccountTestSuite) TestValidateAuditLogSink() {
10691070
},
10701071
{
10711072
name: "kinesis audit log sink with error",
1072-
args: []string{"a", "al", "kinesis", "validate", "--sink-name", "audit_log_01",
1073+
args: []string{"a", "al", "kinesis", "validate",
1074+
"--sink-name", "test-sink",
10731075
"--role-name", "TestRole",
10741076
"--destination-uri", "arn:aws:kinesis:us-east-1:123456789012:stream/TestStream",
1075-
"--region", "us-east-1", "--enabled", "true"},
1077+
"--region", "us-east-1"},
10761078
expectErr: true,
10771079
expectRequest: cloudservice.ValidateAccountAuditLogSinkRequest{
10781080
Spec: &cloudaccount.AuditLogSinkSpec{
1079-
Name: "audit_log_01",
1081+
Name: "test-sink",
10801082
Enabled: true,
10811083
SinkType: &cloudaccount.AuditLogSinkSpec_KinesisSink{
10821084
KinesisSink: &cloudSink.KinesisSpec{
@@ -1091,13 +1093,13 @@ func (s *AccountTestSuite) TestValidateAuditLogSink() {
10911093
},
10921094
{
10931095
name: "pubsub audit log sink",
1094-
args: []string{"a", "al", "pubsub", "validate", "--sink-name", "audit_log_01",
1095-
"--enabled", "true",
1096+
args: []string{"a", "al", "pubsub", "validate",
1097+
"--sink-name", "test-sink",
10961098
"--service-account-email", "123456789012@TestProject.iam.gserviceaccount.com", "--topic-name", "TestTopic"},
10971099
expectErr: false,
10981100
expectRequest: cloudservice.ValidateAccountAuditLogSinkRequest{
10991101
Spec: &cloudaccount.AuditLogSinkSpec{
1100-
Name: "audit_log_01",
1102+
Name: "test-sink",
11011103
Enabled: true,
11021104
SinkType: &cloudaccount.AuditLogSinkSpec_PubSubSink{
11031105
PubSubSink: &cloudSink.PubSubSpec{

0 commit comments

Comments
 (0)